NodeJS API开发报错：Can't set headers after they are sent 求助

Hey there! Let's break down why you're hitting that frustrating error and how to fix it.

The Root Cause #

Your current code has two critical issues:

1. Multiple res.send() calls: In your files.forEach loop, you call res.send(data) for every file in the ./maps directory. But once you run res.send(), Node.js sends the HTTP response and closes the connection. When the loop tries to send a second response, it throws the error because the response channel is already closed.
2. Incorrect file path: You're using fs.readFile(file, ...) but file is just the filename—Node.js will look for it in your project root instead of the ./maps folder, which will cause file-not-found errors.

The Fix #

We'll rewrite the code using async/await (cleaner than nested callbacks) and ensure we only send one response after collecting all file contents. Here's the corrected version:

const fs = require('fs').promises; // Use promise-based fs for easier async handling
const path = require('path'); // For safe path joining

router.get('/posts', async (req, res) => {
  try {
    // 1. Get all files in the ./maps directory
    const files = await fs.readdir('./maps');
    
    // 2. Read each file's content (with correct path) and wait for all to finish
    const allFileContents = await Promise.all(
      files.map(file => fs.readFile(path.join('./maps', file), 'utf8'))
    );
    
    // 3. Send all collected content in a single response
    res.send(allFileContents);
  } catch (error) {
    // Handle errors gracefully instead of crashing the server
    console.error('Error reading files:', error);
    res.status(500).send('Failed to load file content');
  }
});

Key Improvements #

• Single response: We use Promise.all to wait for all files to be read, then send all content at once with a single res.send()—no more duplicate response attempts.
• Correct paths: path.join('./maps', file) ensures we're always reading from the right directory, regardless of where your server is running.
• Proper error handling: The try/catch block catches file read errors and returns a 500 status code instead of crashing your server.

If You Need to Return a Single File #

If your goal was to send content from one specific file (not all), adjust your route to accept a filename parameter instead:

router.get('/posts/:filename', async (req, res) => {
  try {
    const filename = req.params.filename;
    const fileContent = await fs.readFile(path.join('./maps', filename), 'utf8');
    res.send(fileContent);
  } catch (error) {
    console.error('Error reading file:', error);
    res.status(404).send('File not found');
  }
});

This way, your Angular frontend can request GET /posts/my-file.txt to get the content of a specific file, and you'll only send one response per request.

内容的提问来源于stack exchange，提问作者simonmnt