Android通过Socket向PC发送图片时触发NullPointerException求助

Hey, let's break down why you're hitting those java.lang.NullPointerException errors in your SendImageTask — it's almost certainly related to uninitialized values or missing checks.

异常原因分析 #

Looking at your code and the error lines (14 and 25 in SendImageTask), here are the two most likely culprits:

• Uninitialized selectedImagePath: If the user taps the "Send" button before selecting an image, MainActivity.selectedImagePath stays null. When you try to create a File with this null value, the File constructor throws a NullPointerException immediately (this matches your line 14 error).
• Unclosed resources or failed Socket connections: While less likely, if the Socket connection fails (e.g., wrong IP, no network), subsequent stream operations might hit null objects. But the first reason is far more common here.

Fixes to Apply #

1. Add a Pre-Check Before Sending #

First, prevent the AsyncTask from running at all if no image is selected. Update your send button click listener in MainActivity:

send.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View arg0) {
        // Check if an image was actually selected
        if (MainActivity.selectedImagePath == null || MainActivity.selectedImagePath.trim().isEmpty()) {
            Toast.makeText(MainActivity.this, "请先选择图片！", Toast.LENGTH_SHORT).show();
            return;
        }
        new SendImageTask().execute();
    }
});

2. Make SendImageTask Null-Safe #

Even with the pre-check, add safeguards inside the AsyncTask to handle edge cases, plus proper resource cleanup to avoid leaks:

class SendImageTask extends AsyncTask<Void, Void, Void> {
    @Override
    protected Void doInBackground(Void... voids) {
        Socket sock = null;
        BufferedInputStream bis = null;
        OutputStream os = null;

        try {
            String imagePath = MainActivity.selectedImagePath;
            // Double-check the path isn't null/empty
            if (imagePath == null || imagePath.trim().isEmpty()) {
                Log.e("SendImageTask", "图片路径为空，无法发送");
                return null;
            }

            File myFile = new File(imagePath);
            // Verify the file exists and is readable
            if (!myFile.exists() || !myFile.canRead()) {
                Log.e("SendImageTask", "文件不存在或无法读取");
                return null;
            }

            // Replace "myip" with your PC's actual local IP (e.g., 192.168.1.105)
            sock = new Socket("192.168.1.105", 8000);
            Log.d("SendImageTask", "已连接到服务器");

            byte[] mybytearray = new byte[(int) myFile.length()];
            FileInputStream fis = new FileInputStream(myFile);
            bis = new BufferedInputStream(fis);
            bis.read(mybytearray, 0, mybytearray.length);

            os = sock.getOutputStream();
            Log.d("SendImageTask", "开始发送图片...");
            os.write(mybytearray, 0, mybytearray.length);
            os.flush();
            Log.d("SendImageTask", "图片发送完成");

        } catch (UnknownHostException e) {
            Log.e("SendImageTask", "无法识别主机地址", e);
        } catch (IOException e) {
            Log.e("SendImageTask", "IO异常", e);
        } finally {
            // Always close resources to avoid leaks
            try {
                if (bis != null) bis.close();
                if (os != null) os.close();
                if (sock != null) sock.close();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
        return null;
    }
}

3. Additional Important Checks #

• Replace myip: Make sure you use your PC's actual local network IP address (find this via ipconfig on Windows or ifconfig on macOS/Linux).
• Add Network Permission: Don't forget to add this to your AndroidManifest.xml or the app will fail to connect:

  <uses-permission android:name="android.permission.INTERNET" />
  

• Android 10+ Compatibility: Your getPath method won't work on Android 10 and above due to storage restrictions. For newer versions, use ContentResolver to read the image stream directly instead of relying on file paths.

内容的提问来源于stack exchange，提问作者user5429574