C# LinkedList反转报错：节点不属于当前链表问题求助

Hey there! Let's break down why you're hitting that "The LinkedList node does not belong to current LinkedList" error, and fix your reorderList method.

What's Causing the Error? #

The core issue here is your loop runs too many times, leading you to try using a lastNode that's no longer part of the linked list. Let's walk through a concrete example with a list [A, B, C, D] to see exactly what happens:

1. Initial setup:

   • lastNode = list.Last (this is node D)
   • list.RemoveLast() → list becomes [A, B, C]
   • list.AddFirst(lastNode) → list becomes [D, A, B, C]
   • lastNode = list.First (now points to node D)

2. Your loop runs list.Count times (4 times total for this example):

   • i=1:
     • a = list.Last (node C)
     • list.RemoveLast() → list is [D, A, B]
     • list.AddAfter(lastNode, a) → list becomes [D, C, A, B]
     • lastNode = a (now points to node C)
   • i=2:
     • a = list.Last (node B)
     • list.RemoveLast() → list is [D, C, A]
     • list.AddAfter(lastNode, a) → list becomes [D, C, B, A]
     • lastNode = a (now points to node B)
   • i=3:
     • a = list.Last (node A)
     • list.RemoveLast() → list is [D, C, B]
     • list.AddAfter(lastNode, a) → list becomes [D, C, B, A]
     • lastNode = a (now points to node A)
   • i=4:
     • a = list.Last (node A, since the list is [D, C, B, A])
     • list.RemoveLast() → list becomes [D, C, B], and node A is no longer part of the list
     • Now you call list.AddAfter(lastNode, a) — but lastNode is node A, which was just removed from the list! This is exactly what triggers the error.

Fixing the Method #

Since your goal is to reverse the linked list (or reorder it by moving last nodes to the front sequence), we have two reliable fixes depending on your preferred approach:

Option 1: Simplified Reverse Logic

This approach moves each last node to the front of the list, which is straightforward and avoids invalid node references:

public static void ReverseLinkedList(LinkedList<string> list) 
{ 
    // Edge case: no need to reverse empty or single-item lists
    if (list == null || list.Count <= 1)
        return;

    int totalNodes = list.Count;
    // We only need to move (totalNodes - 1) nodes to build reversed order
    for (int i = 1; i < totalNodes; i++)
    {
        LinkedListNode<string> lastNode = list.Last;
        list.RemoveLast();
        // Add the last node before the current first node
        list.AddBefore(list.First, lastNode);
    }
}

Option 2: Adjusted Version of Your Original Approach

If you want to stick to moving nodes after the previously moved node, adjust the loop to run list.Count - 2 times (since you've already handled the first node move):

public static void ReorderList(LinkedList<string> list) 
{ 
    if (list == null || list.Count <= 1)
        return;

    LinkedListNode<string> lastNode = list.Last; 
    list.RemoveLast(); 
    list.AddFirst(lastNode); 

    // Only need to move (count - 2) more nodes to complete the sequence
    int times = list.Count - 2;
    for (int i = 0; i < times; i++) 
    { 
        LinkedListNode<string> a = list.Last; 
        list.RemoveLast(); 
        list.AddAfter(lastNode, a); 
        lastNode = a; 
    } 
}

Quick Note on LinkedList<T> in C# #

Remember that LinkedListNode<T>'s Next and Previous properties are read-only, so you can't directly modify node pointers to reverse the list. You must use the list's built-in methods (AddBefore, AddAfter, RemoveLast, etc.) to manipulate the structure safely.

内容的提问来源于stack exchange，提问作者Chase