如何将两个Person生成类的重复代码抽离到新类实现复用
代码复用解决方案
实现思路
利用DKKRPerson继承GKVPerson的类结构,创建抽象泛型父类封装所有公共逻辑,仅将对象实例化、特有属性填充两类差异逻辑作为抽象方法交给子类实现,完全消除重复代码。
具体实现代码
1. 抽象公共父类 BasePersonGenerator
import java.util.ArrayList; import java.util.List; import java.util.Random; import java.util.Scanner; public abstract class BasePersonGenerator<T extends GKVPerson> { protected Random randomItem = new Random(); // 公共生成主流程,子类直接调用 public List<T> generatePersons(List<PersonFirstName> personFirstNames, List<Street> streets, List<PersonLastName> personLastNames, List<City> cities, String personType) { List<T> resultList = new ArrayList<>(); Scanner in = new Scanner(System.in); System.out.printf("Number of %s, who will be generated: ", personType); int numberOfRecords = in.nextInt(); in.close(); for (int i = 0; i < numberOfRecords; i++) { // 公共参数生成 int matching = randomItem.nextInt(personFirstNames.size()); int matchingBirthData = randomItem.nextInt(cities.size()); int matchingCityZipCode = randomItem.nextInt(cities.size()); int birthYear = generateRandomNumber(1973, 2021); // 子类实现:创建对应类型的Person实例 T person = createPersonInstance(); // 公共属性填充 person.setId(i + 1); person.setFirstName(personFirstNames.get(matching).getFirstName()); person.setGender(personFirstNames.get(matching).getGender()); person.setLastName(personLastNames.get(randomItem.nextInt(personLastNames.size())).getLastName()); person.setFirstBirthName(personFirstNames.get(matching).getFirstName()); person.setLastBirthName(personLastNames.get(randomItem.nextInt(personLastNames.size())).getLastName()); person.setBirthDate(generateBirthDate() + birthYear); person.setBirthYear(birthYear); person.setLivingPlaceCityNow(cities.get(matchingCityZipCode).getCity()); person.setLivingPlaceStreetNameNow(streets.get(randomItem.nextInt(streets.size())).getStreetName()); person.setLivingPlaceHouseNumberNow(generateRandomNumber(1, 200)); person.setLivingPlaceZipCodeNow(cities.get(matchingCityZipCode).getZipCode()); person.setBirthPlaceCityName(cities.get(matchingBirthData).getCity()); person.setBirthPlaceZipCode(cities.get(matchingBirthData).getZipCode()); // 子类实现:填充特有属性 fillExtraProperties(person, personFirstNames, streets, personLastNames, cities); resultList.add(person); } return resultList; } protected abstract T createPersonInstance(); protected abstract void fillExtraProperties(T person, List<PersonFirstName> personFirstNames, List<Street> streets, List<PersonLastName> personLastNames, List<City> cities); // 公共工具方法 public static int generateRandomNumber(int min, int max) { return (int) (Math.random() * (max - min)) + min; } public String generateBirthDate() { String birthDate = ""; int month = generateRandomNumber(1, 12); int day; if (month % 2 == 0) { day = generateRandomNumber(1, 30); } else if (month == 2) { day = generateRandomNumber(1, 28); } else { day = generateRandomNumber(1, 31); } if (month >= 10 && day >= 10) { birthDate = day + "." + month + "."; } else if (month < 10 && day < 10) { birthDate = "0" + day + "." + "0" + month + "."; } else if (month < 10 && day >= 10) { birthDate = day + "." + "0" + month + "." ; } else if (month >= 10 && day < 10) { birthDate = "0" + day + "." + month + "."; } return birthDate; } }
2. 简化后的 GenerateGkvPerson 子类
import java.util.List; public class GenerateGkvPerson extends BasePersonGenerator<GKVPerson> { public List<GKVPerson> generatedGkvPersons(List<PersonFirstName> personFirstNames, List<Street> streets, List<PersonLastName> personLastNames, List<City> cities) { return generatePersons(personFirstNames, streets, personLastNames, cities, "GKVPersons"); } @Override protected GKVPerson createPersonInstance() { return new GKVPerson(); } @Override protected void fillExtraProperties(GKVPerson person, List<PersonFirstName> personFirstNames, List<Street> streets, List<PersonLastName> personLastNames, List<City> cities) { // GKVPerson无额外属性,无需实现逻辑 } }
3. 简化后的 GenerateDkkrPerson 子类
import java.util.List; public class GenerateDkkrPerson extends BasePersonGenerator<DKKRPerson> { public List<DKKRPerson> generateDkkrPerson(List<PersonFirstName> personFirstNames, List<Street> streets, List<PersonLastName> personLastNames, List<City> cities) { return generatePersons(personFirstNames, streets, personLastNames, cities, "DKKRPersons"); } @Override protected DKKRPerson createPersonInstance() { return new DKKRPerson(); } @Override protected void fillExtraProperties(DKKRPerson person, List<PersonFirstName> personFirstNames, List<Street> streets, List<PersonLastName> personLastNames, List<City> cities) { int matchingDiagnoseCity = randomItem.nextInt(cities.size()); int matchingParentsCityData = randomItem.nextInt(cities.size()); int matchingParentsStreetData = randomItem.nextInt(streets.size()); int matchingParentsHouseNumber = generateRandomNumber(1, 200); person.setDiagnoseStreetName(streets.get(randomItem.nextInt(streets.size())).getStreetName()); person.setDiagnoseHouseNumber(generateRandomNumber(1, 200)); person.setDiagnoseCityName(cities.get(matchingDiagnoseCity).getCity()); person.setDiagnoseZipCode(cities.get(matchingDiagnoseCity).getZipCode()); person.setParentsStreetName(streets.get(matchingParentsStreetData).getStreetName()); person.setParentsHouseNumber(matchingParentsHouseNumber); person.setParentsCityName(cities.get(matchingParentsCityData).getCity()); person.setParentsZipCode(cities.get(matchingParentsCityData).getZipCode()); person.setMotherStreetName(streets.get(matchingParentsStreetData).getStreetName()); person.setMotherHouseNumber(matchingParentsHouseNumber); person.setMotherCityName(cities.get(matchingParentsCityData).getCity()); person.setMotherZipCode(cities.get(matchingParentsCityData).getZipCode()); person.setFatherStreetName(streets.get(matchingParentsStreetData).getStreetName()); person.setFatherHouseNumber(matchingParentsHouseNumber); person.setFatherCityName(cities.get(matchingParentsCityData).getCity()); person.setFatherZipCode(cities.get(matchingParentsCityData).getZipCode()); } }
优化说明
- 完全消除了工具方法、生成主流程、通用属性填充的重复代码,后续公共逻辑迭代仅需修改父类即可同步生效
- 泛型约束保证返回的列表类型安全,无需额外类型转换
- 符合开闭原则,后续新增其他Person子类生成器时,仅需继承父类实现两个抽象方法即可,不需要重复编写公共逻辑
- 父类统一处理资源释放(如Scanner关闭)、随机数配置等通用能力,避免重复编码
内容的提问来源于stack exchange,提问作者dredster01
相关产品推荐
相关产品推荐

