已手动关闭FileOutputStream，SonarLint仍提示需用try-with-resources或finally关闭？

Hey there! Let's break down why SonarLint is still flagging your code, and fix it for good.

Why Your Current Code Triggers the Warning #

Your existing close logic has a critical gap: it only runs if the code reaches that specific if(os != null) block. If an exception gets thrown after you create the OutputStream but before you call close(), your program will jump straight to exception handling, skipping the close entirely. That leaves the file resource hanging, which is exactly what SonarLint is warning you about.

Plus, if new FileOutputStream(file) itself throws an exception (like missing file permissions or a non-existent path), os never gets initialized—but that's a secondary issue compared to the unguarded close.

The Best Fix: Use Try-With-Resources (Java 7+) #

This is the cleanest, safest approach introduced in Java 7. Any resource that implements AutoCloseable (which FileOutputStream does) will be automatically closed when the try block finishes—whether it exits normally or throws an exception. SonarLint will immediately stop complaining about this.

Here's how to rewrite your code:

try (OutputStream os = new FileOutputStream(file)) {
    // Put your file-writing logic here, e.g., os.write(...)
} catch (IOException e) {
    e.printStackTrace();
}

Fallback: Use a Finally Block (For Pre-Java 7) #

If you're stuck on an older Java version, you need to wrap your close logic in a finally block. This guarantees the close runs no matter what happens in the try block.

Here's the corrected code:

OutputStream os = null;
try {
    os = new FileOutputStream(file);
    // Your file operations go here
} catch (IOException e) {
    e.printStackTrace();
} finally {
    if (os != null) {
        try {
            os.close();
        } catch (IOException e) {
            e.printStackTrace();
        }
    }
}

Either of these approaches will ensure your FileOutputStream is always closed, resolving SonarLint's resource leak warning.

内容的提问来源于stack exchange，提问作者HS447