Laravel API响应能否根据产品有效deal状态返回不同模型？

问题原因 #

接口返回null的直接原因是：重构后的ProductResource中，if($this->deals)分支只创建了DealResource实例，没有加return语句，走到该分支时函数无返回值，自然输出null。

此外现有实现还有3个不符合需求的问题：

• 未对deals做「生效中」的条件过滤，会把所有过期/未生效的deal都算进去
• 需求要求返回单层数组，但当前if分支返回的是DealResource集合，不符合单条数据的要求
• 控制器中with('deals')重复写了两次，查询逻辑冗余

修复步骤 #

1. 新增生效deal关联（可选但推荐） #

在Product.php中新增预定义的生效deal关联，方便后续统一过滤，避免重复写条件：

// Product.php
public function activeDeals()
{
    return $this->hasMany(Deal::class, 'product_id')
        // 此处替换为你自己的生效判断规则，例如开始时间<=当前、结束时间>=当前
        ->where('start_at', '<=', now())
        ->where('end_at', '>=', now())
        ->latest();
}

2. 优化控制器查询逻辑 #

把关联预加载提到公共逻辑，避免重复代码：

public function index(Request $request)
{
    $per_page = $request->per_page ?? 10;

    $products = Product::query()
        ->latest()
        // 统一预加载生效deal，不需要在两个when里重复写
        ->with('activeDeals')
        ->when($request->query('filter'), function ($query) use ($request) {
            $query->where('title', 'LIKE', "%{$request->filter}%");
        })
        ->when($request->query('category'), function ($query) use ($request) {
            $query->whereHas('categories', function ($q) use ($request) {
                $q->where('title', 'LIKE', "%{$request->category}%");
            });
        })
        ->paginate($per_page);
        
    return new PaginatedCollection($products, ProductResource::class);
}

3. 修复ProductResource逻辑 #

补全return语句，调整返回逻辑符合需求：

<?php

namespace App\Http\Resources;

use Illuminate\Http\Resources\Json\JsonResource;

class ProductResource extends JsonResource
{
    public function toArray($request)
    {
        // 优先判断是否存在生效的deal
        if ($this->activeDeals->isNotEmpty()) {
            // 取第一条生效deal，返回单层数组结构
            return (new DealResource($this->activeDeals->first()))->toArray($request);
        }

        // 无生效deal时返回产品本身数据
        $details = array_filter($this->details ?: [], function ($d) {
            return $d != "";
        });

        $personalizedOptions = array_filter($this->personalized_options ?: [], function ($o) {
            return $o != "";
        });

        return [
            'id'                    => $this->id,
            'createdAt'             => $this->created_at,
            'updatedAt'             => $this->updated_at,
            'title'                 => $this->title,
            'sellerId'              => $this->sellerId,
            'description'           => $this->description,
            'categories'            => CategoryResource::collection($this->categories),
            'details'               => $details,
            'active'                => (bool) $this->active,
            'defaultPreviewImageId' => $this->default_preview_image_id,
            'originalPrice'         => $this->originalPrice,
            'shippingPrice'         => $this->shippingPrice,
            'shippingWeightLbs'     => $this->shippingWeightLbs,
            'shippingWeightOz'      => $this->shippingWeightOz,
            'shippingMaxDays'       => $this->shipping_max_days,
            'shippingMinDays'       => $this->shipping_min_days,
            'personalized'          => (bool) $this->personalized,
            'personalizedOptions'   => $personalizedOptions,
            'options'               => ProductOptionResource::collection($this->productOptions),
            'images'                => ImageResource::collection($this->images->whereNull('meta')),
            'preview'               => new ImageResource($this->images->where('meta', '=', 'preview')->first()),
        ];
    }
}

额外优化建议 #

你当前Deal.php中定义的product关联用了hasOne，实际属于从属关联，建议改成belongsTo更符合Eloquent规范：

// Deal.php
public function product()
{
    return $this->belongsTo(Product::class, 'product_id');
}

内容的提问来源于stack exchange，提问作者Evidence Ekanem