自定义Confirm框传参时报Uncaught SyntaxError: Unexpected identifier错误
报错原因
- 你传入模板字符串的
x是DOM元素对象,直接用${x}插入字符串时,对象会被默认转为[object HTMLxxxElement]格式的字符串 - 最终生成的
onclick属性值里的代码会变成类似confirmDelete(event.target, 123, [object HTMLButtonElement]),这段代码执行时,[object会被解析成不合法的语法结构,直接抛出标识符异常 - 而
bookID是数字类型,转字符串后就是合法的数字字面量,所以去掉最后一个参数就不会报错
解决方案
方案1(最推荐):不用内联onclick,改用动态绑定事件
避免字符串拼接代码的各种语法坑,直接在JS逻辑里传递DOM对象:
function deleteBookCard(x, bookID) { // 去掉button标签里的onclick属性 let confirmBox = ` <div class="confirm-screen"> <div class="confirm-box"> <div class="delete-msg">Are you sure you want to delete "<span>${myBooks[bookID - 1].title}</span>"? </div> <div class="confirm-cancel-btn"> <button class="confirm-btn">Confirm</button> <button class="cancel-btn">Cancel</button> </div> </div> </div> `; const insertTarget = x.parentNode.parentNode.parentNode.parentNode.parentNode.parentNode; insertTarget.insertAdjacentHTML("beforebegin", confirmBox); // 给刚插入的按钮绑定点击事件 const confirmWrap = insertTarget.previousElementSibling; confirmWrap.querySelector('.confirm-btn').addEventListener('click', e => { confirmDelete(e.target, bookID, x); }); confirmWrap.querySelector('.cancel-btn').addEventListener('click', e => { confirmDelete(e.target, bookID, x); }); }
方案2:通过唯一标识传递DOM引用
如果一定要保留内联onclick写法,可以给触发元素加唯一id,在onclick里通过id获取DOM:
function deleteBookCard(x, bookID) { // 给触发删除的元素设置唯一id const triggerId = `del-trigger-${bookID}-${Date.now()}`; x.id = triggerId; // 模板字符串里直接写获取元素的逻辑 let confirmBox = ` <div class="confirm-screen"> <div class="confirm-box"> <div class="delete-msg">Are you sure you want to delete "<span>${myBooks[bookID - 1].title}</span>"? </div> <div class="confirm-cancel-btn"> <button class="confirm-btn" onclick="confirmDelete(event.target, ${bookID}, document.getElementById('${triggerId}'))">Confirm</button> <button class="cancel-btn" onclick="confirmDelete(event.target, ${bookID}, document.getElementById('${triggerId}'))">Cancel</button> </div> </div> </div> `; x.parentNode.parentNode.parentNode.parentNode.parentNode.parentNode.insertAdjacentHTML("beforebegin", confirmBox); }
内容的提问来源于stack exchange,提问作者leech
相关产品推荐
相关产品推荐

