Win32托盘通知菜单修改：更改菜单项文本与图标

Hey there, let's tackle your two menu modification issues step by step. I'll work with your existing class-based structure and address the common pitfalls that might have tripped you up earlier.

Problem 1: Toggle Menu Item Text (Start ↔ Stop) #

The core tool here is SetMenuItemInfoW (for Unicode, which is default in VS2019) to update the menu item's text. First, track your action's state (running or idle) with a class member, then trigger the text update when the menu item is clicked.

Step 1: Add Class Members #

Add these to your class header to manage state and menu references:

class YourTrayClass {
private:
    HMENU hmenu;
    HMENU menuTrackPopup;
    bool m_isActionRunning = false; // Tracks if your action is active

    // Helper to update menu text and icon
    void UpdateActionMenuItem();
public:
    // Your existing constructor, window procedure, etc.
};

Step 2: Implement the Update Function #

This function toggles the state and updates the menu text:

void YourTrayClass::UpdateActionMenuItem() {
    // Flip the action state first
    m_isActionRunning = !m_isActionRunning;

    MENUITEMINFOW mii = {0};
    mii.cbSize = sizeof(MENUITEMINFOW);
    mii.fMask = MIIM_TYPE; // Flag to modify text data

    // Set the new text based on current state
    const wchar_t* menuText = m_isActionRunning ? L"Stop Action" : L"Start Action";
    mii.dwTypeData = const_cast<wchar_t*>(menuText);
    mii.cch = lstrlenW(menuText);

    // Apply changes to the menu item (use your actual menu item ID, e.g., ID_ACTION_ITEM)
    SetMenuItemInfoW(menuTrackPopup, ID_ACTION_ITEM, FALSE, &mii);
}

Step 3: Trigger Update on Menu Click #

In your window procedure's WM_COMMAND case, call the helper when the menu item is selected:

case WM_COMMAND: {
    switch (LOWORD(wParam)) {
        case ID_ACTION_ITEM: {
            // Insert your start/stop action logic here
            // ...

            // Update the menu text
            pYourTrayInstance->UpdateActionMenuItem();
            break;
        }
        // Handle other menu items...
    }
    return 0;
}

Problem 2: Add/Update Menu Item Icons #

To swap icons alongside text, load your bitmaps once (in the constructor) and use either SetMenuItemBitmaps or SetMenuItemInfoW to assign them. The most common mistakes here are using the wrong menu handle or loading bitmaps incorrectly.

Step 1: Add Bitmap Members to Your Class #

class YourTrayClass {
private:
    // ... existing members ...
    HBITMAP m_hBmpStart; // Bitmap for "Start Action"
    HBITMAP m_hBmpStop;  // Bitmap for "Stop Action"
};

Step 2: Load Bitmaps in Constructor #

Load your menu bitmaps once (use your bitmap resource IDs, e.g., IDB_START_ICON and IDB_STOP_ICON):

YourTrayClass::YourTrayClass() {
    hmenu = LoadMenu(NULL, MAKEINTRESOURCE(IDR_MENU1));
    menuTrackPopup = GetSubMenu(hmenu, 0);

    // Load bitmaps (use GetLastError() to debug if these return NULL)
    m_hBmpStart = LoadBitmap(GetModuleHandle(NULL), MAKEINTRESOURCE(IDB_START_ICON));
    m_hBmpStop = LoadBitmap(GetModuleHandle(NULL), MAKEINTRESOURCE(IDB_STOP_ICON));

    // Initialize menu to start state
    m_isActionRunning = false;
    UpdateActionMenuItem();
}

Step 3: Update Icon in the Helper Function #

Modify UpdateActionMenuItem to include bitmap swapping. Choose either method below:

Method 1: Using SetMenuItemBitmaps (Simpler for Icons)

void YourTrayClass::UpdateActionMenuItem() {
    m_isActionRunning = !m_isActionRunning;

    // Update text (same as Problem 1)
    MENUITEMINFOW mii = {0};
    mii.cbSize = sizeof(MENUITEMINFOW);
    mii.fMask = MIIM_TYPE;
    const wchar_t* menuText = m_isActionRunning ? L"Stop Action" : L"Start Action";
    mii.dwTypeData = const_cast<wchar_t*>(menuText);
    mii.cch = lstrlenW(menuText);
    SetMenuItemInfoW(menuTrackPopup, ID_ACTION_ITEM, FALSE, &mii);

    // Update bitmap
    HBITMAP targetBitmap = m_isActionRunning ? m_hBmpStop : m_hBmpStart;
    SetMenuItemBitmaps(menuTrackPopup, ID_ACTION_ITEM, MF_BYCOMMAND, targetBitmap, NULL);
}

Method 2: Using SetMenuItemInfoW (Combine Text + Icon in One Call)

void YourTrayClass::UpdateActionMenuItem() {
    m_isActionRunning = !m_isActionRunning;

    MENUITEMINFOW mii = {0};
    mii.cbSize = sizeof(MENUITEMINFOW);
    mii.fMask = MIIM_TYPE | MIIM_BITMAP; // Modify both text and bitmap

    // Update text
    const wchar_t* menuText = m_isActionRunning ? L"Stop Action" : L"Start Action";
    mii.dwTypeData = const_cast<wchar_t*>(menuText);
    mii.cch = lstrlenW(menuText);

    // Update bitmap
    mii.hbmpUnchecked = m_isActionRunning ? m_hBmpStop : m_hBmpStart;
    mii.hbmpChecked = NULL; // No checked state needed here

    // Apply both changes at once
    SetMenuItemInfoW(menuTrackPopup, ID_ACTION_ITEM, FALSE, &mii);
}

Step 4: Clean Up Bitmaps #

Avoid memory leaks by deleting bitmaps when your class is destroyed:

YourTrayClass::~YourTrayClass() {
    if (m_hBmpStart) DeleteObject(m_hBmpStart);
    if (m_hBmpStop) DeleteObject(m_hBmpStop);
    if (hmenu) DestroyMenu(hmenu);
}

Common Pitfalls You Might Have Hit #

• Wrong Menu Handle: Always use menuTrackPopup (the submenu from GetSubMenu) instead of hmenu when modifying popup menu items. Using the main menu handle will have no effect.
• Bitmap Loading Failures: If LoadBitmap returns NULL, call GetLastError() to debug. Ensure your bitmaps are the correct size (16x16 is standard for menu icons) and marked as "Menu" in the resource editor.
• Unicode vs ANSI: Since VS2019 uses Unicode by default, use the W suffix functions (SetMenuItemInfoW, GetMenuItemInfoW) to avoid string mismatches.
• Forgetting cbSize: The MENUITEMINFOW struct requires cbSize to be set to sizeof(MENUITEMINFOW)—omitting this will cause API calls to fail silently.

内容的提问来源于stack exchange，提问作者Bradmage