从JPanel移除多个JComboBox时的界面更新异常问题

嘿，我仔细看了你的代码，立刻就找到问题根源了！你删除逻辑里犯了一个很典型的变量引用错误：你用来从面板移除组件的productLineBox，永远指向的是最后一次添加的那个JComboBox实例，和你从集合里移除的元素根本不是同一个。

为什么会这样？ #

看你添加组件的代码：

productLineBox = new JComboBox(productLineDefinedList);
projectLineComboBoxList.add(countAddClicks,productLineBox);

每次点击添加，你都会创建一个新的JComboBox，然后把全局变量productLineBox指向这个新对象。所以当你执行删除操作时，mainGridPanel.remove(productLineBox)只会删除这个最后创建的组件，不管你从集合里移除的是哪一个——这就导致集合里的元素删对了，但界面上永远只删最后一个。

怎么解决？ #

只需要修改删除监听器的逻辑：从集合里取出要删除的组件实例，再用这个实例去调用面板的remove方法，而不是依赖全局变量。另外还要加个空集合判断，防止点删除删到空的时候报错。

修改后的removeRow监听器代码：

removeRow.addActionListener(new ActionListener(){
    public void actionPerformed (ActionEvent event) {
        // 先判断集合不为空，避免索引越界异常
        if (projectLineComboBoxList.isEmpty()) {
            return;
        }
        countAddClicks--;
        System.out.println("After removal click is: " + countAddClicks);
        
        // 先从集合中取出要删除的组件
        JComboBox toRemove = projectLineComboBoxList.remove(projectLineComboBoxList.size()-1);
        // 用这个组件实例从面板中移除
        mainGridPanel.remove(toRemove);
        
        // 同步更新用户选项集合（同样要判断非空）
        if (!userOptionList.isEmpty()) {
            userOptionList.remove(userOptionList.size()-1);
        }
        
        mainGridPanel.revalidate();
        mainGridPanel.repaint();
    }
});

额外的优化小建议 #

1. 给泛型指定具体类型：把你的集合声明改成带具体类型的泛型，避免原始类型警告，类型更安全：

   private ArrayList<JComboBox<String>> projectLineComboBoxList;
   private ArrayList<String> userOptionList;
   

2. 去掉冗余的countAddClicks变量：这个变量其实完全可以用projectLineComboBoxList.size()来替代，比如添加后countAddClicks = projectLineComboBoxList.size()，删除时不需要手动维护，减少出错概率。
3. 添加组件时可以简化索引：projectLineComboBoxList.add(countAddClicks,productLineBox)可以直接写成projectLineComboBoxList.add(productLineBox)，因为你是按顺序添加，默认就是加到末尾，不需要指定索引。

修改后的完整代码 #

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.util.*;

public class TestingGround {
    Toolkit toolkit;
    JFrame frame;
    JPopupMenu menu;
    private ArrayList<JComboBox<String>> projectLineComboBoxList;
    private String[] productLineDefinedList = {"-","A","B","C" ,"D","E","F","G", "H", "I", "J","K","L", "M"};
    private ArrayList<String> userOptionList;
    private JComboBox<String> productLineBox;
    int countAddClicks;

    public TestingGround() {
        frame = new JFrame("Testing ground area");
        centerToScreen();
        menu = new JPopupMenu();
        JMenuItem addRow = new JMenuItem("Add ComboBox");
        JMenuItem removeRow = new JMenuItem("Remove ComboBox");
        JPanel panel = new JPanel();
        JPanel mainGridPanel = new JPanel();
        mainGridPanel.setLayout(new GridLayout(0,2));
        mainGridPanel.setBorder(BorderFactory.createLineBorder(Color.red));
        panel.add(mainGridPanel);
        userOptionList = new ArrayList<>();
        projectLineComboBoxList = new ArrayList<>();
        JButton button = new JButton("save state");
        productLineBox = new JComboBox<>(productLineDefinedList);
        countAddClicks =0;
        panel.add(button);

        // ACTION LISTENERS
        addRow.addActionListener(new ActionListener(){
            // Right click to add JComboBoxes to the screen
            public void actionPerformed(ActionEvent event) {
                System.out.println("Initial click is: " + countAddClicks);
                productLineBox = new JComboBox<>(productLineDefinedList);
                // add a new JComboBox
                projectLineComboBoxList.add(productLineBox);
                // add this JComboBox to the JComboBox Array List
                countAddClicks++;
                System.out.println("After click is: " + countAddClicks);
                mainGridPanel.add(productLineBox);
                mainGridPanel.repaint();
                mainGridPanel.revalidate();
            }
        });

        // Fixed remove logic!
        removeRow.addActionListener(new ActionListener(){
            public void actionPerformed (ActionEvent event) {
                if (projectLineComboBoxList.isEmpty()) {
                    return;
                }
                countAddClicks--;
                System.out.println("After removal click is: " + countAddClicks);
                
                JComboBox<String> toRemove = projectLineComboBoxList.remove(projectLineComboBoxList.size()-1);
                mainGridPanel.remove(toRemove);
                
                if (!userOptionList.isEmpty()) {
                    userOptionList.remove(userOptionList.size()-1);
                }
                
                mainGridPanel.revalidate();
                mainGridPanel.repaint();
            }
        });

        button.addActionListener (new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                userOptionList.clear();
                for (int i=0; i<projectLineComboBoxList.size(); i++) {
                    JComboBox<String> tempBoxxx = projectLineComboBoxList.get(i);
                    String tzz = tempBoxxx.getSelectedItem().toString();
                    userOptionList.add(tempBoxxx.getSelectedItem().toString());
                    // Add the text to the String Array List
                }
                System.out.println();
                System.out.println("The length of the JComboBox Array is: " + projectLineComboBoxList.size() );
                System.out.println("The content of the String array is: " + userOptionList );
                System.out.println("The size of the String array is: " + userOptionList.size());
                System.out.println();
            }
        });

        // Cand dau click din butonul cel mai din dreapta (3) se deschide menium popup
        frame.addMouseListener(new MouseAdapter() {
            public void mouseReleased(MouseEvent event) {
                if (event.getButton() == event.BUTTON3) {
                    menu.show(event.getComponent(), event.getX(),event.getY());
                }
            }
        });

        menu.add(addRow);
        menu.add(removeRow);
        frame.add(panel);
        frame.setVisible(true);
    }

    public void centerToScreen() {
        frame.setSize(700,600);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setTitle("A Popup Menu");
        toolkit = frame.getToolkit();
        Dimension size = toolkit.getScreenSize();
        frame.setLocation((size.width-frame.getWidth())/2, (size.height-frame.getHeight())/2);
    }

    public static void main(String[]args){
        new TestingGround();
    }
}

内容的提问来源于stack exchange，提问作者zypa