Symfony命令注入邮件与日期服务及执行错误排查

Hey there! Let's tackle this two-part problem step by step—first fixing that method signature warning, then making sure your ValidityEndHandler service is called correctly.

Step 1: Fix the Method Signature Compatibility Warning #

The warning is telling you your execute() method doesn’t match the exact signature required by Symfony’s base Command class. Here’s what you need to adjust:

• Access modifier: Must be protected (not public or private)
• Parameters: Exact type hints for InputInterface and OutputInterface (don’t forget to import these classes)
• Return type: Must return an int (Symfony 4.4+ requires this; use Command::SUCCESS or Command::FAILURE constants for clarity)

Example of the corrected execute() structure:

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ValidityReminderCommand extends Command
{
    // ... constructor and properties ...

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        // Your logic will go here

        return Command::SUCCESS; // Or Command::FAILURE if something breaks
    }
}

Step 2: Correctly Inject and Call the ValidityEndHandler Service #

To use your service in the command, you’ll inject it via the constructor (Symfony’s dependency injection system handles this automatically if your command is registered as a service, which it should be in most setups).

Update the Command’s Constructor #

First, inject the service and store it as a private property:

use App\Service\ValidityEndHandler;

class ValidityReminderCommand extends Command
{
    private $validityEndHandler;

    public function __construct(ValidityEndHandler $validityEndHandler)
    {
        $this->validityEndHandler = $validityEndHandler;
        parent::__construct(); // Don’t skip calling the parent constructor!
    }

    // ... corrected execute() method ...
}

Call the Service in execute() #

Assuming your ValidityEndHandler has a method like sendFourWeekExpiryReminders() to handle the email logic, call it inside execute():

protected function execute(InputInterface $input, OutputInterface $output): int
{
    $output->writeln('<info>Starting validity reminder process...</info>');

    try {
        // Call your service's method to send reminders
        $this->validityEndHandler->sendFourWeekExpiryReminders();
        
        $output->writeln('<success>Reminders sent to all admins!</success>');
        return Command::SUCCESS;
    } catch (\Exception $e) {
        $output->writeln('<error>Failed to send reminders: ' . $e->getMessage() . '</error>');
        return Command::FAILURE;
    }
}

Quick Check: Ensure Your Service is Registered #

In Symfony 5+, services in the App\Service namespace are auto-registered. If yours isn’t, explicitly define it in config/services.yaml:

services:
    App\Service\ValidityEndHandler:
        autowire: true
        autoconfigure: true

Full Corrected Command Class #

Here’s the complete ValidityReminderCommand with all fixes:

namespace App\Command;

use App\Service\ValidityEndHandler;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ValidityReminderCommand extends Command
{
    protected static $defaultName = 'app:send-validity-reminders';
    private $validityEndHandler;

    public function __construct(ValidityEndHandler $validityEndHandler)
    {
        $this->validityEndHandler = $validityEndHandler;
        parent::__construct();
    }

    protected function configure(): void
    {
        $this
            ->setDescription('Sends email reminders to admins 4 weeks before inventory items expire.')
            ->setHelp('This command checks inventory items nearing validity end and alerts all admins via email.');
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $output->writeln('<info>Initiating validity reminder process...</info>');

        try {
            $this->validityEndHandler->sendFourWeekExpiryReminders();
            $output->writeln('<success>All reminders sent successfully!</success>');
            return Command::SUCCESS;
        } catch (\Exception $e) {
            $output->writeln('<error>Failed to send reminders: ' . $e->getMessage() . '</error>');
            return Command::FAILURE;
        }
    }
}

Sample ValidityEndHandler Service (For Context) #

Here’s a basic example of what your service might look like, handling inventory checks and email sending:

namespace App\Service;

use App\Entity\InventoryItem;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\Mailer\MailerInterface;
use Symfony\Component\Mime\Email;

class ValidityEndHandler
{
    private $entityManager;
    private $mailer;
    private $adminEmails; // Replace with your admin email logic (e.g., fetch from User entity)

    public function __construct(EntityManagerInterface $entityManager, MailerInterface $mailer)
    {
        $this->entityManager = $entityManager;
        $this->mailer = $mailer;
        $this->adminEmails = ['admin1@yourdomain.com', 'admin2@yourdomain.com'];
    }

    public function sendFourWeekExpiryReminders(): void
    {
        // Calculate date 4 weeks from now
        $fourWeeksOut = new \DateTime('+4 weeks');

        // Fetch expiring inventory items
        $expiringItems = $this->entityManager->getRepository(InventoryItem::class)
            ->findItemsExpiringBefore($fourWeeksOut);

        if (empty($expiringItems)) return;

        // Build and send email
        $email = (new Email())
            ->from('no-reply@yourdomain.com')
            ->to(...$this->adminEmails)
            ->subject('Inventory Items Nearing Validity End')
            ->text($this->buildPlainTextReminder($expiringItems))
            ->html($this->buildHtmlReminder($expiringItems));

        $this->mailer->send($email);
    }

    private function buildPlainTextReminder(array $items): string
    {
        $text = 'The following inventory items will expire in 4 weeks or less:' . PHP_EOL . PHP_EOL;
        foreach ($items as $item) {
            $text .= "- {$item->getName()} (Valid until: {$item->getValidityEnd()->format('Y-m-d')})" . PHP_EOL;
        }
        return $text;
    }

    private function buildHtmlReminder(array $items): string
    {
        $html = '<p>The following inventory items will expire in 4 weeks or less:</p><ul>';
        foreach ($items as $item) {
            $html .= "<li>{$item->getName()} (Valid until: {$item->getValidityEnd()->format('Y-m-d')})</li>";
        }
        $html .= '</ul>';
        return $html;
    }
}

That should resolve both the method signature warning and ensure your service is called correctly. Just double-check that dependencies like Doctrine and Mailer are properly set up in your Symfony project!

内容的提问来源于stack exchange，提问作者J.Demand