Android自定义Toast类写法正确性及跨组件调用方法咨询

Hey there! Let's tackle your two questions step by step, with fixes and best practices for your custom Toast setup.

1. Is your ShowToast class implemented correctly? #

Short answer: Not quite — there are a few critical issues and improvements we can make:

Key Problems in Your Current Code: #

• Mismatched View IDs: You're trying to find a TextView with R.id.text, but your XML layout defines it as android:id="@+id/toast_text" — this will cause a NullPointerException when setting the text.
• Redundant & Incorrect Parent View: The viewParent parameter is unnecessary, and passing viewParent.findViewById(R.id.toast_root_error) to inflater.inflate() is wrong (your layout's root ID is toast_root, not toast_root_error). Custom Toasts don't need a parent view to inflate against.
• Background Overwrite: Calling view.setBackgroundColor(color) replaces the @drawable/background_toast you defined in XML. If that drawable has rounded corners or other styling, you'll lose all of it.
• Inefficient Object Creation: Using a constructor means you have to instantiate a new ShowToast every time you want to show a Toast — a static method is far more convenient.
• Potential Memory Leak: Using an Activity/Fragment Context directly can lead to memory leaks if the Toast outlives the component. Always use the Application Context for system components like Toasts.

Fixed ShowToast Class #

Here's an improved version that addresses all these issues:

import android.content.Context;
import android.graphics.PorterDuff;
import android.graphics.drawable.Drawable;
import android.view.LayoutInflater;
import android.view.View;
import android.widget.ImageView;
import android.widget.TextView;
import android.widget.Toast;
import android.view.Gravity;

public class ShowToast {
    // Static method for easy, one-line calls
    public static void show(Context context, int iconResId, String message, int backgroundColor) {
        // Use Application Context to avoid memory leaks
        Context appContext = context.getApplicationContext();
        LayoutInflater inflater = LayoutInflater.from(appContext);
        
        // Inflate the custom Toast layout (no parent needed)
        View toastView = inflater.inflate(R.layout.toast_delete_mealplan, null);

        // Set the icon
        ImageView iconView = toastView.findViewById(R.id.toast_image);
        iconView.setImageResource(iconResId);

        // Set the message text
        TextView messageView = toastView.findViewById(R.id.toast_text);
        messageView.setText(message);

        // Update background color without losing drawable styling (e.g., rounded corners)
        Drawable background = toastView.getBackground();
        if (background != null) {
            background.setColorFilter(backgroundColor, PorterDuff.Mode.SRC_IN);
        }

        // Configure and show the Toast
        Toast toast = new Toast(appContext);
        toast.setGravity(Gravity.CENTER_VERTICAL, 0, 0);
        toast.setDuration(Toast.LENGTH_LONG);
        toast.setView(toastView);
        toast.show();
    }
}

Quick Layout Adjustment #

Make sure your background_toast drawable is a shape (to keep rounded corners or custom styling). Example res/drawable/background_toast.xml:

<?xml version="1.0" encoding="utf-8"?>
<shape xmlns:android="http://schemas.android.com/apk/res/android"
    android:shape="rectangle">
    <corners android:radius="12dp"/> <!-- Rounded corners -->
    <solid android:color="#444444"/> <!-- Default dark background -->
    <padding android:horizontal="16dp" android:vertical="8dp"/> <!-- Internal spacing -->
</shape>

2. How to call ShowToast in Activity or Fragment? #

With the fixed static method, calling it is straightforward:

In an Activity: #

// Example: Show a success Toast with green background
ShowToast.show(
    this, // Activity context
    R.drawable.icon_success, // Your icon resource
    "Operation completed successfully!", // Message text
    getResources().getColor(R.color.toast_green) // Background color
);

In a Fragment: #

Always use requireContext() to get a valid Context (make sure the Fragment is attached to an Activity first, e.g., call this in onViewCreated() or later):

// Example: Show an error Toast with red background
ShowToast.show(
    requireContext(), // Fragment's attached context
    R.drawable.icon_error, // Your error icon
    "Oops, something went wrong!", // Error message
    getResources().getColor(R.color.toast_red) // Background color
);

If you wanted to use your original constructor (not recommended): #

If you prefer to keep the constructor approach (after fixing the ID/parent issues), you'd call it like this:

// In Activity
new ShowToast(this, this, R.drawable.icon_shopping_cart, "Added to Cart", getResources().getColor(R.color.blue));

// In Fragment (use getView() as viewParent)
new ShowToast(getView(), requireContext(), R.drawable.icon_shopping_cart, "Added to Cart", getResources().getColor(R.color.blue));

内容的提问来源于stack exchange，提问作者BVB09