Laravel中更新hasMany关联关系的最佳实践咨询

最优方案：使用Laravel多对多关联sync方法（推荐） #

你当前的场景本质是Project和User的多对多关联，不需要单独定义hasMany(ProjectMember::class)的关联，直接在模型中定义多对多关联即可：

// App/Models/Project.php
class Project extends Model
{
    use HasFactory;

    public function teamMembers()
    {
        // 第二个参数指定你自定义的中间表名，withTimestamps会自动维护中间表的时间字段
        return $this->belongsToMany(User::class, 'projects_members')->withTimestamps();
    }
}

之后更新项目成员的逻辑可以直接使用Laravel原生的sync方法，该方法会自动完成「删除未选中的关联、新增新增的关联、保留已有的关联」三个操作，完全符合你的需求，不需要手动删数据也不需要循环插入：

// 控制器代码
public function update(Request $request, $id)
{
    // 先做参数校验，避免非法数据入库
    $validated = $request->validate([
        'project_name' => 'required|string|max:255',
        'details' => 'nullable|string',
        'start_date' => 'required|date',
        'end_date' => 'required|date|after:start_date',
        'team_members' => 'array',
        'team_members.*' => 'exists:users,id'
    ]);

    $project = Project::findOrFail($id);
    $project->fill([
        'name' => $validated['project_name'],
        'details' => $validated['details'],
        'start_date' => $validated['start_date'],
        'end_date' => $validated['end_date'],
    ])->save();

    // 一行搞定成员关联更新
    $project->teamMembers()->sync($validated['team_members'] ?? []);
       
    return redirect('/projects');
}

备选方案：保留现有关联的优化方案 #

如果你不想调整现有hasMany关联定义，也可以把循环插入改为批量插入，减少SQL请求次数，提升性能：

public function update(Request $request, $id)
{
    $validated = $request->validate([
        'project_name' => 'required|string|max:255',
        'details' => 'nullable|string',
        'start_date' => 'required|date',
        'end_date' => 'required|date|after:start_date',
        'team_members' => 'array',
        'team_members.*' => 'exists:users,id'
    ]);

    $project = Project::findOrFail($id);
    $project->fill([
        'name' => $validated['project_name'],
        'details' => $validated['details'],
        'start_date' => $validated['start_date'],
        'end_date' => $validated['end_date'],
    ])->save();

    $members = $validated['team_members'] ?? [];
    ProjectMember::where('project_id', $id)->delete();
    
    // 批量构造数据插入，替代循环save
    $memberData = collect($members)->map(function ($memberId) use ($id) {
        return [
            'project_id' => $id,
            'user_id' => $memberId,
            'created_at' => now(),
            'updated_at' => now()
        ];
    })->toArray();
    ProjectMember::insert($memberData);
       
    return redirect('/projects');
}

内容的提问来源于stack exchange，提问作者Himanshu Rahi