C++基于switch case的控制台计算器写入结果到txt文件报错如何解决

• 重复声明问题：switch 语句的所有 case 分支默认共享同一个作用域，你在每个 case 中都定义同名的 ofstream MyFile 对象，属于同一作用域内重复定义变量，违反 C++ 语法规则。
• 跨初始化问题：ofstream 类存在自定义的构造函数，C++ 禁止通过 switch 的跳转逻辑跳过这类对象的初始化流程，当程序跳到其他 case 分支时会直接跳过第一个 case 中 MyFile 的构造步骤，因此编译器抛出错误。

只需要给每个 case 的执行代码包裹一对大括号，让每个 case 内的变量只在当前分支的局部作用域生效，即可解决两类报错：

#include <iostream>
#include <fstream>
using namespace std;

int main()
{
    char op;
    float num1, num2;

    cout << "Enter Operator: +, -, *, / : ";
    cin >> op;

    cout << "Enter two Operands: ";
    cin >> num1 >> num2;

    switch(op)
    {
        case '+':
        { // 加局部作用域大括号
            cout << num1 << " + " << num2 << " = " << num1 + num2;
            ofstream MyFile("filename.txt");
            MyFile << num1 << " + " << num2 << " = " << num1 + num2;
            MyFile.close();
            break;
        }
        case '-':
        {
            cout << num1 << " - " << num2 << " = " << num1 - num2;
            ofstream MyFile("filename.txt");
            MyFile << num1 << " - " << num2 << " = " << num1 - num2;
            MyFile.close();
            break;
        }
        case '*':
        {
            cout << num1 << " * " << num2 << " = " << num1 * num2;
            ofstream MyFile("filename.txt");
            MyFile << num1 << " * " << num2 << " = " << num1 * num2;
            MyFile.close();
            break;
        }
        case '/':
        {
            cout << num1 << " / " << num2 << " = " << num1 / num2;
            ofstream MyFile("filename.txt");
            MyFile << num1 << " / " << num2 << " = " << num1 / num2;
            MyFile.close();
            break;
        }
        default:
            cout << "Error! Operator is not correct";
            break;
    }
    return 0;
}

可以把文件操作逻辑提到 switch 外部，避免每个 case 重复写创建、写入、关闭文件的代码，同时天然规避作用域问题：

#include <iostream>
#include <fstream>
using namespace std;

int main()
{
    char op;
    float num1, num2, result;
    bool op_valid = false;

    cout << "Enter Operator: +, -, *, / : ";
    cin >> op;

    cout << "Enter two Operands: ";
    cin >> num1 >> num2;

    switch(op)
    {
        case '+':
            result = num1 + num2;
            cout << num1 << " + " << num2 << " = " << result;
            op_valid = true;
            break;
        case '-':
            result = num1 - num2;
            cout << num1 << " - " << num2 << " = " << result;
            op_valid = true;
            break;
        case '*':
            result = num1 * num2;
            cout << num1 << " * " << num2 << " = " << result;
            op_valid = true;
            break;
        case '/':
            result = num1 / num2;
            cout << num1 << " / " << num2 << " = " << result;
            op_valid = true;
            break;
        default:
            cout << "Error! Operator is not correct";
            break;
    }

    // 运算符合法时才写入文件
    if (op_valid) {
        ofstream MyFile("filename.txt");
        MyFile << num1 << " " << op << " " << num2 << " = " << result;
        MyFile.close();
    }

    return 0;
}

内容的提问来源于stack exchange，提问作者Retrax