R语言如何简化重复代码且避免封装函数参数过多

核心思路 #

将重复的「多结果保存+打印提示」逻辑抽为公共函数，通过可选的路径参数适配不同保存场景，进一步可结合函数式编程的闭包特性减少重复传参。

基础优化方案 #

步骤1：抽离公共保存函数 #

# 公共保存逻辑，仅需传入3组结果、对应文件名，父路径为可选参数
save_analysis_results <- function(father_res, father.out.file,
                                  mother_res, mother.out.file,
                                  res_sumary_ord, summary.out.file,
                                  parent_path = ".") {
  # 拼接完整输出路径
  father_full_path <- file.path(parent_path, father.out.file)
  mother_full_path <- file.path(parent_path, mother.out.file)
  summary_full_path <- file.path(parent_path, summary.out.file)
  
  # 执行保存+打印提示
  write_csvy(father_res, father_full_path)
  cat(father.out.file,'saved.         \n')
  write_csvy(mother_res, mother_full_path)
  cat(mother.out.file,'saved.         \n')
  fwrite(res_sumary_ord, summary_full_path, sep='\t')
  cat(summary.out.file,'saved.         \n')
}

注：原代码if分支内的前两行cat输出的文件名（child.out.file/parents.out.file）和else分支不一致，若为业务需求而非笔误，仅需在函数中增加两个对应的文件名参数即可，整体框架无需调整。

步骤2：改写原业务逻辑 #

if (all(auto.file.flag)) {
  save_dirs <- c(basename(father_vcf_file), basename(mother_vcf_file))
  for (save_dir in save_dirs) {
    loc <- file.path(save_dir, 'dual_analysis_results')
    dir.create(loc, recursive = TRUE)
    # 传入生成的子目录路径即可
    save_analysis_results(father_res, father.out.file,
                          mother_res, mother.out.file,
                          res_sumary_ord, summary.out.file,
                          parent_path = loc)
  }
} else {
  # 不传路径默认保存在当前工作目录
  save_analysis_results(father_res, father.out.file,
                        mother_res, mother.out.file,
                        res_sumary_ord, summary.out.file)
}

进阶函数式优化（可选） #

如果不想每次调用都重复传入固定的结果和文件名参数，可以用闭包提前绑定固定数据，后续调用仅需传入路径参数：

# 构造绑定了固定数据的保存函数生成器
make_result_saver <- function(father_res, father.out.file,
                              mother_res, mother.out.file,
                              res_sumary_ord, summary.out.file) {
  # 返回一个仅需传入路径参数的保存函数
  function(parent_path = ".") {
    father_full_path <- file.path(parent_path, father.out.file)
    mother_full_path <- file.path(parent_path, mother.out.file)
    summary_full_path <- file.path(parent_path, summary.out.file)
    
    write_csvy(father_res, father_full_path)
    cat(father.out.file,'saved.         \n')
    write_csvy(mother_res, mother_full_path)
    cat(mother.out.file,'saved.         \n')
    fwrite(res_sumary_ord, summary_full_path, sep='\t')
    cat(summary.out.file,'saved.         \n')
  }
}

# 提前绑定所有固定的结果和文件名，生成专属保存函数
res_saver <- make_result_saver(father_res, father.out.file,
                               mother_res, mother.out.file,
                               res_sumary_ord, summary.out.file)

# 后续业务逻辑调用更简洁
if (all(auto.file.flag)) {
  save_dirs <- c(basename(father_vcf_file), basename(mother_vcf_file))
  for (save_dir in save_dirs) {
    loc <- file.path(save_dir, 'dual_analysis_results')
    dir.create(loc, recursive = TRUE)
    res_saver(loc)
  }
} else {
  res_saver()
}

方案优势 #

• 完全消除重复代码，后续修改保存规则仅需调整一次函数
• 逻辑分层清晰，路径生成和保存逻辑完全解耦
• 闭包方案大幅减少重复传参，调用更简洁

内容的提问来源于stack exchange，提问作者asalimih