使用Python for循环实现质数查找的代码问题求助

Hey there! No need to apologize at all—learning is all about working through these kinds of kinks, and asking questions is the best way to grow. Let's walk through what's going wrong with your code and fix it together.

First, Let's Break Down the Issues in Your Code #

You hit on two key problems already, but let's clarify why they happen:

1. Initial version had no output: Exactly right—your primes list was empty, so the inner for p in primes loop never ran. No loop = no print statements triggered.
2. Modified version repeated prints: This is because your inner loop logic is backwards. Right now, every time n isn't divisible by a single prime in the list, you immediately add n to primes and print "is a prime". But you need to check if n is not divisible by any primes before declaring it prime. Adding n to the list mid-loop also messes up the iteration, since the list grows while you're looping over it.

Fixed Code with Explanations #

Here's a corrected version that works as intended, with comments to highlight the fixes:

# Initialize primes list with the first prime (2) since even numbers >2 can't be prime
primes = [2]
# Upper limit for checking primes
high_val = 15

# Loop through numbers starting from 3 up to (but not including) high_val
for n in range(3, high_val):
    # Assume the number is prime until proven otherwise
    is_prime = True
    
    # Check divisibility against existing primes
    for p in primes:
        # Optimization: If p squared is larger than n, we can stop checking
        # (Any factor of n larger than sqrt(n) would have a corresponding factor smaller than sqrt(n))
        if p * p > n:
            break
        # If n is divisible by p, it's not a prime
        if n % p == 0:
            is_prime = False
            break  # No need to check further primes
    
    # After checking all relevant primes, update the list and print result
    if is_prime:
        primes.append(n)
        print(f"{n} is a prime")
    else:
        print(f"{n} is not prime")

Key Fixes & Improvements #

• Boolean flag for primality: Instead of acting mid-loop, we use is_prime to track whether the number passes all divisibility checks. This ensures we only make one determination per number.
• Early exit from inner loop: Once we find a prime that divides n, we set is_prime to False and break out of the loop—no need to waste time checking more primes.
• Math optimization: We stop checking primes once p*p > n because of the factor pair rule (if n has a factor larger than its square root, the other factor is smaller than the square root, which we've already checked).
• Clean iteration: We only modify the primes list after finishing the inner loop, so the iteration over existing primes doesn't get disrupted.

A Quick Note on Your Comments #

Your original comments are totally fine! They clearly explain your thought process, which makes it easy to follow (and debug) your code. Keep adding them as you learn—they're a great habit.

内容的提问来源于stack exchange，提问作者Confused