Django开发投资存取功能时取款后投资收益余额未更新问题

余额更新失效是两个核心逻辑错误共同导致的：

• 模型层重写的save()方法没有区分「新建记录」和「更新现有记录」场景，无论什么操作触发save，都会强制用初始本金重算投资收益，直接覆盖你在视图中手动扣减的取款金额。这就是为什么控制台打印的扣减后的值是正确的，但落库后始终变回初始收益值——你手动改的值在执行save()时被重写逻辑冲掉了。
• 取款视图中ModelForm的用法错误：调用BasicWithdrawalForm时没有传入要操作的已有投资账户实例，表单默认会生成一个全新的Investment对象，而非修改你已存在的账户记录，本身操作的对象就不对。

1. 修正模型save方法逻辑 #

只在首次创建投资记录（也就是首次存款）时计算初始利息和收益，后续更新操作不再强制覆盖收益字段：

from django.db import models

class Investment(models.Model):
    basic_deposit_amount = models.IntegerField(default=0, null=True)
    basic_interest = models.IntegerField(default=0, null=True)
    basic_investment_return = models.IntegerField(default=0, null=True)
    basic_withdraw_amount = models.IntegerField(default=0, null=True, blank=True)
    basic_balance = models.IntegerField(default=0, null=True, blank=True)
    investment_id = models.CharField(max_length=10, null=True, blank=True)
    is_active = models.BooleanField(default=False)
    created_at = models.DateTimeField(auto_now=True, null=True)

    def save(self, *args, **kwargs):
        # 仅新建记录时计算初始收益，更新操作不覆盖已有收益值
        if not self.pk:
            self.basic_interest =  self.basic_deposit_amount * 365 * 0.02/2
            self.basic_investment_return = self.basic_deposit_amount + self.basic_interest
        super(Investment, self).save(*args, **kwargs)

2. 修正取款视图逻辑 #

先查询到要操作的已有投资账户，将实例传入表单，确保操作的是现有记录而非新建对象：

def create_withdrawal_view(request):
    if request.method == 'POST':
        # 先取出要取款的目标账户，示例取当前激活账户，实际可根据URL传入的investment_id查询
        target_investment = get_object_or_404(Investment, is_active=True)
        # 传入instance参数，告知表单是修改现有记录，而非新建
        basic_withdraw_form = BasicWithdrawalForm(request.POST, instance=target_investment)
        if basic_withdraw_form.is_valid():
            investment = basic_withdraw_form.save(commit=False)
            # 扣减取款金额
            investment.basic_investment_return -= investment.basic_withdraw_amount
            # 同步更新账户余额字段
            investment.basic_balance = investment.basic_investment_return
            investment.save()
            messages.success(request, f'取款{investment.basic_withdraw_amount}元操作成功')
            # 操作成功后记得重定向，避免表单重复提交
            return redirect('你的投资列表页路由名')
        else:
             messages.error(request, '取款操作失败，请检查输入后重试')
    else:
        basic_withdraw_form = BasicWithdrawalForm()
    context = {'basic_withdraw_form': basic_withdraw_form}
    return render(request, 'create-basic-withdrawal.html', context)

3. 修正存款视图的冗余计算逻辑 #

原存款视图中重复累加了一次本金，和save方法里的初始收益计算冲突，删掉冗余代码即可：

def create_investment_view(request):
    if request.method == 'POST':
        basic_investment_form = BasicInvestmentForm(request.POST)
    
        if basic_investment_form.is_valid():
            investment = basic_investment_form.save(commit=False)
            # 删掉原来重复加本金的代码，save方法已经处理了初始收益计算
            investment.is_active = True
            investment.save()
            messages.success(request, f'存入{investment.basic_deposit_amount}元的基础投资操作成功')
            return redirect('你的投资列表页路由名')
        else:
            messages.error(request, '投资创建失败，请检查输入后重试')
    else:
        basic_investment_form = BasicInvestmentForm()
        
    context = {'basic_investment_form': basic_investment_form}
    return render(request, 'create-basic-investment.html', context)

• 表单校验失败的分支不要用messages.success，应该用messages.error做错误提示，避免误导用户
• 所有写操作（存款、取款）执行成功后要做重定向，避免用户刷新页面导致表单重复提交
• 模型中定义的basic_balance字段之前一直没有赋值，取款/存款后可以同步更新该字段值，保证数据一致性

内容的提问来源于stack exchange，提问作者Thaddeaus Iorbee