Node.js中SonarQube提示"-deleteFlag"重复需定义常量如何解决

SonarQube触发的是重复字符串字面量规则，要求同一字符串重复出现多次时必须提取为常量，避免硬编码散落增加维护成本、减少拼写错误概率。你只需要把重复出现的-deleteFlag、#text两个固定属性名提取为只读常量，替换所有硬编码位置即可。

修改后的完整代码 #

// 提取重复出现的固定字符串为常量
const PROP_DELETE_FLAG = "-deleteFlag";
const PROP_TEXT = "#text";

export class CCGuid {
  [PROP_DELETE_FLAG]: string;
  [PROP_TEXT]: string;

  constructor(obj: any) {
    if (typeof obj === "string") {
      this[PROP_TEXT] = obj;
      this[PROP_DELETE_FLAG] = "N";
    } else {
      try {
        this[PROP_DELETE_FLAG] = obj[PROP_DELETE_FLAG];
      } catch {
        this[PROP_DELETE_FLAG] = undefined;
      }
      try {
        this[PROP_TEXT] = obj[PROP_TEXT];
      } catch {
        this[PROP_TEXT] = undefined;
      }
    }
  }
}

可选优化建议 #

• 原有代码用try/catch做属性读取容错没有必要，直接用可选链写法更简洁，还能减少不必要的性能开销：

const PROP_DELETE_FLAG = "-deleteFlag";
const PROP_TEXT = "#text";

export class CCGuid {
  [PROP_DELETE_FLAG]: string;
  [PROP_TEXT]: string;

  constructor(obj: any) {
    if (typeof obj === "string") {
      this[PROP_TEXT] = obj;
      this[PROP_DELETE_FLAG] = "N";
      return;
    }
    this[PROP_DELETE_FLAG] = obj?.[PROP_DELETE_FLAG];
    this[PROP_TEXT] = obj?.[PROP_TEXT];
  }
}

• 如果常量只在当前类使用，也可以把常量定义为类的静态只读属性，作用域更收敛：

export class CCGuid {
  static readonly PROP_DELETE_FLAG = "-deleteFlag";
  static readonly PROP_TEXT = "#text";

  [CCGuid.PROP_DELETE_FLAG]: string;
  [CCGuid.PROP_TEXT]: string;

  constructor(obj: any) {
    if (typeof obj === "string") {
      this[CCGuid.PROP_TEXT] = obj;
      this[CCGuid.PROP_DELETE_FLAG] = "N";
      return;
    }
    this[CCGuid.PROP_DELETE_FLAG] = obj?.[CCGuid.PROP_DELETE_FLAG];
    this[CCGuid.PROP_TEXT] = obj?.[CCGuid.PROP_TEXT];
  }
}

改完之后重新跑SonarQube扫描，重复字面量的报错就会消失。这种写法和原有硬编码的运行时逻辑完全一致，不会引入额外问题；同时后续如果属性名需要调整，只需要修改常量定义处的取值即可，不需要全局搜索替换所有硬编码位置，也能避免拼写错误导致的隐性bug。

内容的提问来源于stack exchange，提问作者sagar