如何优化WordPress查询代码，使其更简洁优雅？

Hey there! Great call wanting to clean up this code—there's a lot of repetitive logic we can streamline to make it easier to read and maintain. Here's a refined version with explanations of the key improvements:

Key Improvements Made: #

• Eliminated redundant query arguments: Pulled all shared parameters into a base $args array instead of defining three nearly identical arrays.
• Dynamic category targeting: Only modify the cat parameter based on the current post's category, keeping the rest of the query logic DRY (Don't Repeat Yourself).
• Reduced duplicate function calls: Stored reusable values (permalink, title attributes) in variables inside the loop to avoid redundant WordPress function calls.
• Separated styles from markup: Moved the inline text-align:center style out of the HTML (add this to your theme's CSS file instead for better practice).
• Added security sanitization: Used WordPress' escaping functions to prevent potential XSS vulnerabilities.
• Updated deprecated parameter: Swapped the old showposts with the modern posts_per_page (WordPress has recommended this for years).

Optimized Code: #

<?php
// Get current post ID once
$current_post_id = get_the_ID();

// Base query arguments (shared across all cases)
$args = [
    'orderby'        => 'rand',
    'posts_per_page' => 10,
    'post__not_in'   => [$current_post_id],
    'meta_query'     => [
        ['key' => 'expost', 'compare' => 'NOT EXISTS']
    ]
];

// Adjust category parameter based on current post's category
if (in_category(76)) {
    $args['cat'] = '76';
} elseif (in_category(34)) {
    $args['cat'] = '34';
} else {
    $args['cat'] = '-47,-56';
}

// Initialize and run the query
$news_query = new WP_Query($args);
?>

<ul class="list">
    <?php while ($news_query->have_posts()) : $news_query->the_post(); 
        // Store reusable values to avoid duplicate function calls
        $post_permalink = get_permalink();
        $post_title = get_the_title();
        $post_title_attr = the_title_attribute(['echo' => false]);
        $post_image = get_post_image();
    ?>
        <li>
            <a href="<?php echo esc_url($post_permalink); ?>" title="<?php echo esc_attr($post_title_attr); ?>">
                <img src="<?php echo esc_url($post_image); ?>" class="thumbnail" alt="<?php echo esc_attr($post_title_attr); ?>">
            </a><br>
            <a href="<?php echo esc_url($post_permalink); ?>" class="post-title" title="<?php echo esc_attr($post_title_attr); ?>">
                <?php echo esc_html($post_title); ?>
            </a>
        </li>
    <?php endwhile; 
    // Reset post data to avoid conflicts with main query
    wp_reset_postdata();
    ?>
</ul>

Quick Follow-Up Tips: #

• Add this CSS to your theme's stylesheet instead of using inline styles:

  .list {
      text-align: center;
  }
  

• The wp_reset_postdata() call ensures we don't mess up the main WordPress query after our custom loop—this is critical for avoiding weird bugs in other parts of your template.

内容的提问来源于stack exchange，提问作者UserUser-name