Bash用户管理脚本优化及参数错误提示问题求助

Hey there! Let’s walk through fixing up your user management script’s parameter validation gaps, plus cover some best practices to make it more robust and user-friendly.

The core problem here is that your script isn’t enforcing that -p and -s are only used alongside -a. Right now, if someone runs the script with -p without -a, it bails out silently because those options don’t make sense outside the "add user" context.

Here’s a revised parameter parsing approach that fixes this by separating main actions from their sub-options:

#!/bin/bash

# Initialize variables
action=""
username=""
password=""
default_shell="/bin/bash"
shell="$default_shell"

# Helper function for consistent help text
show_help() {
    cat << EOF
Usage: $0 [OPTIONS]
Manage Linux user accounts with add/delete functionality.

Options:
  -a USERNAME   Add a new user
    -p PASSWORD  Set initial password (optional; default: user must set on first login)
    -s SHELL     Set login shell (optional; default: $default_shell)
  -d USERNAME   Delete an existing user
  -h            Show this help message

Examples:
  $0 -a johndoe -p SecurePass123 -s /bin/zsh
  $0 -d johndoe
EOF
}

# First parse main action options (-a, -d, -h)
while getopts ":adh" opt; do
    case "$opt" in
        a)
            action="add"
            ;;
        d)
            action="delete"
            ;;
        h)
            show_help
            exit 0
            ;;
        \?)
            echo "Error: Invalid option -$OPTARG" >&2
            show_help >&2
            exit 1
            ;;
    esac
done

# Shift past the main options to process remaining args
shift $((OPTIND - 1))

# Handle actions and their specific sub-options
if [[ "$action" == "add" ]]; then
    # Now parse add-specific options (-p, -s)
    while getopts ":p:s:" opt; do
        case "$opt" in
            p)
                password="$OPTARG"
                ;;
            s)
                shell="$OPTARG"
                ;;
            \?)
                echo "Error: Invalid option for 'add' action: -$OPTARG" >&2
                show_help >&2
                exit 1
                ;;
            :)
                echo "Error: Option -$OPTARG requires an argument." >&2
                show_help >&2
                exit 1
                ;;
        esac
    done
    # Shift past add sub-options to get the username
    shift $((OPTIND - 1))
    username="$1"

    # Validate required username for add action
    if [[ -z "$username" ]]; then
        echo "Error: Username is required when using -a" >&2
        show_help >&2
        exit 1
    fi

    # Add user existence check
    if id "$username" >/dev/null 2>&1; then
        echo "Error: User $username already exists" >&2
        exit 1
    fi

    # Your existing useradd logic here (with password/shell handling)
    echo "Adding user $username with shell $shell..."
    useradd -s "$shell" "$username"
    # Secure password handling (avoid plaintext in command line)
    if [[ -n "$password" ]]; then
        echo "$username:$password" | chpasswd
        passwd -e "$username"  # Force password change on first login
    fi
elif [[ "$action" == "delete" ]]; then
    username="$1"
    if [[ -z "$username" ]]; then
        echo "Error: Username is required when using -d" >&2
        show_help >&2
        exit 1
    fi
    # Add user existence check
    if ! id "$username" >/dev/null 2>&1; then
        echo "Error: User $username does not exist" >&2
        exit 1
    fi
    # Your existing userdel logic here
    echo "Deleting user $username..."
    userdel -r "$username"
else
    # Catch-all for no action specified (or orphaned options like -p/-s)
    echo "Error: Please specify a valid action: -a (add), -d (delete), or -h (help)" >&2
    show_help >&2
    exit 1
fi

# Check for any unrecognized leftover arguments
if [[ $# -gt 0 ]]; then
    echo "Error: Unrecognized arguments: $*" >&2
    show_help >&2
    exit 1
fi

This approach first locks in the user’s intended action (add/delete/help), then only processes sub-options relevant to that action. If someone runs ./useradd.sh -p mypass, they’ll get a clear error asking them to specify a valid action, plus the help text to guide them.

Let’s address some common pitfalls in beginner Bash scripts that your current code might have:

• Silent failures: Always output clear error messages to stderr (using >&2) instead of letting the script exit without explanation.
• Unvalidated user input:
  • Check if a user exists before adding/deleting (using id "$username" >/dev/null 2>&1 to test existence)
  • Ensure required arguments (like username for -a/-d) are provided
• Unquoted variables: Wrap variables like $username in quotes ("$username") to avoid issues with special characters or spaces.
• Insecure password handling: Avoid passing passwords via command-line arguments (they show up in ps output). The example above uses chpasswd which is safer, plus forces a password reset on first login.
• Missing help text: The show_help function makes it easy to maintain consistent, detailed guidance for users.

• Add set -uo pipefail at the top of your script (right after the shebang) to catch undefined variables and pipe failures early. You can temporarily disable it with set +e if you need to run a command that intentionally returns a non-zero exit code (like checking if a user doesn’t exist).
• Test edge cases:
  • Running the script with no arguments
  • Trying to add an existing user
  • Trying to delete a non-existent user
  • Using -a without a username
  • Passing invalid shell paths to -s

内容的提问来源于stack exchange，提问作者Abhijith