为何两段Python player_input函数代码一段循环无法终止？

Great question! Let's break down exactly why your first function's loop runs forever, and how the second version fixes that critical logic issue.

First, let's recap both code snippets for clarity:

Non-Working Code #

def player_input():
    marker = ''
    while 'X' or 'O' not in marker:
        marker = input("Choose between 'X' or 'O': ")
        print ("Please choose between 'X' or 'O'")
    if marker == 'X':
        return ('X', 'O')
    else:
        return ('O', 'X')

Working Code #

def player_input():
    marker = ''
    while not (marker == 'X' or marker == 'O'):
        marker = input("Choose between 'X' or 'O': ")
        print ("Please choose between 'X' or 'O'")
    if marker == 'X':
        return ('X', 'O')
    else:
        return ('O', 'X')

The Core Problem: Faulty Boolean Logic in the Loop Condition #

The entire issue boils down to how Python evaluates the while loop condition in your non-working code. Let's unpack that line:

while 'X' or 'O' not in marker:

In Python, any non-empty string is treated as True in a boolean context. So 'X' by itself always evaluates to True. When using the or operator, Python uses "short-circuit evaluation"—if the first operand is True, it doesn't even check the second one.

This means your loop condition simplifies to while True—no matter what the user inputs (even 'X' or 'O'), the loop will never exit because the condition is always truthy.

How the Working Code Fixes This #

The second version uses a logically sound condition:

while not (marker == 'X' or marker == 'O'):

Here's the step-by-step breakdown:

1. First, Python checks if the input is valid: marker == 'X' or marker == 'O' returns True if the user entered a correct option.
2. The not inverts that result: if the input is valid, not turns it to False, so the loop stops. If the input is invalid, not turns it to True, so the loop keeps asking for input.

Optional Quick Improvement #

You might also notice both versions print the error message every time—even when the user enters a valid option. To fix that, you could move the print statement inside a conditional:

def player_input():
    marker = ''
    while not (marker == 'X' or marker == 'O'):
        marker = input("Choose between 'X' or 'O': ")
        if not (marker == 'X' or marker == 'O'):
            print ("Please choose between 'X' or 'O'")
    return ('X', 'O') if marker == 'X' else ('O', 'X')

Now the error message only shows when the user enters something invalid.

内容的提问来源于stack exchange，提问作者proton