R函数IF条件识别异常，求通用化条件判断修复方案

需要调整plot_1函数，使其能自动识别对应DataFrame名称并执行正确绘图逻辑，避免编写大量重复的if/else if分支。调用plot_1(section="C", subsample="dummy1")时出现如下警告，请求修复函数实现预期功能：

Warning message: In section == name && subsample == "dummy1" : 'length(x) = 4 > 1' in coercion to 'logical(1)'

模拟数据与原函数代码如下：

模拟数据 #

df1<-data.frame(A=c(1,2,2,3,4,5,1,1,2,3),
                B=c(4,4,2,3,4,2,1,5,2,2),
                C=c(3,3,3,3,4,2,5,1,2,3),
                D=c(1,2,5,5,5,4,5,5,2,3),
                E=c(1,4,2,3,4,2,5,1,2,3),
                dummy1=c("yes","yes","no","no","no","no","yes","no","yes","yes"),
                dummy2=c("high","low","low","low","high","high","high","low","low","high"))

df1[colnames(df1)] <- lapply(df1[colnames(df1)], factor)


vals <- colnames(df1)[1:5]
dummies <- colnames(df1)[-(1:5)]
step1 <- lapply(dummies, function(x) df1[, c(vals, x)])
step2 <- lapply(step1, function(x) split(x, x[, 6]))
names(step2) <- dummies
tbls <- unlist(step2, recursive=FALSE)
tbls<-lapply(tbls, function(x) x[(names(x) %in% names(df1[c(1:5)]))])

A<-lapply(tbls,"[", c(1,2))
B<-lapply(tbls,"[", c(3,4))
C<-lapply(tbls,"[", c(3,4))
list<-list(A,B,C)
names(list)<-c("A","B","C")

原函数 #

plot_1<-function (section, subsample) {
  data<-list[grep(section, names(list))]
  data<-data[[1]]
  name=as.character(names(data))
  
  if(section=="A" && subsample=="None"){plot_likert_general_section(df1[c(1:2)],"A")}
  
  else if (section==name && subsample=="dummy1"){plot_likert(data$dummy1.yes, title=paste("How do the",name,"topics rank?"));plot_likert(data$Ldummy1.no, title = paste("How do the",name,"topics rank?"))}
}

警告原因 #

name是长度为4的向量（names(data)返回tbls的4个元素名称：dummy1.yes、dummy1.no、dummy2.high、dummy2.low），section == name会生成长度为4的逻辑向量，而&&仅支持长度为1的逻辑值，因此触发警告。

修复后的函数 #

plot_1 <- function(section, subsample) {
  # 直接获取对应section的数据列表
  target_data <- list[[section]]
  
  if (subsample == "None") {
    # 处理无分组的情况，可根据实际需求扩展其他section逻辑
    if (section == "A") {
      plot_likert_general_section(df1[c(1:2)], section)
    } else if (section %in% c("B", "C")) {
      plot_likert_general_section(df1[c(3:4)], section)
    }
  } else {
    # 动态筛选当前subsample对应的子数据集
    subsample_data <- target_data[grep(subsample, names(target_data))]
    
    # 遍历子数据集自动绘图，动态生成标题
    lapply(subsample_data, function(data) {
      plot_likert(data, title = paste("How do the", section, "topics rank?"))
    })
  }
}

核心改进点 #

• 用list[[section]]直接定位目标数据，简化冗余的grep操作
• 按subsample分支处理逻辑，通过grep(subsample, names(target_data))动态匹配分组数据，无需硬编码具体列名
• 用lapply遍历子数据集自动绘图，避免重复编写绘图代码
• 动态生成标题，自动带入section参数，无需手动指定

调用示例 #

# 无分组绘图
plot_1(section="A", subsample="None")

# 按dummy1分组绘图
plot_1(section="C", subsample="dummy1")

# 按dummy2分组绘图
plot_1(section="B", subsample="dummy2")

内容的提问来源于stack exchange，提问作者maplesyrup123