WPF中RelayCommand获取TextBox内容返回null及格式异常问题

问题场景 #

通过RelayCommand调用命令获取TextBox文本时始终返回null；后续尝试用CommandParameter="{Binding ElementName=ChatTextBox}"传递控件，返回结果附带控件标识（如输入"test"返回System.Windows.Controls.TextBox: test），直接转换字符串无效。

相关代码 #

ViewModel代码 #

namespace DoctorApplication.MVVM.ViewModel
{
    internal class DataViewModel : ObservableObject
    {
        private string message;

        public string Message
        {
            get { return message; }
            set 
            { 
                message = value;
                OnPropertyChanged();
            }
        }

        public RelayCommand SendCommand { get; set; }  

        public BindableCollection<UserDataModel> users { get; set; }
        public ObservableCollection<MessageModel> messages { get; set; }

        public RelayCommand MessageCommand { get; set; }
        public RelayCommand ConsoleLogcommand { get; set; }
        
        private UserDataModel selectedUser;

        public UserDataModel SelectedUser
        {
            get { return selectedUser; }
            set
            {
                selectedUser = value;
                OnPropertyChanged();
            }
        }

        public DataViewModel()
        {
            users = new BindableCollection<UserDataModel>();

            UserDataModel test1 = new UserDataModel("user1", "0612345678", 12345, 20, 80);
            UserDataModel test2 = new UserDataModel("user2", "0698765432", 67890, 30, 70);
            test1.AddMessage("Hello");
            test1.AddMessage("I'm a console!");
            test1.AddMessage("Goodbye!");
            test2.AddMessage("Hi!");
            test2.AddMessage("What's up?");
            users.Add(test1);
            users.Add(test2);

            MessageCommand = new RelayCommand(DisplayInMessageBox);
            SendCommand = new RelayCommand(DisplayInMessageBox);
        }
      
        public void DisplayInMessageBox(object message)
        {
            Console.WriteLine(message);
        }
    }
}

XAML代码 #

<Grid Grid.Row="2" DockPanel.Dock="Bottom" Name="ChatTextBoxPanel">
    <Grid.ColumnDefinitions>
        <ColumnDefinition Width="8*" />
        <ColumnDefinition Width="2*" />
    </Grid.ColumnDefinitions>
    <TextBox
        Grid.Column="0"
        Text="{Binding Message, Mode=OneWayToSource, UpdateSourceTrigger=PropertyChanged}"
        >
        <TextBox.DataContext>
            <m:DataViewModel/>
        </TextBox.DataContext>
    </TextBox>
    <Button
        Command="{Binding SendCommand}"
        Background="#FF1B47F5"
        BorderBrush="#FF1B1B1B"
        Content="➤"
        Foreground="#FFFFF7F7"
        Grid.Column="1"
        >
        <Button.DataContext>
            <m:DataViewModel/>
        </Button.DataContext>
    </Button>
</Grid>

RelayCommand实现代码 #

using System;
using System.Windows.Input;

namespace DoctorApplication.Core
{
    internal class RelayCommand : ICommand
    {
        readonly Action<object> execute;
        readonly Predicate<object> canExecute;

        public RelayCommand(Action<object> execute, Predicate<object> canExecute)
        {
            if (execute == null)
            {
                throw new NullReferenceException("execute");
            }

            this.execute = execute;
            this.canExecute = canExecute;
        }

        public RelayCommand(Action<object> execute) : this(execute, null)
        {
        }

        public event EventHandler CanExecuteChanged
        {
            add { CommandManager.RequerySuggested += value; }
            remove { CommandManager.RequerySuggested -= value; }
        }

        public bool CanExecute(object parameter)
        {
            return canExecute == null ? true : canExecute(parameter);
        }

        public void Execute(object parameter)
        {
            execute.Invoke(parameter);
        }
    }
}

核心问题分析 #

1. DataContext实例不共享：TextBox和Button各自创建了独立的DataViewModel实例，导致TextBox绑定的Message与Button命令访问的Message不属于同一个对象，命令触发时读取的是新实例的null值。
2. CommandParameter用法错误：直接传递TextBox控件对象，其ToString()返回的是控件默认字符串表示，而非文本内容。

解决步骤 #

步骤1：统一DataContext #

将DataViewModel实例提升到父容器（Grid）的DataContext，避免控件重复创建实例：

<Grid Grid.Row="2" DockPanel.Dock="Bottom" Name="ChatTextBoxPanel">
    <Grid.DataContext>
        <m:DataViewModel/>
    </Grid.DataContext>
    <Grid.ColumnDefinitions>
        <ColumnDefinition Width="8*" />
        <ColumnDefinition Width="2*" />
    </Grid.ColumnDefinitions>
    <TextBox
        Grid.Column="0"
        x:Name="ChatTextBox"
        Text="{Binding Message, UpdateSourceTrigger=PropertyChanged}"
        />
    <Button
        Command="{Binding SendCommand}"
        Background="#FF1B47F5"
        BorderBrush="#FF1B1B1B"
        Content="➤"
        Foreground="#FFFFF7F7"
        Grid.Column="1"
        />
</Grid>

• 移除TextBox和Button内部的DataContext定义，统一设置在父Grid上
• 绑定模式默认是TwoWay，可省略；保留UpdateSourceTrigger=PropertyChanged确保文本实时同步

步骤2：优化命令逻辑 #

直接读取ViewModel中已绑定的Message属性，无需传递参数：

public DataViewModel()
{
    // ... 其他初始化代码
    SendCommand = new RelayCommand(_ => DisplayMessage());
}

public void DisplayMessage()
{
    Console.WriteLine(Message);
}

可选：通过CommandParameter传递文本（不推荐，违背MVVM） #

若需用参数传递文本，直接绑定TextBox的Text属性：

<Button
    Command="{Binding SendCommand}"
    CommandParameter="{Binding ElementName=ChatTextBox, Path=Text}"
    <!-- 其他属性 -->
    />

命令方法接收字符串参数：

public void DisplayInMessageBox(object parameter)
{
    string text = parameter as string;
    Console.WriteLine(text);
}

优化建议 #

• 遵循MVVM原则：尽量通过数据绑定同步View与ViewModel状态，避免命令中直接操作UI控件
• 统一DataContext管理：推荐在窗口/UserControl根元素设置DataContext，或通过依赖注入注入ViewModel实例，避免控件级重复创建
• 泛型RelayCommand：实现类型安全的泛型版本，避免参数强制转换：

internal class RelayCommand<T> : ICommand
{
    readonly Action<T> execute;
    readonly Predicate<T> canExecute;

    public RelayCommand(Action<T> execute, Predicate<T> canExecute)
    {
        execute ?? throw new ArgumentNullException(nameof(execute));
        this.execute = execute;
        this.canExecute = canExecute;
    }

    public RelayCommand(Action<T> execute) : this(execute, null) { }

    public event EventHandler CanExecuteChanged
    {
        add => CommandManager.RequerySuggested += value;
        remove => CommandManager.RequerySuggested -= value;
    }

    public bool CanExecute(object parameter) => canExecute?.Invoke((T)parameter) ?? true;

    public void Execute(object parameter) => execute((T)parameter);
}

使用示例：

public RelayCommand<string> SendCommand { get; set; }

// 初始化
SendCommand = new RelayCommand<string>(text => Console.WriteLine(text));

内容的提问来源于stack exchange，提问作者oknorton