C#窗体与普通类交互遇空引用异常，如何实现低耦合并修复？

一、先解决空引用异常 #

异常原因 #

在MMCMLibrary_home的构造函数中，你先调用了TimeFrame.Colors()，但此时lbl1_1等控件变量还未完成赋值（仍为null），当Colors()方法尝试访问MMCMLibrary_home.instance.lbl1_1.BackColor时，自然触发空引用异常。

修复步骤 #

调整构造函数内的代码顺序，将TimeFrame.Colors()移到所有控件变量赋值完成之后：

public MMCMLibrary_home()
{
    InitializeComponent();
    instance = this;

    // 先完成所有控件变量的赋值
    // DCR1
    lbl1_1 = lblDCR1_9;
    lbl1_2 = lblDCR1_11;
    lbl1_3 = lblDCR1_1;
    lbl1_4 = lblDCR1_3;

    // DCR2
    lbl2_1 = lblDCR2_9;
    lbl2_2 = lblDCR2_11;
    lbl2_3 = lblDCR2_1;
    lbl2_4 = lblDCR2_3;

    // DCR3
    lbl3_1 = lblDCR3_9;
    lbl3_2 = lblDCR3_11;
    lbl3_3 = lblDCR3_1;
    lbl3_4 = lblDCR3_3;

    // DCR4
    lbl4_1 = lblDCR4_9;
    lbl4_2 = lblDCR4_11;
    lbl4_3 = lblDCR4_1;
    lbl4_4 = lblDCR4_3;

    // 再调用颜色设置方法
    TimeFrame.Colors();
}

二、低耦合优化方案 #

当前代码通过静态全局实例直接操作窗体控件，耦合度极高，后续维护和扩展成本大。以下是两种优化思路：

方案1：分离逻辑与UI，让数据驱动UI #

核心思路是让TimeFrame_Colors只负责计算颜色规则，返回配置数据，由窗体自行处理控件更新。

1. 重构TimeFrame_Colors类
   移除不必要的Form继承，去掉对窗体的直接依赖，改为返回颜色配置字典：

   internal class TimeFrame_Colors
   {
       private readonly ReadandWrite _read;
   
       // 通过构造注入依赖，避免内部直接实例化
       public TimeFrame_Colors(ReadandWrite readInstance)
       {
           _read = readInstance;
       }
   
       // 返回颜色配置，键为控件标识，值为对应颜色
       public Dictionary<string, System.Drawing.Color> GetColorConfigs()
       {
           var colorConfigs = new Dictionary<string, System.Drawing.Color>();
   
           // 处理DCR1_9的颜色规则
           if (_read.readExcel(1, 1) == "0" || _read.readExcel(2, 2) == "1")
           {
               colorConfigs["lbl1_1"] = System.Drawing.Color.Red;
           }
           // 其他控件的颜色规则可在此扩展
   
           return colorConfigs;
       }
   }
   

2. 修改窗体类
   移除静态全局实例，自行调用配置方法并更新控件：

   public partial class MMCMLibrary_home : Form
   {
       // 控件变量改为私有，无需对外暴露
       private Label lbl1_1, lbl1_2, lbl1_3, lbl1_4;
       private Label lbl2_1, lbl2_2, lbl2_3, lbl2_4;
       private Label lbl3_1, lbl3_2, lbl3_3, lbl3_4;
       private Label lbl4_1, lbl4_2, lbl4_3, lbl4_4;
   
       private readonly ReadandWrite _read;
       private readonly TimeFrame_Colors _timeFrame;
   
       public MMCMLibrary_home()
       {
           InitializeComponent();
   
           _read = new ReadandWrite();
           _timeFrame = new TimeFrame_Colors(_read);
   
           // 控件赋值
           lbl1_1 = lblDCR1_9;
           lbl1_2 = lblDCR1_11;
           lbl1_3 = lblDCR1_1;
           lbl1_4 = lblDCR1_3;
   
           lbl2_1 = lblDCR2_9;
           lbl2_2 = lblDCR2_11;
           lbl2_3 = lblDCR2_1;
           lbl2_4 = lblDCR2_3;
   
           lbl3_1 = lblDCR3_9;
           lbl3_2 = lblDCR3_11;
           lbl3_3 = lblDCR3_1;
           lbl3_4 = lblDCR3_3;
   
           lbl4_1 = lblDCR4_9;
           lbl4_2 = lblDCR4_11;
           lbl4_3 = lblDCR4_1;
           lbl4_4 = lblDCR4_3;
   
           // 应用颜色配置
           ApplyColorConfigs();
       }
   
       private void ApplyColorConfigs()
       {
           var colorConfigs = _timeFrame.GetColorConfigs();
           if (colorConfigs.TryGetValue("lbl1_1", out var color))
           {
               lbl1_1.BackColor = color;
           }
           // 其他控件同理处理
       }
   }
   

方案2：使用接口抽象，实现依赖反转 #

如果需要更高的扩展性，可以通过定义接口来抽象颜色配置逻辑，让窗体依赖接口而非具体实现。

1. 定义接口

   public interface IColorConfigProvider
   {
       Dictionary<string, System.Drawing.Color> GetColorConfigs();
   }
   

2. 让TimeFrame_Colors实现接口

   internal class TimeFrame_Colors : IColorConfigProvider
   {
       private readonly ReadandWrite _read;
   
       public TimeFrame_Colors(ReadandWrite readInstance)
       {
           _read = readInstance;
       }
   
       public Dictionary<string, System.Drawing.Color> GetColorConfigs()
       {
           var colorConfigs = new Dictionary<string, System.Drawing.Color>();
           if (_read.readExcel(1, 1) == "0" || _read.readExcel(2, 2) == "1")
           {
               colorConfigs["lbl1_1"] = System.Drawing.Color.Red;
           }
           return colorConfigs;
       }
   }
   

3. 窗体依赖接口

   public partial class MMCMLibrary_home : Form
   {
       private readonly IColorConfigProvider _colorProvider;
       private Label lbl1_1; // 其他控件省略
   
       // 构造注入接口，实现依赖反转
       public MMCMLibrary_home(IColorConfigProvider colorProvider)
       {
           InitializeComponent();
           _colorProvider = colorProvider;
   
           // 控件赋值...
   
           ApplyColorConfigs();
       }
   
       // 保留无参构造，兼容设计器
       public MMCMLibrary_home() : this(new TimeFrame_Colors(new ReadandWrite()))
       {
       }
   
       private void ApplyColorConfigs()
       {
           var colorConfigs = _colorProvider.GetColorConfigs();
           if (colorConfigs.TryGetValue("lbl1_1", out var color))
           {
               lbl1_1.BackColor = color;
           }
       }
   }
   

额外注意事项 #

• 移除TimeFrame_Colors类的Form继承，它本质是业务逻辑类，不需要继承窗体。
• 避免使用静态全局实例（如MMCMLibrary_home.instance），这种方式会导致代码耦合度高、难以测试。
• 依赖注入是降低耦合的核心手段，通过注入依赖而非内部实例化，能让代码更灵活、易维护。

内容的提问来源于stack exchange，提问作者Javanese Python