Rails中Order模型subtotal方法的RSpec测试逻辑求助

用户实现了关联的Order和OrderItem模型，其中Order的subtotal方法会遍历关联的订单项，计算有效项的总价之和，并通过回调保存到数据库。但编写RSpec测试时，原代码直接调用类方法Order.subtotal，且未建立正确的数据关联，导致测试报错。

原模型代码 #

Order模型 #

class Order < ApplicationRecord
    has_many :order_items
    belongs_to :user

    before_save :set_subtotal

    def subtotal
      order_items.collect { |order_item| order_item.valid? ? order_item.unit_price * order_item.quantity : 0 }.sum
    end
  
    private
  
    def set_subtotal
      self[:subtotal] = subtotal
    end
end

OrderItem模型 #

class OrderItem < ApplicationRecord
  belongs_to :product
  belongs_to :order
  
  before_save :set_unit_price
  before_save :set_total
  
  def unit_price
    if persisted? 
      self[:unit_price]
    else
      product.price
    end
  end

  def total
   return unit_price * quantity
  end

  private

  def set_unit_price
    self[:unit_price] = unit_price
  end

  def set_total
    self[:total] = total * quantity
  end
end

原测试代码（报错） #

# frozen_string_literal: true

require 'rails_helper'
RSpec.describe Order, type: :model do
  let(:user) { FactoryBot.create(:user) }
  let(:subtotal) { FactoryBot.create(:order, subtotal: 1000) }
  let(:items) { FactoryBot.create(:order_item)  }

  describe 'callbacks' do
    it { is_expected.to callback(:set_subtotal).before(:save) }
  end

  describe 'associations' do
    it { is_expected.to belong_to(:user) }
    it { is_expected.to have_many(:order_items) }
  end

  # 报错的测试代码
  # describe 'subtotal' do
  #   it 'it should calculate the subtotal' do
  #     expect(Order.subtotal).to eq(1000)
  #   end
  # end
end

1. 方法调用错误：subtotal是Order的实例方法，不能通过类Order直接调用，必须用具体的Order实例调用
2. 数据关联缺失：原测试未建立Order与OrderItem、Product的关联，导致计算时没有有效订单项
3. 场景覆盖不全：未考虑无效订单项、无订单项等边界情况

# frozen_string_literal: true

require 'rails_helper'
RSpec.describe Order, type: :model do
  let(:user) { FactoryBot.create(:user) }
  let(:product_1) { FactoryBot.create(:product, price: 100) }
  let(:product_2) { FactoryBot.create(:product, price: 200) }
  let(:order) { FactoryBot.create(:order, user: user) }
  let(:valid_item_1) { FactoryBot.create(:order_item, order: order, product: product_1, quantity: 2) }
  let(:valid_item_2) { FactoryBot.create(:order_item, order: order, product: product_2, quantity: 3) }
  let(:invalid_item) { FactoryBot.create(:order_item, order: order, product: nil, quantity: 5) }

  describe 'callbacks' do
    it { is_expected.to callback(:set_subtotal).before(:save) }
  end

  describe 'associations' do
    it { is_expected.to belong_to(:user) }
    it { is_expected.to have_many(:order_items) }
  end

  describe '#subtotal' do
    context 'with valid order items' do
      before do
        valid_item_1
        valid_item_2
        order.reload
      end

      it 'calculates correct total of valid items' do
        expect(order.subtotal).to eq(100*2 + 200*3) # 800
      end

      it 'persists the calculated subtotal on save' do
        order.save
        expect(order.reload.subtotal).to eq(800)
      end
    end

    context 'with invalid order items' do
      before do
        valid_item_1
        invalid_item
        order.reload
      end

      it 'ignores invalid items in calculation' do
        expect(order.subtotal).to eq(100*2) # 200
      end
    end

    context 'with no order items' do
      it 'returns 0' do
        expect(order.subtotal).to eq(0)
      end
    end
  end
end

• 确保FactoryBot工厂定义正确：Product需包含price字段，OrderItem需支持关联order、product及quantity字段
• 测试覆盖了核心场景：正常计算、无效项处理、空订单处理，确保subtotal方法逻辑健壮

内容的提问来源于stack exchange，提问作者Rabab Zahra