C语言JPEG恢复代码中BYTE定义引发编译错误，求解决办法

The error you're hitting stems from how you've defined your BYTE type: using int8_t (a signed 8-bit integer, equivalent to signed char). Signed 8-bit values only range from -128 to 127, so comparing one to 0xff (255 in decimal) will always be false—the compiler flags this as a tautological (meaningless) comparison when -Werror is enabled.

Solution: Switch to an Unsigned Byte Type #

To fix this, you need a byte type that can hold values from 0 to 255 (matching the raw binary data of JPEG files). You have two simple, standard options:

1. Use uint8_t (from <stdint.h>, which you're already relying on for int8_t)
2. Use unsigned char (the standard C type for unsigned byte data)

Here's the corrected code, with the key fix and a few minor robustness improvements:

#include <stdio.h>
#include <stdint.h>
#include <stdbool.h>

// Changed from int8_t to uint8_t (unsigned 8-bit integer)
typedef uint8_t BYTE; 
#define BLOCK_SIZE 512 
#define file_name_size 8 

bool new_jpeg(BYTE buffer[]); 

int main(int argc, char *argv[]) { 
    if (argc != 2) { 
        printf("Usage: ./recover [input_file]\n"); 
        return 1; 
    } 
    FILE* infile = fopen(argv[1], "r"); 
    if (infile == NULL) { 
        printf("Could not open input file.\n"); 
        return 1; 
    } 
    BYTE buffer[BLOCK_SIZE]; 
    int file_index = 0; 
    bool found_first_jpeg = false; // Fixed typo: foud → found
    FILE* outfile = NULL; // Initialize to avoid invalid pointer issues

    while (fread(buffer, BLOCK_SIZE, 1, infile)) { 
        if(new_jpeg(buffer)) { 
            if(!found_first_jpeg) 
                found_first_jpeg = true; 
            else 
                fclose(outfile); 

            char filename[file_name_size]; 
            sprintf(filename, "%03i.jpg", file_index++); 
            outfile = fopen(filename, "w"); 
            if(outfile == NULL) {
                printf("Failed to create output file: %s\n", filename);
                return 1; 
            }
            fwrite(buffer, BLOCK_SIZE, 1, outfile); 
        } 
        else if (found_first_jpeg) { 
            fwrite(buffer, BLOCK_SIZE, 1, outfile); 
        } 
    } 

    // Only close outfile if it was actually opened
    if(outfile != NULL)
        fclose(outfile); 
    fclose(infile); 
    return 0; // Explicit return for main (good practice)
} 

bool new_jpeg(BYTE buffer[]) { 
    return buffer[0] == 0xff && buffer[1] == 0xd8 && buffer[2] == 0xff && (buffer[3] & 0xf0) == 0xe0; 
}

Quick Extras: #

• Fixed a small typo (foud_first_jpeg → found_first_jpeg) that could have caused logic issues.
• Added an explicit return 0; in main and improved error messages for clarity.
• Initialized outfile to NULL and added a check before closing it, preventing a crash if no JPEGs were found in the input.

内容的提问来源于stack exchange，提问作者Philippe Haumesser