如何解决代码中的CastError(ObjectId转换失败)问题？

我已经实现了一个错误处理器，用来处理状态码错误并展示对应提示信息，但现在遇到了一个CastError，手动定义的错误能正常处理，但这种Mongoose抛出的类型转换错误无法被正确捕获。

错误日志 #

const castError = new CastError();
                    ^

CastError: Cast to ObjectId failed for value "636e6099887452407c7551e" (type string) at path "_id" for model "Product"
    at model.Query.exec (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\query.js:4891:21)
    at model.Query.Query.then (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\query.js:4990:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  messageFormat: undefined,
  stringValue: '"636e6099887452407c7551e"',
  kind: 'ObjectId',
  value: '636e6099887452407c7551e',
  path: '_id',
  reason: BSONTypeError: Argument passed in must be a string of 12 bytes or a string of 24 hex characters or an integer
      at new BSONTypeError (D:\Abdullah's Data\Ecommerce Project\node_modules\bson\lib\error.js:41:28)
      at new ObjectId (D:\Abdullah's Data\Ecommerce Project\node_modules\bson\lib\objectid.js:67:23)
      at castObjectId (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\cast\objectid.js:25:12)
      at ObjectId.cast (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\schema\objectid.js:246:12)
      at ObjectId.SchemaType.applySetters (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\schematype.js:1201:12)
      at ObjectId.SchemaType._castForQuery (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\schematype.js:1648:15)
      at ObjectId.SchemaType.castForQuery (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\schematype.js:1636:15)
      at ObjectId.SchemaType.castForQueryWrapper (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\schematype.js:1612:20)
      at cast (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\cast.js:342:32)
      at model.Query.Query.cast (D:\Abdullah's Data\Ecommerce Project\node_modules\mongoose\lib\query.js:5319:12),
  valueType: 'string'
}

当前代码文件 #

错误中间件（error.js） #

const ErrorHandler = require("../utils/errorhandler");

module.exports = (err, req, res, next) => {
    err.statusCode = err.statusCode || "500";
    err.message = err.message || "Internal Server Error";

    res.status(err.statusCode).json({
        success: false,
        message: err.message
    })
}

自定义错误类（errorhandler.js） #

class ErrorHandler extends Error{
    constructor(message, statusCode){
        super(message);
        this.statusCode = statusCode;

        Error.captureStackTrace(this, this.constructor);
    }
}

module.exports = ErrorHandler;

产品控制器（productController.js） #

exports.getProductDetails = async (req, res, next)=>{
    const product = await Product.findById(req.params.id);

    if(!product){
        return next(new ErrorHandler("Product not Found", 404));
    }

    res.status(200).json({
        success: true,
        product
    })
}

问题原因 #

1. 你当前的错误处理器只处理了手动抛出的ErrorHandler实例，Mongoose抛出的CastError属于另一种错误类型，未被匹配处理。
2. err.statusCode被设置为字符串"500"，但res.status()要求传入数字类型，会导致后续响应出错。
3. 异步函数中的错误未被捕获，无法传递到错误中间件。

修复方案 #

1. 修改错误中间件，添加CastError处理 #

const ErrorHandler = require("../utils/errorhandler");
const mongoose = require('mongoose');

module.exports = (err, req, res, next) => {
    // 修正状态码为数字类型
    err.statusCode = err.statusCode || 500;
    err.message = err.message || "Internal Server Error";

    // 专门处理Mongoose的ObjectId格式错误
    if (err instanceof mongoose.Error.CastError) {
        const message = `无效的${err.path}: ${err.value}，请检查参数格式`;
        err = new ErrorHandler(message, 400);
    }

    res.status(err.statusCode).json({
        success: false,
        message: err.message
    })
}

2. 捕获控制器中的异步错误 #

给async函数添加try/catch，确保Mongoose抛出的错误能传递到中间件：

exports.getProductDetails = async (req, res, next)=>{
    try {
        const product = await Product.findById(req.params.id);

        if(!product){
            return next(new ErrorHandler("未找到该产品", 404));
        }

        res.status(200).json({
            success: true,
            product
        })
    } catch (error) {
        // 将错误传给错误中间件处理
        next(error);
    }
}

额外优化（可选） #

如果不想每个async函数都写try/catch，可以使用express-async-handler包，它会自动捕获异步错误并传递给next：

npm install express-async-handler

修改控制器代码：

const asyncHandler = require('express-async-handler');

exports.getProductDetails = asyncHandler(async (req, res, next)=>{
    const product = await Product.findById(req.params.id);

    if(!product){
        return next(new ErrorHandler("未找到该产品", 404));
    }

    res.status(200).json({
        success: true,
        product
    })
})

内容的提问来源于stack exchange，提问作者Abdullah