Rails重构含重定向的if代码块：提升assert_jwe_token可读性

问题根源：提取到Helper后重定向失效的原因 #

Rails的Helper属于视图层上下文，无法调用控制器的redirect_to等方法。控制器的逻辑应当保留在控制器内部，或提取到控制器Concern中复用，而非Helper。

可读性优化步骤 #

1. 用卫语句替代嵌套if-elsif：将每个条件单独判断，满足时直接执行重定向并返回，避免嵌套结构，让逻辑更线性清晰。
2. 封装重复逻辑：把重复的登录页重定向、提示信息拼接逻辑封装成独立方法，减少代码冗余。
3. 修正过期判断逻辑：原代码中payload_expired?的判断逻辑完全相反，需修正为当前时间大于过期时间时判定为过期。

优化后的代码 #

module Users
  class RegistrationsController < Devise::RegistrationsController
    before_action :assert_jwe_token

    private

    def assert_jwe_token
      # 无JWE Token的情况
      return redirect_to_login if params[:jwe_token].blank?

      # Token解密失败的情况
      return redirect_to_login_with_alert(:failed) if payload.failure?

      # Token过期的情况
      decoded_payload = payload.value!
      return redirect_to_login_with_alert(:expired) if payload_expired?(decoded_payload)
    end

    def payload_expired?(payload)
      # 修正逻辑：当前时间大于过期时间则判定为过期
      Time.now.utc.to_i > payload['exp']
    end

    def payload
      @payload ||= JweToken::DecryptJson.new(params[:jwe_token]).call
    end

    # 封装基础重定向逻辑
    def redirect_to_login
      redirect_to new_user_session_path
    end

    # 封装带提示的重定向逻辑
    def redirect_to_login_with_alert(key)
      redirect_to new_user_session_path, alert: t("devise.registrations.jwe_register.#{key}")
    end
  end
end

额外优化：用Concern复用逻辑（多控制器场景） #

如果多个控制器需要相同的JWE Token校验逻辑，可提取到Concern中：

# app/controllers/concerns/jwe_token_authenticatable.rb
module JweTokenAuthenticatable
  extend ActiveSupport::Concern

  included do
    before_action :assert_jwe_token
  end

  private

  def assert_jwe_token
    return redirect_to_login if params[:jwe_token].blank?
    return redirect_to_login_with_alert(:failed) if payload.failure?

    decoded_payload = payload.value!
    return redirect_to_login_with_alert(:expired) if payload_expired?(decoded_payload)
  end

  def payload_expired?(payload)
    Time.now.utc.to_i > payload['exp']
  end

  def payload
    @payload ||= JweToken::DecryptJson.new(params[:jwe_token]).call
  end

  def redirect_to_login
    redirect_to new_user_session_path
  end

  def redirect_to_login_with_alert(key)
    redirect_to new_user_session_path, alert: t("devise.registrations.jwe_register.#{key}")
  end
end

在控制器中引入即可复用：

module Users
  class RegistrationsController < Devise::RegistrationsController
    include JweTokenAuthenticatable
  end
end

内容的提问来源于stack exchange，提问作者tajfun_88