OCaml实现Raft协议时遇let rec右侧表达式不允许错误求助

核心错误原因：let rec的递归定义限制 #

OCaml中let rec仅允许定义递归函数或由构造器/常量构成的递归值，你当前直接将一个匹配表达式作为let rec的右值，不符合语法规则，因此触发This kind of expression is not allowed as right-hand side of let rec'错误。同时，错误的表达式结构导致OCaml推导其类型为unit，而非你声明的int。

具体问题与修复方案 #

1. 递归定义方式错误 #

将request_vote_loop从递归值改为递归函数，添加()参数：

// 原错误写法
let rec request_vote_loop: int = ...

// 修复后
let rec request_vote_loop () : int = ...

调用时需改为request_vote_loop ()，比如最后一行：

print_endline (Int.to_string (request_vote_loop ()))

2. 序列表达式的括号缺失 #

代码中多处if分支的多表达式未用begin ... end包裹，导致逻辑混乱和类型推导错误。例如：

// 原错误写法
if status = 1 then (Array.get votePeers id) := true; (Chan.send c ReceiveVoteEvent); loop (n - 1)

// 修复后：将多个表达式作为if分支的整体
if status = 1 then begin
  (Array.get votePeers id) := true;
  Chan.send c ReceiveVoteEvent;
  loop (n - 1)
end else loop (n - 1)

类似的，ReceiveVoteEvent分支的代码也需要修正括号：

// 原错误写法
if !current_vote > (Array.length (!peers) / 2) then 
  begin current_vote := !current_vote + 1; myState.myRole <- Leader; 3 end
else current_vote := !current_vote + 1; request_vote_loop

// 修复后：else分支的多表达式也需要包裹
if !current_vote > (Array.length !peers / 2) then begin
  current_vote := !current_vote + 1;
  myState.myRole <- Leader;
  3
end else begin
  current_vote := !current_vote + 1;
  request_vote_loop ()
end

3. Domain.spawn的参数错误 #

Array.make的第二个参数是单个表达式，你当前传入的Domain.spawn (fun i -> ...)中i是未绑定变量，应该用Array.mapi遍历索引生成域：

// 原错误写法
arr := Array.make (Array.length (!peers)) (Domain.spawn (fun i -> ...))

// 修复后：用mapi获取索引i，且Domain.spawn接收无参函数
arr := Array.mapi (fun i conn ->
  Domain.spawn (fun () ->
    if not !(Array.get votePeers i) then 0
    else
      Lwt_main.run (
        let+ resp = call_server conn (RequestVoteArg({
            candidateNumber = myState.myPersistentState.id;
            term = myState.myPersistentState.currentTerm;
            lastlogIndex = (Array.get myState.myPersistentState.logs ((Array.length myState.myPersistentState.logs) - 1)).index;
            lastlogTerm = (Array.get myState.myPersistentState.logs ((Array.length myState.myPersistentState.logs) - 1)).term
        })) in
        match resp with
        | Error(s) ->
            Chan.send votes (0, i);
            Printf.printf "requestVote: connection failed: %s\n" s;
            1
        | Ok(repl, s) ->
            match repl with
            | RequestVoteRet(repl) ->
                if repl.voteGranted then begin
                  Chan.send votes (1, i);
                  Printf.printf "requestVote: status: %s, currentVote: %d\n" s !current_vote;
                  2
                end else if not (repl.term = (-1l)) then begin
                  myState.myPersistentState.currentTerm <- repl.term;
                  Chan.send votes (0, i);
                  Printf.printf "requestVote failed because of term: status: %s, currentVote: %d\n" s !current_vote;
                  3
                end else begin
                  Chan.send votes (0, i);
                  Printf.printf "requestVote failed: status: %s\n" s;
                  4
                end
            | _ -> failwith "Should not reach here"
      )
  )
) !peers;
request_vote_loop ()

修复后的完整代码片段 #

let rec request_vote_loop () : int = 
  match myState.myRole with
  | Follower -> 0
  | Leader -> 1
  | Candidate -> 
    let trigger = Domain.spawn(fun _ -> Chan.send c TriggerEvent) in
    let request_vote_daemon = Domain.spawn(fun _ -> 
      let rec loop n = 
        if n = 0 then 0
        else let msg = Chan.recv votes in
        match msg with
        | (status, id) -> 
          Domain.join (Array.get !arr id);
          if status = 1 then begin
            (Array.get votePeers id) := true;
            Chan.send c ReceiveVoteEvent;
            loop (n - 1)
          end else loop (n - 1)
      in loop ((Array.length !peers) / 2 + 1 - !current_vote)) in
    let evt = Chan.recv c in
    match evt with
      | TimeoutEvent -> 
          myState.myRole <- Follower; 
          3
      | AppendEntriesEvent(_) -> 
          myState.myRole <- Follower; 
          4
      | ReceiveVoteEvent -> 
          if !current_vote > (Array.length !peers / 2) then begin
            current_vote := !current_vote + 1;
            myState.myRole <- Leader;
            3
          end else begin
            current_vote := !current_vote + 1;
            request_vote_loop ()
          end
      | TriggerEvent -> 
          arr := Array.mapi (fun i conn ->
            Domain.spawn (fun () ->
              if not !(Array.get votePeers i) then 0
              else
                Lwt_main.run (
                  let+ resp = call_server conn (RequestVoteArg({
                      candidateNumber = myState.myPersistentState.id;
                      term = myState.myPersistentState.currentTerm;
                      lastlogIndex = (Array.get myState.myPersistentState.logs ((Array.length myState.myPersistentState.logs) - 1)).index;
                      lastlogTerm = (Array.get myState.myPersistentState.logs ((Array.length myState.myPersistentState.logs) - 1)).term
                  })) in
                  match resp with
                  | Error(s) ->
                      Chan.send votes (0, i);
                      Printf.printf "requestVote: connection failed: %s\n" s;
                      1
                  | Ok(repl, s) ->
                      match repl with
                      | RequestVoteRet(repl) ->
                          if repl.voteGranted then begin
                            Chan.send votes (1, i);
                            Printf.printf "requestVote: status: %s, currentVote: %d\n" s !current_vote;
                            2
                          end else if not (repl.term = (-1l)) then begin
                            myState.myPersistentState.currentTerm <- repl.term;
                            Chan.send votes (0, i);
                            Printf.printf "requestVote failed because of term: status: %s, currentVote: %d\n" s !current_vote;
                            3
                          end else begin
                            Chan.send votes (0, i);
                            Printf.printf "requestVote failed: status: %s\n" s;
                            4
                          end
                      | _ -> failwith "Should not reach here"
                )
            )
          ) !peers;
          request_vote_loop ()
      | _ -> failwith "Should not reach here"

in print_endline (Int.to_string (request_vote_loop ()))

内容的提问来源于stack exchange，提问作者Murphy