ListView首尾项复选框状态联动异常问题求助

Hey there, this is a super common issue with ListView's view recycling combined with how you're tracking CheckBox states—let's break down what's going wrong and fix it step by step.

Why This Is Happening #

1. View Recycling: ListView reuses convertView to save memory, so when you scroll, the first item's view might get reused for the last item (and vice versa). If you don't explicitly reset the CheckBox state, it keeps the old state from the recycled view.
2. Dynamic ID Problem: You're setting the CheckBox's ID to id_patient.get(position)—Android expects view IDs to be unique and stable. When views are recycled, this can cause unintended state syncs because the system might confuse IDs across reused views.
3. Missing State Tracking: You're relying on the CheckBox's current state instead of maintaining a separate source of truth for which items are selected. When views are recycled, the old state sticks around unless you overwrite it.

Step-by-Step Fix #

1. Use a State Tracking Collection (or Reuse Your Existing Cabinet State)

Instead of trusting the CheckBox's state, maintain a dedicated set (or use your existing Cabinet's selection state) to track which patient IDs are selected. This is your single source of truth, so it won't be affected by view recycling.

2. Replace Dynamic IDs with Tags

Stop setting the CheckBox's ID dynamically—use setTag() to attach the patient ID to the CheckBox instead. This is the safe way to associate data with a view without causing ID conflicts.

3. Explicitly Set CheckBox State in getView()

Every time you bind data to a view (whether it's a new view or a recycled one), force the CheckBox to match your state collection. This ensures recycled views don't show old, incorrect states.

4. Optimize Click Listener Setup

Don't set the OnClickListener every time getView() runs—set it once when you inflate the view. This avoids redundant listener attachments and potential bugs.

Modified Adapter Code #

// Add this at the top of your Adapter class to track selected IDs (or use Cabinet's existing state)
private Set<Integer> selectedPatientIds = new HashSet<>();

@NonNull
@Override
public View getView(int position, @Nullable View convertView, @NonNull ViewGroup parent) {
    ViewHolder viewHolder;
    final int currentPatientId = id_patient.get(position); // Grab the current patient's ID early

    if (convertView == null) {
        viewHolder = new ViewHolder();
        LayoutInflater inflater = LayoutInflater.from(context);
        convertView = inflater.inflate(R.layout.modele_liste_patient, parent, false);
        
        // Initialize all views
        viewHolder.champNomPrenom = convertView.findViewById(R.id.modele_liste_patient_nom_prenom_patient);
        viewHolder.champDate = convertView.findViewById(R.id.modele_liste_patient_date_naissance_patient);
        viewHolder.icon = convertView.findViewById(R.id.modele_liste_patient_image_patient);
        viewHolder.checkBox = convertView.findViewById(R.id.bonjour);
        
        // Set click listener ONCE when inflating the view
        convertView.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                ViewHolder holder = (ViewHolder) v.getTag();
                int patientId = (int) holder.checkBox.getTag();
                
                // Update state based on current check status
                if (holder.checkBox.isChecked()) {
                    selectedPatientIds.remove(patientId);
                    Cabinet.supprimerIdPourSupression(patientId);
                    holder.checkBox.setChecked(false);
                } else {
                    selectedPatientIds.add(patientId);
                    Cabinet.ajouterIdPourSupression(patientId);
                    holder.checkBox.setChecked(true);
                }
            }
        });

        convertView.setTag(viewHolder);
    } else {
        viewHolder = (ViewHolder) convertView.getTag();
    }

    // Bind static data
    viewHolder.champNomPrenom.setText(nom_prenom.get(position));
    viewHolder.champDate.setText(date_naissance.get(position));
    
    // Attach patient ID to CheckBox via tag (instead of setting ID)
    viewHolder.checkBox.setTag(currentPatientId);

    // Toggle visibility based on deletion mode
    if (supression) {
        ImageView imageView = convertView.findViewById(R.id.aurevoir);
        viewHolder.checkBox.setVisibility(View.VISIBLE);
        imageView.setVisibility(View.INVISIBLE);
    } else {
        viewHolder.checkBox.setVisibility(View.GONE);
        convertView.findViewById(R.id.aurevoir).setVisibility(View.VISIBLE);
    }

    // Critical: Reset CheckBox state to match our source of truth
    // If you can check directly against Cabinet's state, use that instead:
    // viewHolder.checkBox.setChecked(Cabinet.contientIdPourSupression(currentPatientId));
    viewHolder.checkBox.setChecked(selectedPatientIds.contains(currentPatientId));

    // Image loading logic remains the same
    File imgFile = new File(image.get(position));
    if (imgFile.exists()) {
        Picasso.get()
                .load(imgFile)
                .resize(80, 80)
                .centerCrop()
                .transform(new CircleTransform())
                .into(viewHolder.icon);
    } else {
        Picasso.get()
                .load("url")
                .placeholder(R.drawable.ic_action_utilisateur_default)
                .error(R.drawable.ic_action_utilisateur_default)
                .transform(new CircleTransform())
                .into(viewHolder.icon);
    }

    return convertView;
}

private static class ViewHolder {
    TextView champNomPrenom;
    TextView champDate;
    ImageView icon;
    CheckBox checkBox;
}

Bonus Tip #

If your Cabinet class already tracks the selected IDs for deletion, you can skip creating the selectedPatientIds set and directly use Cabinet's methods to check the state. For example:

viewHolder.checkBox.setChecked(Cabinet.isIdSelectedForDeletion(currentPatientId));

Just make sure Cabinet has a method to check if an ID is in the deletion list!

内容的提问来源于stack exchange，提问作者Lucien Barcon