如何优化含多Specification的动态搜索if-else逻辑

问题描述 #

我需要基于请求体字段实现动态搜索，已经写好多个Specification，但当前拼接逻辑用布尔变量判断是否为首个条件，产生大量重复的if-else代码。希望优化成能支持10+参数的简洁写法，要求首个条件用Specification.where()，后续用.and()拼接。当前代码示例如下：

public Specification<ShapeEntity> conditionalSearch(ShapeParams shapeParams) {
    Specification spec = null;
    boolean isFirstParam = true;
    if (shapeParams.getType() != null) {
        if (isFirstParam) {
            spec = Specification.where(isTypeEqual(shapeParams.getType()));
            isFirstParam = false;
        } else {
            spec = spec.and(isTypeEqual(shapeParams.getType()));
        }
    }

    if (shapeParams.getWidthTo() != null) {
        if (isFirstParam) {
            spec = Specification.where(isWidthLessThan(shapeParams.getWidthTo()));
            isFirstParam = false;
        } else {
            spec = spec.and(isWidthLessThan(shapeParams.getWidthTo()));
        }
    }

    if (shapeParams.getWidthFrom() != null) {
        if (isFirstParam) {
            spec = Specification.where(isWidthGreaterThan(shapeParams.getWidthTo()));
            isFirstParam = false;
        } else {
            spec = spec.and(isWidthGreaterThan(shapeParams.getWidthTo()));
        }
    }
    return spec;
}

优化方案 #

可以通过收集有效Specification列表+统一拼接的方式消除冗余逻辑，核心思路是先把所有非空字段对应的Specification收集起来，再一次性完成拼接，避免嵌套判断。

基础优化版代码 #

public Specification<ShapeEntity> conditionalSearch(ShapeParams shapeParams) {
    List<Specification<ShapeEntity>> validSpecs = new ArrayList<>();

    // 逐个判断字段，非空则加入有效条件列表
    if (shapeParams.getType() != null) {
        validSpecs.add(isTypeEqual(shapeParams.getType()));
    }
    if (shapeParams.getWidthTo() != null) {
        validSpecs.add(isWidthLessThan(shapeParams.getWidthTo()));
    }
    if (shapeParams.getWidthFrom() != null) {
        // 注意：原代码此处参数错误，已修正为WidthFrom
        validSpecs.add(isWidthGreaterThan(shapeParams.getWidthFrom()));
    }

    // 拼接所有有效条件
    Specification<ShapeEntity> resultSpec = null;
    for (Specification<ShapeEntity> spec : validSpecs) {
        if (resultSpec == null) {
            resultSpec = Specification.where(spec);
        } else {
            resultSpec = resultSpec.and(spec);
        }
    }

    return resultSpec;
}

进一步简化（Stream版） #

如果偏好更简洁的写法，可以用Java Stream的reduce方法自动处理拼接逻辑：

public Specification<ShapeEntity> conditionalSearch(ShapeParams shapeParams) {
    List<Specification<ShapeEntity>> validSpecs = new ArrayList<>();

    if (shapeParams.getType() != null) validSpecs.add(isTypeEqual(shapeParams.getType()));
    if (shapeParams.getWidthTo() != null) validSpecs.add(isWidthLessThan(shapeParams.getWidthTo()));
    if (shapeParams.getWidthFrom() != null) validSpecs.add(isWidthGreaterThan(shapeParams.getWidthFrom()));

    return validSpecs.stream()
            .reduce((prevSpec, nextSpec) -> prevSpec.and(nextSpec))
            .orElse(null);
}

说明：Stream的reduce会自动处理首个条件用where、后续用and的逻辑，列表为空时orElse(null)会返回null，和原代码行为完全一致。

优化优势 #

• 冗余代码大幅减少，新增参数仅需添加一行if判断并加入列表
• 逻辑清晰，避免嵌套if-else带来的可读性问题
• 维护成本低，修改或新增条件只需调整对应行的Specification即可

内容的提问来源于stack exchange，提问作者Lulex97