MVVM模式下从单例ClassA修改MainViewModel属性失败求助

问题描述 #

尝试在MVVM模式下，通过ClassA单例修改MainViewModel的MyText属性，但点击"Class A"按钮后界面无变化，不确定问题出在哪里。

代码实现 #

XAML界面代码 #

<Window.DataContext>
    <local:MainViewModel/>
</Window.DataContext>
<Grid>
    <StackPanel Orientation="Vertical">
        <TextBlock Text="{Binding MyText}"
                   Margin="50"/>
        <Button Content="Main Class"
                Width="150"
                Height="70"
                Margin="50"
                Command="{Binding Cmd}"
                CommandParameter="MainClass"/>

        <Button Content="Class A"
                Width="150"
                Height="70"
                Command="{Binding Cmd}"
                CommandParameter="ClassA" />
    </StackPanel>
</Grid>

MainViewModel代码 #

public class MainViewModel : BaseViewModel
{
    private static MainViewModel instance = new MainViewModel();
    static MainViewModel()
    {
        instance = new MainViewModel();
    }
    public static MainViewModel Instance
    {
        get => instance;
    }
    private string myText = string.Empty;
    public string MyText
    {
        get
        {
            return myText;
        }
        set
        {
            if( myText != value)
            {
                myText = value;
                OnPropertyChanged();
            }
        }
    }
    public RelayCommand Cmd { get => new RelayCommand(CmdExec); }
    private void CmdExec(object parameter)
    {
        switch (parameter.ToString())
        {
            case "MainClass":
                try
                {
                    MyText = "I am from Class -> MainViewModel!";
                }
                catch (Exception ex)
                {
                    MessageBox.Show(ex.Message);
                }
                break;

            case "ClassA":
                try
                {
                    // MyText = "I'am from Class -> ClassA!";
                    ClassA.Instance.ChangeText();
                }
                catch (Exception ex)
                {
                    MessageBox.Show(ex.Message);
                }
                break;
            default:
                break;
        }
    }
}

ClassA代码 #

public class ClassA
{
    private static readonly ClassA instance=new ClassA();

    static ClassA()
    {
       
    }
    private ClassA() { }
    public static ClassA Instance
    {
        get => instance;
    }
    public void ChangeText()
    {
        MainViewModel.Instance.MyText = "I'am from Class -> ClassA!";
    }
}

BaseViewModel代码 #

public class BaseViewModel : INotifyPropertyChanged
{
    public event PropertyChangedEventHandler PropertyChanged;
    protected void OnPropertyChanged([CallerMemberName] string name = null)
    {
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(name));
    }
}

RelayCommand代码 #

public class RelayCommand : ICommand
{
    private readonly Action<object> _execute;
    private readonly Predicate<object> _canExecute;

    public RelayCommand(Action<object> execute)
        : this(execute, null)
    {
    }
    public RelayCommand(Action<object> execute, Predicate<object> canExecute)
    {
        if (execute == null)
            throw new ArgumentNullException("execute");
        _execute = execute;
        _canExecute = canExecute;
    }
    public bool CanExecute(object parameter)
    {
        return _canExecute == null ? true : _canExecute(parameter);
    }
    public event EventHandler CanExecuteChanged
    {
        add { CommandManager.RequerySuggested += value; }
        remove { CommandManager.RequerySuggested -= value; }
    }
    public void Execute(object parameter)
    {
        _execute(parameter);
    }
}

问题根源 #

1. 单例实例重复创建：MainViewModel中先通过字段初始化创建了一个实例，静态构造函数又再次创建新实例，导致单例逻辑混乱。
2. 界面绑定实例与单例不一致：XAML中通过<local:MainViewModel/>新建了独立的ViewModel实例，而ClassA修改的是MainViewModel.Instance这个单例对象的属性，两个实例完全无关，UI自然无法感知到变化。
3. RelayCommand重复实例化：Cmd属性每次被访问都会新建RelayCommand对象，属于不必要的性能浪费。

修复方案 #

1. 修正MainViewModel单例实现 #

确保单例仅初始化一次，且禁止外部实例化：

public class MainViewModel : BaseViewModel
{
    private static readonly MainViewModel _instance = new MainViewModel();

    private MainViewModel() { }

    public static MainViewModel Instance => _instance;

    private string myText = string.Empty;
    public string MyText
    {
        get => myText;
        set
        {
            if (myText != value)
            {
                myText = value;
                OnPropertyChanged();
            }
        }
    }

    private RelayCommand _cmd;
    public RelayCommand Cmd => _cmd ??= new RelayCommand(CmdExec);

    private void CmdExec(object parameter)
    {
        switch (parameter.ToString())
        {
            case "MainClass":
                MyText = "I am from Class -> MainViewModel!";
                break;
            case "ClassA":
                ClassA.Instance.ChangeText();
                break;
            default:
                break;
        }
    }
}

2. 修改XAML绑定到单例实例 #

让界面绑定的ViewModel和ClassA操作的是同一个单例对象：

<Window.DataContext>
    <Binding Source="{x:Static local:MainViewModel.Instance}"/>
</Window.DataContext>

3. 验证效果 #

点击"Class A"按钮后，ClassA修改的是界面绑定的ViewModel实例的MyText属性，属性变化会通过INotifyPropertyChanged通知UI，TextBlock内容会同步更新为"I'am from Class -> ClassA!"。

内容的提问来源于stack exchange，提问作者wpf