VBA遍历工作表Shape设置颜色：匹配Shape.Name失败问题求助

原代码问题分析 #

你原代码的核心问题是直接将Shape对象与字符串比较（If sh = yFilter(i)），这无法正确匹配Shape的名称。另外，sh.Select和Selection属于冗余操作，直接操作Shape对象即可避免不必要的交互。

修正后的循环遍历方案 #

如果需要保留逐个遍历的逻辑，修改为比较Shape的Name属性即可：

Dim yFilter(1 To 5) As String
yFilter(1) = "BD_P"
yFilter(2) = "FIN_P"
yFilter(3) = "PM_P"
yFilter(4) = "IPS_P"
yFilter(5) = "ENG_P"

Dim sh As Shape
Dim i As Integer

For Each sh In ActiveSheet.Shapes
    For i = 1 To 5
        ' 匹配Shape的Name属性
        If sh.Name = yFilter(i) Then
            With sh.Fill
                .Visible = msoTrue
                .ForeColor.RGB = RGB(255, 255, 255)
            End With
            Exit For ' 找到匹配后跳出内层循环，提升效率
        End If
    Next i
Next

更高效的批量处理方案 #

既然你提到可以用Shapes.Range(Array(...))选中目标Shape，直接利用这个特性实现批量操作，无需嵌套循环：

Dim yFilter As Variant
' 直接定义为数组，写法更简洁
yFilter = Array("BD_P", "FIN_P", "PM_P", "IPS_P", "ENG_P")

Dim targetShapes As ShapeRange
Set targetShapes = ActiveSheet.Shapes.Range(yFilter)

' 批量设置所有目标Shape的填充颜色
With targetShapes.Fill
    .Visible = msoTrue
    .ForeColor.RGB = RGB(255, 255, 255)
End With

这种方式直接通过数组定位所有目标Shape，一次性完成属性设置，效率更高，也符合你想要的批量处理需求。

内容的提问来源于stack exchange，提问作者Ethan Bradberry