Node.js+MongoDB开发首遇Cannot read property 'insertOne' of undefined问题求助

Hey there! Let's break down why you're hitting this error and how to fix it quickly.

The Root Cause #

Your error happens because client.connect() is an asynchronous operation, but you're calling addAnimal() right away before the connection finishes setting up. When addAnimal() runs, the animals variable hasn't been assigned to the MongoDB collection yet—it's still undefined, hence the error when trying to call insertOne() on it.

Solution 1: Use Async/Await (Cleanest Approach) #

Async/await makes asynchronous code read like regular synchronous code, which is way easier to follow. Here's your adjusted code:

const prompt = require('prompt-sync')();
const mongo = require('mongodb');
const client = new mongo.MongoClient('mongodb://localhost:27017', { useNewUrlParser: true, useUnifiedTopology: true });

async function addAnimal() {
  try {
    // Wait for the database connection to fully establish
    await client.connect();
    const db = client.db('test');
    const animals = db.collection('animals');
    
    // Get user input
    const animalName = prompt('Name: ');
    const ageAnimal = prompt('Age: ');
    
    // Insert the animal document
    await animals.insertOne({ nameAnimal: animalName, age: ageAnimal });
    console.log('Added!');
  } catch (err) {
    console.error('Error during operation:', err);
  } finally {
    // Always close the connection when done to avoid resource leaks
    await client.close();
  }
}

// Run the function
addAnimal();

Solution 2: Call addAnimal() Inside the Connect Callback #

If you prefer sticking with callbacks, move your addAnimal() call inside the client.connect() callback. This guarantees the connection is ready before you try to interact with the collection:

const prompt = require('prompt-sync')();
const mongo = require('mongodb');
const client = new mongo.MongoClient('mongodb://localhost:27017', { useNewUrlParser: true, useUnifiedTopology: true });
var db;
var animals;

client.connect((err) => {
  // Always handle connection errors first!
  if (err) {
    console.error('Failed to connect to MongoDB:', err);
    return;
  }
  
  db = client.db('test');
  animals = db.collection('animals');
  // Now that the connection is ready, call addAnimal
  addAnimal();
});

function addAnimal() {
  const animalName = prompt('Name: ');
  const ageAnimal = prompt('Age: ');
  
  animals.insertOne(
    { nameAnimal: animalName, age: ageAnimal },
    (err) => {
      if (err) {
        console.log('Error inserting animal:', err);
      } else {
        console.log('Added!');
      }
      // Close the connection after the operation
      client.close();
    }
  );
}

Key Takeaways #

• Don't rush async operations: MongoDB connections take time to set up—always wait for them to finish before working with the database.
• Handle errors: Always check for connection or operation errors to avoid silent failures that are hard to debug.
• Clean up resources: Close the MongoDB client when you're done to prevent unused connections from lingering.

内容的提问来源于stack exchange，提问作者Zaisty