VS编译报C6330警告且程序异常退出（代码3），求问题排查

Let's walk through the problems in your code that are causing the crash (process exit code 3) and the C6330 warning, then fix them step by step:

1. Fatal Issue: Memory Out-of-Bounds (Causing Crash) #

The biggest problem is you're incrementing count way too many times with ++count every time you access book[++count].

For example:

• When reading the ISBN: cin.getline(book[++count].isbn_code, 14, '\n') increases count by 1
• Then strlen(book[++count].isbn_code) increases it again
• And every loop iteration !isdigit(book[++count].isbn_code[i]) increases it yet again

Since counter() returns 40 (your existing record count), count starts at 40, and after just a few operations it's way beyond the size of your book array. This leads to illegal memory access, which causes the program to crash immediately with exit code 3.

Fix:
Use the initial count value as the index for the new record, and only increment it if you need to add multiple records (which you don't here). All accesses should use book[count] instead of book[++count].

2. Warning C6330: isdigit Parameter Type Mismatch #

The warning happens because isdigit() expects an int argument that's either an unsigned char value or EOF. If your char type is signed (which is common), passing a char with a value >127 will be interpreted as a negative number, leading to undefined behavior.

Fix:
Cast the char to unsigned char before passing it to isdigit():

if (!isdigit(static_cast<unsigned char>(book[count].isbn_code[i])))

3. Other Potential Issues to Fix #

• Incorrect loop condition: Your for (int i = 0; i <= length; i++) loops one step too far. strlen() returns the length of the string excluding the null terminator ('\0'), so you should loop while i < length to avoid checking the null character.
• Redundant file check: !outfile.eof() is useless when opening a file for appending. You only need to check outfile.is_open().
• Input buffer residue: If you used cin >> anywhere before this function, a newline character might be left in the input buffer, causing cin.getline() to read an empty string. Add cin.ignore(numeric_limits<streamsize>::max(), '\n'); before your first getline() to clear this (don't forget to include <limits> header).
• Incorrect file writing: Your original code uses book[++count] again when writing to the file, which points to the wrong array index. Use book[count] instead to write the valid record you just collected.

Corrected Code Example #

Here's how your add_record function should look after fixing all these issues:

#include <iostream>
#include <fstream>
#include <cstring>
#include <cctype>
#include <limits>

using namespace std;

struct DATA {
    char isbn_code[14];
    char author[50];
    // Add other fields as needed
};

int counter() {
    // Your existing counter logic here; returns 40 for your test case
    return 40;
}

int add_record(DATA book[]) {
    int count = counter();
    system("CLS");
    cout << "\t\t\t\t\t\t : :Add Book Record: :\n\n";
    bool cont;
    ofstream outfile("books.txt", ios::app);

    if (outfile.is_open()) {
        // ISBN Input Validation
        do {
            cont = true;
            cout << "ISBN Code: ";
            // Clear leftover newline from input buffer
            cin.ignore(numeric_limits<streamsize>::max(), '\n');
            cin.getline(book[count].isbn_code, 14, '\n');

            int length = strlen(book[count].isbn_code);
            // Optional: Check if ISBN is exactly 13 digits
            if (length != 13) {
                cont = false;
                cout << "Error: ISBN must be 13 digits long. Try again.\n";
                continue;
            }

            for (int i = 0; i < length; i++) {
                if (!isdigit(static_cast<unsigned char>(book[count].isbn_code[i]))) {
                    cont = false;
                    cout << "Error: ISBN can only contain digits. Try again.\n";
                    break;
                }
            }
        } while (!cont);

        // Author Input Validation
        do {
            cont = true;
            cout << "Author: ";
            cin.getline(book[count].author, 50, '\n');

            int length = strlen(book[count].author);
            for (int i = 0; i < length; i++) {
                if (isdigit(static_cast<unsigned char>(book[count].author[i]))) {
                    cont = false;
                    cout << "Error: Author name cannot contain digits. Try again.\n";
                    break;
                }
            }
        } while (!cont);

        // Write valid record to file
        outfile << book[count].isbn_code << "," << book[count].author << "\n";
        outfile.close();
        cout << "Book record added successfully!\n";
    } else {
        cout << "Error: Could not open books.txt for writing.\n";
    }
    return 0;
}

内容的提问来源于stack exchange，提问作者OYS