C++ localtime函数异常求助：时间值异常且localtime_s无法使用

Let's break down what's going wrong with your time code and fix it step by step:

The Root Problems #

1. You're not capturing the result of localtime
   When you call localtime(&current), it returns a pointer to a populated tm struct—but you never assign that pointer to your now variable. That means now.tm_hour, now.tm_min, and now.tm_sec are uninitialized garbage values, which explains those huge, nonsensical numbers.

2. localtime_s usage was incorrect
   VS Code (with MSVC compiler) flags localtime as unsafe because it uses a shared global buffer (risky in multi-threaded code) and recommends localtime_s instead. If it wasn't working for you, it's likely because you didn't follow its correct parameter format.

Fixed Code #

Here's the corrected version of your function, with proper time handling, safety, and clean formatting:

#include <iostream>
#include <string>
#include <sstream>
#include <fstream>
#include <ctime>
#include <iomanip> // Needed for setw/setfill to pad numbers with zeros

// Assume these functions are defined elsewhere
std::string show() {
    return "Sample content for the file";
}

void print_time() {
    // Your print_time implementation here
}

void write(std::string team_name) {
    // Get current time
    time_t current_time = time(0);
    struct tm local_time{}; // Initialize struct to avoid garbage values

    // Use localtime_s (safe, MSVC-recommended version)
    errno_t time_err = localtime_s(&local_time, &current_time);
    if (time_err != 0) {
        std::cerr << "Error getting local time!" << std::endl;
        return;
    }

    // Format time as HH:MM:SS (with leading zeros for single-digit values)
    std::stringstream time_stream;
    time_stream << std::setw(2) << std::setfill('0') << local_time.tm_hour << ":"
                << std::setw(2) << std::setfill('0') << local_time.tm_min << ":"
                << std::setw(2) << std::setfill('0') << local_time.tm_sec;

    // Create a clean filename (added underscores for readability)
    std::stringstream filename_stream;
    filename_stream << "Filename_" << team_name << "_" << time_stream.str() << ".txt";

    // Open and write to the file
    std::ofstream output_file(filename_stream.str());
    if (output_file.is_open()) {
        output_file << show();
        print_time(); // Removed the unnecessary declaration here
        output_file.close();
    } else {
        std::cerr << "Failed to open output file!" << std::endl;
    }
}

Key Improvements Explained #

• Proper localtime_s usage: This function takes two pointers (your tm struct and the time_t value) and returns an error code to check if it succeeded—no more shared global buffers.
• Struct initialization: struct tm local_time{}; zero-initializes the struct, so even if something goes wrong, you won't get random garbage values.
• Leading zeros for time: std::setw(2) and std::setfill('0') ensure single-digit hours/minutes/seconds are padded with a zero (e.g., 9:5:3 becomes 09:05:03), matching your desired HH:MM:SS format.
• Cleaner filenames: Added underscores between filename parts so TeamA + 163030 becomes TeamA_163030 instead of TeamA163030.
• Error checking: Added checks for time retrieval and file opening to catch issues early.

If You Must Use localtime (Not Recommended) #

If you need to use the older localtime function (not safe for multi-threaded code), you have to capture its returned pointer and copy the data into your struct:

struct tm* time_ptr = localtime(&current_time);
if (time_ptr != nullptr) {
    local_time = *time_ptr;
} else {
    std::cerr << "Error getting local time!" << std::endl;
    return;
}

But stick with localtime_s—it's the safer, standard-compliant choice for modern Windows/C++ development.

内容的提问来源于stack exchange，提问作者frushan