Java Swing猜拳程序点击按钮后JLabel不更新的问题求助

问题根源 #

你在按钮事件处理中重新创建了comChoice JLabel实例，但这个新对象从未被添加到界面的面板中，界面上显示的还是构造方法里最初添加的旧标签，所以修改后看不到变化。

具体修改步骤 #

1. 直接更新已有标签的文本，而非新建对象
   把comChoice = new JLabel("Computer choice : " + rand1);替换为comChoice.setText("Computer choice : " + rand1);，直接修改已有标签的内容即可。
2. 删除无用代码
   代码里的Scanner input = new Scanner(System.in);完全多余，GUI程序不需要控制台输入，直接删掉。
3. 提取重复逻辑，减少冗余
   三个按钮事件里生成电脑选择的代码完全重复，可以抽成单独方法，让代码更简洁。

修改后的完整代码 #

import javax.swing.*;
import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.util.Random;

public class RPS implements ActionListener {

    JFrame frame;
    JPanel panel;
    JButton buttonR;
    JButton buttonP;
    JButton buttonS;
    JLabel title;
    JLabel comChoice;

    int userScore = 0;
    int comScore = 0;
    String userInput;

    JLabel ps;
    JLabel cs;
    Random rand; // 全局Random实例，避免重复创建

    public RPS() {
        frame = new JFrame();
        panel = new JPanel(new GridBagLayout());
        buttonR = new JButton("ROCK");
        buttonP = new JButton("PAPER");
        buttonS = new JButton("SCISSORS");
        title = new JLabel("ROCK vs PAPER vs SCISSORS");
        ps = new JLabel("Player Score : 0");
        cs = new JLabel("Computer Score : 0");
        comChoice = new JLabel("Computer choice : ");
        rand = new Random(); // 初始化全局Random

        GridBagConstraints c = new GridBagConstraints();
        c.insets = new Insets(30, 30, 30, 30);
        c.gridx = 3;
        c.gridy = 0;
        panel.add(title, c);

        c.insets = new Insets(10, 10, 10, 10);
        c.gridx = 1;
        c.gridy = 2;
        panel.add(buttonR, c);
        c.gridx = 3;
        c.gridy = 2;
        panel.add(buttonP, c);
        c.gridx = 5;
        c.gridy = 2;
        panel.add(buttonS, c);

        c.insets = new Insets(15, 15, 15, 15);
        c.gridx = 2;
        c.gridy = 3;
        panel.add(ps, c);
        c.gridx = 4;
        c.gridy = 3;
        panel.add(cs, c);
        c.gridx = 3;
        c.gridy = 3;
        panel.add(comChoice, c);

        buttonR.addActionListener(this);
        buttonP.addActionListener(this);
        buttonS.addActionListener(this);

        frame.add(panel, BorderLayout.CENTER);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setTitle("Rock Paper Scissors");
        frame.pack();
        frame.setVisible(true);
    }

    public static void main(String[] args) {
        new RPS();
    }

    // 提取随机生成电脑选择的方法
    private String getComputerChoice() {
        String compGuess[] = {"ROCK", "PAPER", "SCISSORS"};
        return compGuess[rand.nextInt(3)];
    }

    @Override
    public void actionPerformed(ActionEvent e) {
        String computerChoice = getComputerChoice();
        if (e.getSource() == buttonR) {
            userInput = "ROCK";
        } else if (e.getSource() == buttonP) {
            userInput = "PAPER";
        } else if (e.getSource() == buttonS) {
            userInput = "SCISSORS";
        }
        // 更新标签文本
        comChoice.setText("Computer choice : " + computerChoice);
        
        // 新增胜负判断与分数更新
        judgeResult(userInput, computerChoice);
        ps.setText("Player Score : " + userScore);
        cs.setText("Computer Score : " + comScore);
    }

    // 胜负判断逻辑
    private void judgeResult(String userChoice, String computerChoice) {
        if (userChoice.equals(computerChoice)) {
            return; // 平局，分数不变
        }
        switch (userChoice) {
            case "ROCK":
                userScore += computerChoice.equals("SCISSORS") ? 1 : 0;
                comScore += computerChoice.equals("PAPER") ? 1 : 0;
                break;
            case "PAPER":
                userScore += computerChoice.equals("ROCK") ? 1 : 0;
                comScore += computerChoice.equals("SCISSORS") ? 1 : 0;
                break;
            case "SCISSORS":
                userScore += computerChoice.equals("PAPER") ? 1 : 0;
                comScore += computerChoice.equals("ROCK") ? 1 : 0;
                break;
        }
    }
}

额外说明 #

修改后不仅能正常更新comChoice标签，还补充了胜负判断和分数更新逻辑，让程序功能更完整。同时优化了Random实例的创建方式，避免重复对象生成。

内容的提问来源于stack exchange，提问作者Rie Rie