WPF删除ListBox多项时偶发NullReferenceException崩溃求助

问题现象 #

WPF应用中，通过ListBox的ContextMenu菜单执行删除命令批量删除ListBox项时，偶发崩溃并抛出NullReferenceException异常，该异常无法稳定复现。

异常日志 #

‧ System.NullReferenceException: Object reference not set to an instance of an object.    
  at System.Windows.Controls.VirtualizingStackPanel.GetMaxChildArrangeLength(IList children, Boolean isHorizontal) 
  at System.Windows.Controls.VirtualizingStackPanel.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at MS.Internal.Helper.ArrangeElementWithSingleChild(UIElement element, Size arrangeSize)    
  at System.Windows.Controls.ItemsPresenter.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.ScrollContentPresenter.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Grid.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Control.ArrangeOverride(Size arrangeBounds)    
  at System.Windows.Controls.ScrollViewer.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Border.ArrangeOverride(Size finalSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Control.ArrangeOverride(Size arrangeBounds)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at MS.Internal.Helper.ArrangeElementWithSingleChild(UIElement element, Size arrangeSize)    
  at System.Windows.Controls.ContentPresenter.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Border.ArrangeOverride(Size finalSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Grid.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Control.ArrangeOverride(Size arrangeBounds)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Grid.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.Controls.Grid.ArrangeOverride(Size arrangeSize)    
  at System.Windows.FrameworkElement.ArrangeCore(Rect finalRect)    
  at System.Windows.UIElement.Arrange(Rect finalRect)    
  at System.Windows.ContextLayoutManager.UpdateLayout()    
  at System.Windows.Interop.HwndSource.Process_WM_SIZE(UIElement rootUIElement, IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam)    
  at System.Windows.Interop.HwndSource.LayoutFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)    
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)    
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)    
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)    
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

相关代码 #

ListBox的XAML代码 #

<ListBox ItemsSource="{Binding ImgList}" SelectedItem="{Binding SelectedImg}" Style="{StaticResource ListBoxScroll}" SelectionMode="Extended" Background="#FF353535" HorizontalContentAlignment="Stretch" SelectionChanged="ListBox_SelectionChanged" BorderBrush="{x:Null}" ScrollViewer.HorizontalScrollBarVisibility="Disabled" BorderThickness="0">
    <ListBox.ContextMenu>
        <ContextMenu>                            
           <MenuItem Header="Delete File" Command="{Binding DeleteImageFileCommand}"/>
        </ContextMenu>
    </ListBox.ContextMenu>
    <ListBox.Resources>
        <DataTemplate x:Key="ItemTemplate">
             <Border Height="117" Width="208" BorderBrush="#FF979797" BorderThickness="1" Margin="21,0,0,18">
                 <Grid>
                    <Label x:Name="Lab" Width="40" Height="20" Grid.Column="0" Content="{Binding Converter={StaticResource ItemToIndex}, Mode=OneWay, Path=., RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type ListBoxItem}}}" FontSize="14"  HorizontalContentAlignment="Center" VerticalContentAlignment="Center" HorizontalAlignment="Left" VerticalAlignment="Top" Padding="0" Panel.ZIndex="1" Background="White" BorderBrush="#FF353535" BorderThickness="1" Foreground="#FF011627" Margin="-1,-1,0,0"/>
                    <Image Grid.Column="1" Width="208" Source="{Binding SmallImg, Converter={StaticResource MatToBmp}, IsAsync=True}" Stretch="Uniform"/>
                </Grid>
            </Border>
        </DataTemplate>
    </ListBox.Resources>
</ListBox>

索引Converter代码 #

public class FilterIndexConverter : IValueConverter
{
    public object Convert(object value, Type TargetType, object parameter, CultureInfo culture)
    {
        ListBoxItem item = (ListBoxItem)value;
        ListBox listBox = ItemsControl.ItemsControlFromItemContainer(item) as ListBox;
        int index = (listBox.ItemsSource as RangeObservableCollection<ImageInformation>).IndexOf((value as ListBoxItem).Content as ImageInformation);
        return index + 1;
    }

    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
    {
        throw new NotImplementedException();
    }
}

排查分析 #

1. Converter的空引用风险：当前FilterIndexConverter的Convert方法存在多处无空判断的强制类型转换：

   • 直接将value强制转换为ListBoxItem，若value为空或类型不符会抛出异常
   • ItemsControl.ItemsControlFromItemContainer(item)返回值可能为空，后续转换为ListBox未做判断
   • listBox.ItemsSource转换为RangeObservableCollection<ImageInformation>可能失败，直接调用IndexOf会触发空引用
   • listBoxItem.Content转换为ImageInformation也可能为空

   批量删除时，ListBox的虚拟化机制可能已卸载部分ListBoxItem，或者数据已从集合中移除，此时Converter执行会出现空引用，进而干扰VirtualizingStackPanel的布局计算，最终触发异常。

2. VirtualizingStackPanel布局异常：异常栈显示崩溃发生在VirtualizingStackPanel.GetMaxChildArrangeLength方法中，说明批量删除后布局更新时，VirtualizingStackPanel处理子元素集合时遇到了空引用，这大概率是因为数据集合与UI元素不同步，或者Converter的异常导致布局数据异常。

解决方案建议 #

1. 修复Converter的空引用问题 #

在Convert方法中添加完整的空值校验，避免强制转换失败：

public class FilterIndexConverter : IValueConverter
{
    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
    {
        var listBoxItem = value as ListBoxItem;
        if (listBoxItem == null)
            return string.Empty;

        var listBox = ItemsControl.ItemsControlFromItemContainer(listBoxItem) as ListBox;
        if (listBox == null)
            return string.Empty;

        var itemsSource = listBox.ItemsSource as RangeObservableCollection<ImageInformation>;
        if (itemsSource == null)
            return string.Empty;

        var imageInfo = listBoxItem.Content as ImageInformation;
        if (imageInfo == null)
            return string.Empty;

        int index = itemsSource.IndexOf(imageInfo);
        return index >= 0 ? (index + 1).ToString() : string.Empty;
    }

    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
    {
        throw new NotImplementedException();
    }
}

2. 优化批量删除的集合操作 #

确保使用RangeObservableCollection的批量删除方法（如RemoveRange），减少CollectionChanged事件的触发次数，避免布局频繁更新导致的数据不一致：

// 示例：批量删除选中项
var selectedItems = ImgList.Where(item => /* 选中判断逻辑 */).ToList();
ImgList.RemoveRange(selectedItems);

3. 排查虚拟化影响（可选） #

若修复后仍偶发异常，可临时禁用ListBox的虚拟化来验证是否为虚拟化机制导致：

<ListBox VirtualizingStackPanel.IsVirtualizing="False" ...>

注意：禁用虚拟化会降低大量数据时的性能，仅作为排查手段，不建议长期使用。

4. 确保命令执行的线程安全 #

删除命令需在UI线程执行，若删除操作涉及异步处理，需通过Dispatcher切换到UI线程更新集合：

Application.Current.Dispatcher.Invoke(() => {
    // 执行集合删除操作
});

内容的提问来源于stack exchange，提问作者Ricky Chen