C++(VC++)中GDI+ Bitmap转Base64失败及解锁安全方式咨询

Hey there, let's work through your two key issues: the all-zero charPixels array and safe LockBits/UnlockBits handling step by step.

1. 为什么charPixels数组全为0？ #

Looking at your conversion function, there are two critical bugs causing this unexpected behavior:

a. 仅复制了单行像素数据 #

Your code uses memcpy(charPixels, gdiBitmapData.Scan0, stride); which only copies one row of pixels (since stride represents the byte count per row). But you allocated height * stride bytes for charPixels and initialized the entire buffer to 0 with memset—so all rows after the first remain zero.

Fix this by copying the full pixel data set:

memcpy(charPixels, gdiBitmapData.Scan0, height * stride);

b. Base64仅编码了单行数据 #

You're calling base64_encode(charPixels, stride); which only encodes the first row of your pixel buffer. You need to encode the entire allocated buffer instead:

std::string ret = base64_encode(charPixels, height * stride);

额外验证点：像素格式匹配 #

Double-check that the PixelFormat32bppARGB passed to LockBits matches your bitmap's actual format. From your init code, you created the bitmap with PixelFormat32bppARGB, so this should be okay—but it's a common gotcha if issues persist.

2. LockBits的安全解锁方式 #

You're absolutely right to worry about unlocking an un-locked buffer—it can lead to undefined behavior or exceptions. Here's a robust approach using a flag to track if LockBits succeeded:

修改后的转换函数（包含安全解锁逻辑） #

std::string GdiBitmapToBase64(Gdiplus::Bitmap* gdiBitmap, int width, int height) {
    unsigned char* charPixels = nullptr;
    Gdiplus::BitmapData gdiBitmapData{}; // Initialize to zero-initialized state
    bool isLocked = false; // Track if LockBits completed successfully

    try {
        Gdiplus::Rect rect(0, 0, width, height);
        // Explicitly check LockBits status before proceeding
        Gdiplus::Status status = gdiBitmap->LockBits(
            &rect, 
            Gdiplus::ImageLockMode::ImageLockModeRead, 
            PixelFormat32bppARGB, 
            &gdiBitmapData
        );
        if (status != Gdiplus::Ok) {
            // Handle error (e.g., log message, return empty string)
            return "";
        }
        isLocked = true;

        int stride = gdiBitmapData.Stride;
        // Handle bottom-up bitmaps (negative stride)
        if (stride < 0) {
            stride = -stride;
        }

        charPixels = new unsigned char[height * stride];
        memcpy(charPixels, gdiBitmapData.Scan0, height * stride);

        std::string ret = base64_encode(charPixels, height * stride);
        return ret;
    } finally {
        // Only unlock if LockBits succeeded
        if (isLocked) {
            gdiBitmap->UnlockBits(&gdiBitmapData);
        }
        // Clean up allocated buffer
        if (charPixels != nullptr) {
            delete[] charPixels;
        }
    }
}

关键改进说明： #

• Added an isLocked flag to track whether LockBits completed without errors. We only call UnlockBits if this flag is true, avoiding invalid unlock attempts.
• Explicitly check the return status of LockBits—if it fails (e.g., invalid rectangle, format mismatch), we exit early instead of working with invalid BitmapData.
• Properly handle negative stride (for bottom-up bitmaps) by adjusting the stride value, making the code more robust even if your current bitmap uses positive stride.

额外性能小建议 #

In your ScreenUpdated function, using SetPixel in nested loops is quite slow for large bitmaps. If performance becomes an issue later, consider using LockBits there too to write directly to the pixel buffer—it's significantly faster than repeated SetPixel calls.

内容的提问来源于stack exchange，提问作者user2732707