AD设备GUI迁移脚本报错：找不到设备，请求语法排查

问题描述 #

所有通过Autopilot部署的设备集中在一个OU中，需要迁移到对应站点的OU。编写的GUI工具流程为：输入设备名称和站点名称后，获取对应站点OU并在Out-GridView展示，选中后填入文本框；点击「移动设备」按钮时提示「找不到设备」错误，需排查语法问题。

错误原因分析 #

1. 目标OU路径构造错误

   • 原代码中$DestOU错误地将文本框的属性名text直接作为字符串拼接，且额外添加了OU=前缀。实际上$DESTINATION_OU.Text已经是完整的OU可分辨名称（DistinguishedName），无需再拼接固定路径。
   • 路径末尾多余的逗号会导致AD识别失败。

2. 设备身份标识（Identity）问题

   • 原代码中设备DN末尾多余逗号，会导致AD无法正确定位设备对象。
   • 未先验证设备是否存在，直接执行移动操作，容易触发「找不到设备」错误。

3. 变量属性大小写问题

   • PowerShell对.NET属性名称大小写敏感，$DESTINATION_OU.text应改为$DESTINATION_OU.Text。

修正后的完整脚本 #

Add-Type -Name Window -Namespace Console -MemberDefinition '
[DllImport("Kernel32.dll")]
public static extern IntPtr GetConsoleWindow();

[DllImport("user32.dll")]
public static extern bool ShowWindow(IntPtr hWnd, Int32 nCmdShow);'

[Console.Window]::ShowWindow([Console.Window]::GetConsoleWindow(), 0)
<# 
.NAME
    AP Device Move
#>

Add-Type -AssemblyName System.Windows.Forms
[System.Windows.Forms.Application]::EnableVisualStyles()

$Form                            = New-Object system.Windows.Forms.Form
$Form.ClientSize                 = New-Object System.Drawing.Point(400,400)
$Form.text                       = "AP Device Move Tool"
$Form.TopMost                    = $false

$LBL_APDEVICE                    = New-Object system.Windows.Forms.Label
$LBL_APDEVICE.text               = "Computer Name"
$LBL_APDEVICE.AutoSize           = $true
$LBL_APDEVICE.width              = 25
$LBL_APDEVICE.height             = 10
$LBL_APDEVICE.location           = New-Object System.Drawing.Point(0,2)
$LBL_APDEVICE.Font               = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$TBX_APDEVICE                    = New-Object system.Windows.Forms.TextBox
$TBX_APDEVICE.Text               = ""
$TBX_APDEVICE.multiline          = $false
$TBX_APDEVICE.width              = 100
$TBX_APDEVICE.height             = 20
$TBX_APDEVICE.location           = New-Object System.Drawing.Point(6,37)
$TBX_APDEVICE.Font               = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$LBL_SITE                        = New-Object system.Windows.Forms.Label
$LBL_SITE.text                   = "Site Name"
$LBL_SITE.AutoSize               = $true
$LBL_SITE.width                  = 25
$LBL_SITE.height                 = 10
$LBL_SITE.location               = New-Object System.Drawing.Point(4,71)
$LBL_SITE.Font                   = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$LOCATION                        = New-Object system.Windows.Forms.TextBox
$LOCATION.multiline              = $false
$LOCATION.width                  = 100
$LOCATION.height                 = 20
$LOCATION.location               = New-Object System.Drawing.Point(3,101)
$LOCATION.Font                   = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$DESTINATION_OU                  = New-Object system.Windows.Forms.TextBox
$DESTINATION_OU.text             = ""
$DESTINATION_OU.multiline        = $false
$DESTINATION_OU.width            = 300
$DESTINATION_OU.height           = 20
$DESTINATION_OU.location         = New-Object System.Drawing.Point(14,194)
$DESTINATION_OU.Font             = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$TARGET_OU                       = New-Object system.Windows.Forms.Label
$TARGET_OU.text                  = "Target OU"
$TARGET_OU.AutoSize              = $true
$TARGET_OU.width                 = 25
$TARGET_OU.height                = 10
$TARGET_OU.location              = New-Object System.Drawing.Point(12,139)
$TARGET_OU.Font                  = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$Get_OU                          = New-Object system.Windows.Forms.Button
$Get_OU.text                     = "Get OUs for Site"
$Get_OU.width                    = 104
$Get_OU.height                   = 30
$Get_OU.location                 = New-Object System.Drawing.Point(133,54)
$Get_OU.Font                     = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$BTN_MOVE                        = New-Object system.Windows.Forms.Button
$BTN_MOVE.text                   = "Move Device"
$BTN_MOVE.width                  = 91
$BTN_MOVE.height                 = 30
$BTN_MOVE.location               = New-Object System.Drawing.Point(34,246)
$BTN_MOVE.Font                   = New-Object System.Drawing.Font('Microsoft Sans Serif',10)

$Form.controls.AddRange(@($LBL_APDEVICE,$TBX_APDEVICE,$LBL_SITE,$LOCATION,$DESTINATION_OU,$TARGET_OU,$Get_OU,$BTN_MOVE))

$Get_OU.Add_Click({ GetSiteOUs })
$BTN_MOVE.Add_Click({ doit })

#region Logic 
function GetSiteOUs  {
    $selectedOU = Get-ADOrganizationalUnit -Filter "Name -Like '*$($LOCATION.Text.Trim())*'" |
        Select-Object -Property Name, Distinguishedname |
        Out-GridView -PassThru -Title "Select the OU"
        
    if ($selectedOU) {
        $DESTINATION_OU.Text = $selectedOU.Distinguishedname
    }
}

function doit{
    $DEVICE = $TBX_APDEVICE.Text.Trim()
    $DestOU = $DESTINATION_OU.Text.Trim()

    # 验证输入是否为空
    if (-not $DEVICE -or -not $DestOU) {
        [System.Windows.Forms.MessageBox]::Show("请填写完整的设备名称和目标OU", "输入错误", [System.Windows.Forms.MessageBoxButtons]::OK, [System.Windows.Forms.MessageBoxIcon]::Warning)
        return
    }

    # 构造设备DN并验证存在性
    $deviceDN = "CN=$DEVICE,OU=Autopilot,OU=Lucy,OU=linus,OU=Brown,OU=charlie,DC=Mickey,DC=Mouse"
    try {
        $adDevice = Get-ADComputer -Identity $deviceDN -ErrorAction Stop
        Move-ADObject –Identity $adDevice -TargetPath $DestOU -ErrorAction Stop
        [System.Windows.Forms.MessageBox]::Show("设备迁移成功", "操作完成", [System.Windows.Forms.MessageBoxButtons]::OK, [System.Windows.Forms.MessageBoxIcon]::Information)
    }
    catch [Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException] {
        [System.Windows.Forms.MessageBox]::Show("找不到指定设备：$DEVICE", "错误", [System.Windows.Forms.MessageBoxButtons]::OK, [System.Windows.Forms.MessageBoxIcon]::Error)
    }
    catch {
        [System.Windows.Forms.MessageBox]::Show("迁移失败：$($_.Exception.Message)", "错误", [System.Windows.Forms.MessageBoxButtons]::OK, [System.Windows.Forms.MessageBoxIcon]::Error)
    }
}
#endregion

[void]$Form.ShowDialog()

额外优化点 #

• 增加了输入验证，避免空值触发错误
• 添加了异常捕获，明确不同错误类型的提示信息
• 调整目标OU文本框宽度，适配完整的DN显示
• 在GetSiteOUs中展示OU名称和DN，方便用户选择

内容的提问来源于stack exchange，提问作者PCMedicJAX