Python类属性验证未抛出预期错误，如何修正？

问题描述 #

尝试为Python类属性添加类型检查和文件存在验证，但实例化不存在的文件时未抛出预期的IOError，反而出现AttributeError: 'DataReplacement' object has no attribute '_fullpath'。代码实现如下：

# A class to represent a dataset upload replacement operation
import os

class DataReplacement:
    def __init__(self, portal, inputfolder, input, output, audience):
        self.portal = portal
        self.inputfolder = inputfolder
        self.input = input
        self.output = output
        self.audience = audience
        self.fullpath = os.path.join(inputfolder, input)

    @property
    def fullpath(self):
        return self._fullpath

    @fullpath.setter
    def fullpath(self, value):
        try:
            isinstance(self.inputfolder, str) and isinstance(self.input, str)  
        except ValueError:
            raise ValueError("inputfolder and input must be a string") from None
        fp = os.path.join(self.inputfolder, self.input)
        if os.path.exists(fp):
            self._fullpath = os.path.join(self.inputfolder, self.input)
        else:
            raise IOError(f"file {self.fullpath} does not exist.") from None

正常实例化存在的文件无错误，但实例化不存在的文件时触发上述属性错误。

错误原因 #

1. 无效的类型检查逻辑：isinstance()函数不会抛出ValueError，所以try-except块完全不起作用，类型检查从未触发过错误。
2. 错误信息中非法访问属性：当文件不存在时，错误信息里使用self.fullpath，此时_fullpath还未被赋值，访问fullpath属性会调用@property的getter方法，进而触发AttributeError。
3. setter方法未使用传入值：fullpath的setter方法接收了value参数，但实际逻辑里完全忽略了它，而是重新计算路径，违背了setter的设计逻辑，也导致初始化时传入的路径值没有被利用。

修正后的代码 #

import os

class DataReplacement:
    def __init__(self, portal, inputfolder, input, output, audience):
        self.portal = portal
        self.inputfolder = inputfolder
        self.input = input
        self.output = output
        self.audience = audience
        # 触发setter逻辑
        self.fullpath = os.path.join(inputfolder, input)

    @property
    def fullpath(self):
        return self._fullpath

    @fullpath.setter
    def fullpath(self, value):
        # 直接做类型检查，不需要try-except
        if not isinstance(self.inputfolder, str) or not isinstance(self.input, str):
            raise ValueError("inputfolder and input must be strings")
        
        fp = value
        if not os.path.exists(fp):
            # 错误信息里用计算好的fp，而不是self.fullpath
            raise IOError(f"file {fp} does not exist.")
        self._fullpath = fp

额外优化建议 #

• 如果fullpath只能由inputfolder和input组合生成，可去掉setter的value参数，直接在setter里计算路径，避免外部随意修改：

@fullpath.setter
def fullpath(self, value):
    if not isinstance(self.inputfolder, str) or not isinstance(self.input, str):
        raise ValueError("inputfolder and input must be strings")
    
    fp = os.path.join(self.inputfolder, self.input)
    if not os.path.exists(fp):
        raise IOError(f"file {fp} does not exist.")
    self._fullpath = fp

• 考虑使用pathlib替代os.path，更符合Python现代路径操作习惯：

from pathlib import Path

# 替换路径检查部分
fp = Path(self.inputfolder) / self.input
if not fp.exists():
    raise IOError(f"file {fp} does not exist.")
self._fullpath = str(fp)

内容的提问来源于stack exchange，提问作者jbchurchill