Python函数调用后无法更新enemyHP变量值的问题求助

问题描述 #

编写了一段宝可梦战斗风格的Python代码，Act函数负责处理玩家攻击操作，扣除敌人生命值，但每次调用函数后，外部的敌人HP变量并未更新，即使函数使用了return语句也无效。相关代码和运行示例如下：

原代码 #

import random

# 假设这些变量已提前定义
MoveList = ["Scratch", "Ember", "Growl", "Leer"]
RivalPKMN = "Quaxly"
starter = "Litten"
RivalHP = 55.0
RivalType = "Water"
battling = True  # 原代码里的true是错误的，Python布尔值首字母大写

def Act(enemy, pokemon, enemyHP, enemyType):
  num = round(random.uniform(0.95, 1.75), 2)
  print(MoveList)
  Move1 = input("Choose your attack! Input a number from 1-4, depending on the order of your moves. Input 5 to view everyone's stats! \n")
  if Move1 == "1":
    Move1 = str(MoveList[0])
    attacked = True
    dmg = 10 * num
    Move1 = MoveList[0]
    print(pokemon + " used " + Move1 + "! \n")
    enemyHP -= dmg
    print("It dealt " + str(dmg) + " damage to " + enemy + "! \n")
    print(enemy + " is now at " + str(enemyHP) + " HP!")
    return enemyHP

while battling == True:
    Act(RivalPKMN, starter, RivalHP, RivalType)

运行示例 #

['Scratch', 'Ember', 'Growl', 'Leer']
Choose your attack! Input a number from 1-4, depending on the order of your moves. Input 5 to view everyone's stats! 
1
Litten used Scratch! 

It dealt 10.5 damage to Quaxly! 

Quaxly is now at 44.5 HP!

第二次调用函数时，敌人HP仍显示初始数值，未更新。

问题原因 #

1. Python参数传递机制：对于int、float这类不可变类型，函数参数是传值传递——函数内部的enemyHP是外部变量RivalHP的副本，修改这个副本不会影响外部的原始变量。
2. 未接收返回值：虽然函数return了更新后的enemyHP，但调用函数时没有把返回值赋值回外部的RivalHP，导致外部变量始终保持初始值。
3. 语法小错误：原代码中battling == true不符合Python规范，布尔值应写为True（首字母大写）。

解决方案 #

核心修复：接收函数返回值更新外部变量 #

修改while循环中的调用语句，把函数返回的新HP值赋值给RivalHP，让外部变量同步更新：

while battling == True:
    RivalHP = Act(RivalPKMN, starter, RivalHP, RivalType)
    # 新增战斗结束逻辑：敌人HP归零时终止循环
    if RivalHP <= 0:
        print(f"{RivalPKMN} fainted! You win!")
        battling = False

额外优化建议 #

• 补全其他输入分支逻辑（比如输入2-4的攻击、输入5查看状态），避免函数在非1输入时无返回值导致报错。
• 遵循PEP8命名规范，用enemy_hp替代enemyHP这类驼峰命名，提升代码可读性。
• 用f-string简化字符串拼接，让输出代码更简洁：

  print(f"{pokemon} used {Move1}! \n")
  print(f"It dealt {dmg} damage to {enemy}! \n")
  print(f"{enemy} is now at {enemyHP} HP!")
  

修复后的完整示例代码 #

import random

MoveList = ["Scratch", "Ember", "Growl", "Leer"]
RivalPKMN = "Quaxly"
starter = "Litten"
rival_hp = 55.0
rival_type = "Water"
battling = True

def act(enemy, pokemon, enemy_hp, enemy_type):
    num = round(random.uniform(0.95, 1.75), 2)
    print(MoveList)
    move_choice = input("Choose your attack! Input a number from 1-4, depending on the order of your moves. Input 5 to view everyone's stats! \n")
    
    if move_choice == "1":
        move = MoveList[0]
        dmg = 10 * num
        print(f"{pokemon} used {move}! \n")
        enemy_hp -= dmg
        print(f"It dealt {dmg} damage to {enemy}! \n")
        print(f"{enemy} is now at {enemy_hp} HP!")
    elif move_choice == "5":
        print(f"Your {pokemon}: HP XXX")
        print(f"Rival's {enemy}: HP {enemy_hp}, Type {enemy_type}")
    # 可继续添加其他攻击选项的逻辑
    
    return enemy_hp

while battling:
    rival_hp = act(RivalPKMN, starter, rival_hp, rival_type)
    if rival_hp <= 0:
        print(f"{RivalPKMN} fainted! You won the battle!")
        battling = False

内容的提问来源于stack exchange，提问作者highrez42