MVVM模式下如何用DialogService打开窗口？解决视觉树层级异常

我实现了一个DialogService用于弹窗展示：

using RControl.Client.Abstractions;
using System;
using System.Windows;

namespace RControl.Client.Services;

public class DialogService : IDialogService
{
    public void ShowDialog<TViewModel>(TViewModel viewModel)
    {
        var window = new Window
        {
            Content = Activator.CreateInstance(ViewLocator.GetViewType(typeof(TViewModel))),
            DataContext = viewModel,
        };

        window.ShowDialog();
    }
}

配套的ViewLocator类负责根据ViewModel查找对应的View：

using System;
using System.Linq;
using System.Reflection;

namespace RControl.Client;

public static class ViewLocator
{
    private const string ViewSuffix = "View";
    private const string ViewModelSuffix = "ViewModel";

    public static Type GetViewType(Type viewModelType)
    {
        var viewName = viewModelType.Name.Replace(ViewModelSuffix, string.Empty) + ViewSuffix;
        var viewType = Assembly.GetExecutingAssembly().GetTypes().FirstOrDefault(t => t.Name == viewName);

        return viewType ?? throw new ArgumentException($"View not found for {viewModelType.Name}.");
    }
}

但当我通过RelayCommand调用该服务时：

[RelayCommand]
private void About()
{
    var viewModel = new AboutViewModel();
    _dialogService.ShowDialog(viewModel);
}

抛出异常：System.InvalidOperationException: "The Window object must be the root of the tree. You cannot add a Window object as a child object for Visual."

我需要实现和直接执行var window = new AboutView(); window.ShowDialog();完全相同的行为，该如何修改代码？

问题根源 #

你通过ViewLocator获取的AboutView本身就是Window类型，而原代码将它作为子控件赋值给了另一个Window的Content属性，这违反了WPF的可视化树规则——Window不能作为其他Visual元素的子节点。

修改后的DialogService #

只需要在创建View实例后，判断它是否为Window类型：如果是，直接设置DataContext并显示；如果是普通控件（如UserControl），再用外层Window包裹。

using RControl.Client.Abstractions;
using System;
using System.Windows;

namespace RControl.Client.Services;

public class DialogService : IDialogService
{
    public void ShowDialog<TViewModel>(TViewModel viewModel)
    {
        var viewType = ViewLocator.GetViewType(typeof(TViewModel));
        var viewInstance = Activator.CreateInstance(viewType);

        if (viewInstance is Window dialogWindow)
        {
            // View本身就是Window，直接配置并显示
            dialogWindow.DataContext = viewModel;
            dialogWindow.ShowDialog();
        }
        else
        {
            // 普通控件，用外层Window包裹
            var wrapperWindow = new Window
            {
                Content = viewInstance,
                DataContext = viewModel
            };
            wrapperWindow.ShowDialog();
        }
    }
}

这样修改后，当AboutView是Window类型时，行为就和你手动实例化并调用ShowDialog()完全一致；同时也兼容基于UserControl的弹窗场景，扩展性更强。

内容的提问来源于stack exchange，提问作者vitkuz573