Django项目TypeError：NoneType与decimal.Decimal无法乘法运算求助

错误信息 #

File "F:\Coding Related\Karmachari-BackEnd\Karmachari_App\mainapp\models.py", line 97, in calculate_net_salary
    gross_pay = self.hours_worked * self.basic_pay_rate
                
TypeError: unsupported operand type(s) for *: 'NoneType' and 'decimal.Decimal'

相关代码 #

models.py #

class Payroll(models.Model):
    user = models.ForeignKey(User,on_delete=models.CASCADE)
    basic_pay_rate = models.DecimalField(max_digits=8, default=10000, decimal_places=2)
    overtime = models.DecimalField(max_digits=8,null=True, decimal_places=2)
    hours_worked = models.FloatField(null=True, blank=True)
    deductions = models.DecimalField(max_digits=8,null=True, decimal_places=2)
    net_pay = models.DecimalField(max_digits=8,null=True, blank=True, decimal_places=2)

    def calculate_net_salary(self):
        gross_pay = self.hours_worked * self.basic_pay_rate
        net_pay = gross_pay + self.overtime - self.deductions
        self.net_pay.save()

    # def save(self, *args, **kwargs):
    #     self.net_salary = self.calculate_net_salary()
    #     super(Payroll, self).save(*args, **kwargs)
    
    def __str__(self):
        return self.user.username

views.py #

def payroll(request):
    payrolls = Payroll.objects.all()
    for payroll in payrolls:
        payroll.calculate_net_salary()
    user_object = User.objects.get(username=request.user.username)
    profile = Profile.objects.get(user=user_object)
    context={
        'profile':profile,
        'navbar':'salary',
        'payroll': payroll,
    }
    return render(request,'Salary_Sheet.html',context)

错误原因 #

你给hours_worked、overtime、deductions设置了null=True，意味着这些字段可以是空值（Python里的None）。当某个Payroll实例的hours_worked为None时，用空值去乘decimal.Decimal类型的basic_pay_rate，Python会直接报错——空值不能和数字做乘法运算。后续overtime和deductions如果是空值，也会引发加减运算错误。

另外，calculate_net_salary里的self.net_pay.save()写法错误，net_pay是字段值，不是模型实例，无法直接调用save()方法。

解决方案 #

1. 修复薪资计算方法，处理空值并正确保存 #

修改模型中的calculate_net_salary方法，给可能为空的字段设置默认值，同时修正保存逻辑：

from decimal import Decimal

def calculate_net_salary(self):
    # 给空字段设置默认值，避免None参与运算
    hours = self.hours_worked or 0.0
    overtime = self.overtime or Decimal(0.0)
    deductions = self.deductions or Decimal(0.0)
    
    # 把float类型的工时转成Decimal，和薪资率类型统一后再计算
    gross_pay = Decimal(hours) * self.basic_pay_rate
    net_pay = gross_pay + overtime - deductions
    
    # 赋值后保存整个Payroll实例
    self.net_pay = net_pay
    self.save()

2. 优化视图逻辑，避免无效遍历 #

原视图遍历所有员工的工资单没必要，只需处理当前登录用户的薪资即可：

def payroll(request):
    user_object = User.objects.get(username=request.user.username)
    profile = Profile.objects.get(user=user_object)
    # 获取当前用户的工资单，不存在则自动创建
    payroll, created = Payroll.objects.get_or_create(user=user_object)
    payroll.calculate_net_salary()
    
    context={
        'profile':profile,
        'navbar':'salary',
        'payroll': payroll,
    }
    return render(request,'Salary_Sheet.html',context)

3. 可选：从根源避免空值（推荐） #

如果这些字段默认值应该为0（比如没加班时 overtime 就是0），可以修改模型字段，去掉null=True并添加默认值：

overtime = models.DecimalField(max_digits=8, default=0, decimal_places=2)
hours_worked = models.FloatField(default=0.0, blank=True)
deductions = models.DecimalField(max_digits=8, default=0, decimal_places=2)

修改后需要执行数据库迁移命令：

python manage.py makemigrations
python manage.py migrate

内容的提问来源于stack exchange，提问作者Sumeet.py