Spring Data JPA中一对多关联实体更新失败问题排查

我在Spring Data JPA中尝试更新带有一对多关联的Director实体，调用接口后返回"added"但数据库没有任何变化，但更新firstname这类普通字段时一切正常。相关代码如下：

Director实体类 #

@Entity
@AllArgsConstructor
@NoArgsConstructor
@Builder
@Data
public class Director {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    private Long id;

    @Column(nullable = false)
    @Size(min = 3)
    private String firstname;

    @Column(nullable = false)
    @Size(min = 3)
    private String lastname;

    @OneToMany(mappedBy = "director")
    private Set<Movie> movies;

}

Movie实体类 #

@Entity
@AllArgsConstructor
@NoArgsConstructor
@Builder
@Data
public class Movie {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    private Long id;
    private String name;

    @ManyToOne
    @JoinColumn(name = "director_id")
    private Director director;

    @Enumerated(value = EnumType.STRING)
    private MovieGenre genre;

    private String description;

    @ManyToMany
    @JoinTable(name = "actorsMovies",
    joinColumns = @JoinColumn(name = "movie_id"),
    inverseJoinColumns = @JoinColumn(name = "actor_id"))
    private Set<Actor> stars;

    private Integer release;

}

Controller类 #

@PostMapping("{directorId}/addMovie/{movieId}")
public String addMovieToDirector(
        @PathVariable("directorId") Long directorId,
        @PathVariable("movieId") Long movieId) {

    log.info("directorId: " + directorId);
    log.info("movieId: " + movieId);

   return directorService.addMovieToDirector(directorId, movieId);
}

Service类 #

@Override
public String addMovieToDirector(Long directorId, Long movieId) {

    if (directorRepository.findById(directorId).isPresent() && movieRepository.findById(movieId).isPresent()) {
        Director director = directorRepository.findById(directorId).get();
        Set<Movie> movies = director.getMovies();
        Movie movie = movieRepository.findById(movieId).get();
        if (movies.contains(movie)) return "contains";
        movies.add(movie);
        director.setMovies(movies);
        directorRepository.save(director);
        return "added";
    }
    return "error";
}

原因分析 #

• Director的@OneToMany注解中设置了mappedBy = "director"，这表示关联关系的维护端是Movie实体，Director是被动的被维护端。JPA只关注维护端的状态变化，仅更新被维护端的集合不会触发数据库变更。
• 当前逻辑只在Director的movies集合中添加了Movie，但未设置Movie的director属性，维护端状态无变化，因此数据库不会更新。

解决方案 #

修改Service逻辑，同时更新维护端（Movie）的关联状态：

@Override
public String addMovieToDirector(Long directorId, Long movieId) {
    Optional<Director> directorOpt = directorRepository.findById(directorId);
    Optional<Movie> movieOpt = movieRepository.findById(movieId);
    
    if (directorOpt.isPresent() && movieOpt.isPresent()) {
        Director director = directorOpt.get();
        Movie movie = movieOpt.get();
        
        // 直接通过Movie的director判断关联是否已存在
        if (movie.getDirector() != null && movie.getDirector().getId().equals(directorId)) {
            return "contains";
        }
        
        // 更新维护端（Movie）的关联，这是触发数据库更新的关键
        movie.setDirector(director);
        movieRepository.save(movie);
        
        // 同步更新被维护端集合，保证内存中实体状态一致
        director.getMovies().add(movie);
        directorRepository.save(director);
        
        return "added";
    }
    return "error";
}

额外优化建议 #

1. 避免多次调用findById，合并查询提升性能；
2. 可给@OneToMany添加cascade = CascadeType.ALL或cascade = CascadeType.PERSIST，但需注意级联操作的业务副作用；
3. 在Director中添加辅助方法统一维护关联：

public void addMovie(Movie movie) {
    this.movies.add(movie);
    movie.setDirector(this);
}

调用时只需director.addMovie(movie)，即可同时维护两端状态，代码更简洁。

内容的提问来源于stack exchange，提问作者milosz000