Java Socket多用户聊天应用添加文件传输功能及代码异常排查求助

Hey there! Let's break down your problems step by step and get your file transfer feature working smoothly.

Since your app already uses a command-based system (like msg or login), extending this to file transfers makes perfect sense. Here are two solid approaches:

• Command Prefix Method: Use a command like file jony c://abc.txt to trigger a file send. When the server parses this command, it knows to switch from handling text messages to processing incoming file data. This aligns with your existing code structure perfectly.
• Type Flag Method: Prepend every message with a single byte that identifies its type (e.g., 0 for text, 1 for file). The server reads this flag first, then routes the data to the correct handler. This is more flexible if you plan to add more message types later.

For your current setup, the command prefix method is the easiest to implement—let's stick with that (we can adjust your sendFile command to include a target username, like sendFile jony D://abc.txt).

The root issue here is mixed stream usage and unflushed data. Let's go through the fixes:

Server Side Issues & Fixes #

Your code uses both BufferedReader (a character stream) and DataInputStream (a byte stream) on the same socket input stream. Character streams buffer bytes under the hood, which means when you call readLine(), it might consume part of the file data before your handleFile method gets to it. Plus, you're re-creating a DataInputStream instead of using your existing member variable.

Modified Server Code Snippets #

1. Replace BufferedReader with DataInputStream for command reading:

   // Remove the BufferedReader entirely
   while (true) {
       // Use readUTF() to read commands (client must use writeUTF() to send them)
       String line = inputStream.readUTF();
       if (line == null || line.isEmpty()) break;
   
       String[] tokens = StringUtils.split(line);
       if (tokens != null && tokens.length > 0) {
           String cmd = tokens[0];
           // ... keep your existing command logic for login/msg/etc.
           else if ("sendFile".equalsIgnoreCase(cmd)) {
               handleFile();
           }
           // ... rest of your commands
       }
   }
   

2. Simplify handleFile to use the existing inputStream:

   private void handleFile (){
       System.out.println("File handler called");
       try {
           int fileNameLength = inputStream.readInt();
           System.out.println("Filename length: " + fileNameLength);
           
           if (fileNameLength > 0) {
               byte[] fileNameBytes = new byte[fileNameLength];
               inputStream.readFully(fileNameBytes);
               String fileName = new String(fileNameBytes);
               System.out.println("Receiving file: " + fileName);
   
               int fileContentLength = inputStream.readInt();
               System.out.println("File content length: " + fileContentLength);
               
               if (fileContentLength > 0) {
                   byte[] fileContentBytes = new byte[fileContentLength];
                   inputStream.readFully(fileContentBytes);
                   
                   FileOutputStream fileOutputStream = new FileOutputStream("D:\\bbb.txt");
                   fileOutputStream.write(fileContentBytes);
                   fileOutputStream.close();
                   System.out.println("File saved successfully!");
               }
           }
       } catch (IOException e) {
           e.printStackTrace(); // Don't skip this—you'll catch hidden errors!
       }
   }
   

Client Side Issues & Fixes #

Your client has two key problems: extra invalid data being sent, and unflushed streams. Also, you're sending the login command repeatedly in the loop, which isn't necessary.

Modified Client Code Snippets #

1. Use writeUTF() for commands (matches server's readUTF()):

   public static void main(String[] args) {
       Scanner scanner = new Scanner(System.in);
       File file = new File("D:\\aaa.txt");
       
       try {
           Socket socket = new Socket("localhost", 6000);
           DataInputStream inputStream = new DataInputStream(socket.getInputStream());
           DataOutputStream dataOutputStream = new DataOutputStream(socket.getOutputStream());
   
           // Login ONCE, not every loop iteration
           dataOutputStream.writeUTF("login alvy alvy");
           dataOutputStream.flush();
   
           while(true){
               System.out.println("Enter command (type 'sendFile' to send file):");
               String echoString = scanner.nextLine();
               
               if ("sendFile".equalsIgnoreCase(echoString)) {
                   dataOutputStream.writeUTF("sendFile");
                   dataOutputStream.flush();
   
                   // Send file data
                   FileInputStream fileInputStream = new FileInputStream(file.getAbsolutePath());
                   String fileName = file.getName();
                   byte[] fileNameBytes = fileName.getBytes();
                   byte[] fileBytes = new byte[(int)file.length()];
                   
                   fileInputStream.read(fileBytes);
                   fileInputStream.close(); // Clean up file stream
   
                   // Send file metadata and content
                   dataOutputStream.writeInt(fileNameBytes.length);
                   dataOutputStream.write(fileNameBytes);
                   dataOutputStream.writeInt(fileBytes.length);
                   dataOutputStream.write(fileBytes);
                   dataOutputStream.flush(); // Ensure all data is sent
                   System.out.println("File sent!");
               } else {
                   // Send other commands as usual
                   dataOutputStream.writeUTF(echoString);
                   dataOutputStream.flush();
               }
           }
       } catch (IOException e) {
           e.printStackTrace();
       }
   }
   

   • Removed the extra dataOutputStream.writeInt(50); line—it was corrupting the filename length reading.
   • Added flush() calls to make sure data isn't stuck in the buffer.
   • Moved the login outside the loop to avoid duplicate login attempts.

Right now your code saves the file to the server, but to make it client-to-client:

1. Update the sendFile command to include a target username: sendFile jony D://abc.txt
2. On the server, parse the target username, check if they're online, and retrieve their DataOutputStream
3. Send a notification to the target client (e.g., receiveFile abc.txt)
4. Read the file data from the sender, then write it directly to the target client's output stream
5. Send confirmation messages to both clients once transfer is complete

This way, the server acts as a relay instead of storing the file itself.

内容的提问来源于stack exchange，提问作者Alvy Feroz