C++条件输入学生信息程序报错排查求助

Hey there! Let's work through your C++ code issues step by step—since you're new to the language, these are all super common pitfalls, so don't stress about it!

Let's break down exactly what's causing your code to fail:

• Struct design doesn't match your needs
  Your current student struct only stores one course and grade, but each student will have multiple classes. You need a container inside the struct to hold multiple course-grade pairs.
• Variable misuse
  • student_t is a single instance of your student struct, not an array—so using student_t.name[i] is invalid.
  • vector<student> input(i); initializes a vector with an uninitialized i (its value is random), which will cause unpredictable behavior or crashes.
  • You defined input() as a global function but tried to call it like student[i].input()—global functions can't be invoked through struct instances like that.
• Backwards logic checks
  The string::compare() function returns 0 when strings are equal. Your code uses if (student_t.name.compare("stop")) which breaks when the name isn't "stop"—the exact opposite of what you want.
• Input handling bugs
  Mixing getline(cin, ...) and cin >> ... leaves newline characters in the input buffer, so the next getline will read an empty string instead of your input.
• Incorrect loop structure
  You're using a fixed for loop of 20 iterations, but you need to loop until the user types "stop" for a student name.

Here's a corrected version of your code with key improvements explained:

#include <iostream>
#include <vector>
#include <string>
#include <utility>
#include <limits>

using namespace std;

// Updated struct: each student has a name and a list of course-grade pairs
struct Student {
    string name;
    vector<pair<string, int>> courses;
};

// Function to input one student's data (takes a reference to avoid copying)
void inputStudent(Student& student) {
    cout << "Enter student name (type 'stop' to end): ";
    getline(cin, student.name);

    // Exit if user types "stop" for the name
    if (student.name == "stop") {
        return;
    }

    string course;
    int grade;
    while (true) {
        cout << "Enter course name (type 'stop' to finish this student): ";
        getline(cin, course);

        if (course == "stop") {
            break;
        }

        cout << "Enter grade for " << course << ": ";
        cin >> grade;
        // Clear the newline left in the buffer by cin >>
        cin.ignore(numeric_limits<streamsize>::max(), '\n');
        
        // Add the course and grade to the student's list
        student.courses.emplace_back(course, grade);
    }
}

int main() {
    vector<Student> allStudents;
    Student currentStudent;

    while (true) {
        inputStudent(currentStudent);
        // Stop loop if user entered "stop" for the name
        if (currentStudent.name == "stop") {
            break;
        }
        // Save the current student and reset for the next one
        allStudents.push_back(currentStudent);
        currentStudent.name.clear();
        currentStudent.courses.clear();
    }

    // Print all collected student data
    cout << "\n--- All Student Records ---" << endl;
    for (const auto& student : allStudents) {
        cout << "\nStudent: " << student.name << endl;
        for (const auto& coursePair : student.courses) {
            cout << "  • " << coursePair.first << ": " << coursePair.second << endl;
        }
    }

    return 0;
}

Key Fixes: #

• Struct update: Uses vector<pair<string, int>> to store multiple courses and grades per student.
• Input buffer handling: Adds cin.ignore() after cin >> grade to clear leftover newlines, fixing the getline issue.
• Logical checks: Uses simple == comparisons for strings (more intuitive for beginners than compare()).
• Dynamic loops: Uses while(true) to keep inputting students/courses until "stop" is entered, no fixed iteration limits.
• Proper variable use: Passes Student objects by reference to avoid unnecessary copying, and uses a vector to store all student data correctly.

• Avoid using namespace std; in large projects (it causes naming conflicts), but it's fine for small practice code.
• Prefer ==/!= over compare() for string equality checks—they're easier to read.
• Always watch for input buffer issues when mixing getline and cin >>!

内容的提问来源于stack exchange，提问作者user16003119