Laravel用户角色切换功能优化咨询：动态展示非当前角色选项与代码复用实现

Hey Luke, let's tackle your questions one by one and refactor your code to be more scalable and maintainable!

1. How to list all roles except the current user's role? #

First, let's define all your valid roles in a central place (your User model) so you don't have to repeat them everywhere. This makes it easy to add/remove roles later:

// app/Models/User.php
class User extends Authenticatable
{
    // Define all valid roles (slug => human-readable label)
    public const ROLES = [
        'student' => 'Student',
        'teacher' => 'Teacher',
        'admin' => 'Admin',
    ];

    // ... rest of your model code
}

Next, we can create an accessor in the User model to automatically calculate available roles for any user. This keeps the logic tied to the User where it belongs:

// Add this to your User model
public function getAvailableRolesAttribute()
{
    // Filter out the user's current role from the full roles list
    return collect(self::ROLES)->filter(function ($label, $slug) {
        return $slug !== $this->role;
    });
}

Now, any User instance will have an available_roles property that contains all roles except their current one.

2. Should this logic live in the controller or view? #

Always keep business logic out of your views! Views should only handle rendering data, not calculating it. Putting this logic in the User model (via an accessor) or controller follows Laravel's MVC principles, makes your code easier to test, and keeps your views clean.

With the accessor above, your controller just needs to pass users to the view like normal:

// Your controller's index method
public function index()
{
    $users = User::all();
    return view('users.index', compact('users'));
}

3. Using slugs + foreach to avoid duplicate code #

Since we're storing roles as slugs (like student, teacher) in the database, we can loop through the available_roles in your view to generate role options dynamically—no more repeated @if/@else blocks!

Here's how to refactor your view to use a single form with a dropdown (cleaner than multiple buttons):

{{-- resources/views/users/index.blade.php --}}
@foreach($users as $user)
    <div class="user-role-control">
        <p>Current Role: {{ \App\Models\User::ROLES[$user->role] }}</p>
        
        <form action="/admin/users/{{ $user->id }}" method="POST">
            @csrf
            @method('PATCH')
            
            <select name="role" class="role-select" required>
                @foreach($user->available_roles as $slug => $label)
                    <option value="{{ $slug }}">{{ $label }}</option>
                @endforeach
            </select>
            
            <button type="submit" class="btn">Update Role</button>
        </form>
    </div>
@endforeach

Also, let's update your update method to use the defined roles for validation (more reliable than checking the database):

public function update(User $user)
{
    $attributes = request()->validate([
        'role' => ['required', \Illuminate\Validation\Rule::in(array_keys(\App\Models\User::ROLES))]
    ]);

    $user->update($attributes);
    return back()->with('success', 'User Updated!');
}

Bonus: Why this approach is better? #

• Scalability: Add a new role just by updating the ROLES constant in the User model—no changes needed in views or validation.
• Maintainability: All role-related logic is centralized, so you don't have to hunt through views to make changes.
• Cleaner code: No repeated form blocks; the foreach loop handles all role options dynamically.

内容的提问来源于stack exchange，提问作者Luke Wilson