TypeScript中array.pop()返回类型误判问题的最优解决方案（不使用as或ts-ignore）

Great question! The core issue here is that TypeScript's type narrowing doesn't fully recognize that your weekdays?.length check guarantees the array is non-empty in the subsequent block. Optional chaining can make it harder for the type system to track that the array hasn't been mutated (even though in your synchronous code, that's impossible).

Here are the cleanest, type-safe solutions to fix this:

1. Split the Condition for Explicit Type Narrowing #

By separating the check for weekdays being defined and having a non-zero length, TypeScript can properly narrow the type to a non-empty string array inside the block:

// (weekdays 类型为 string[])
if (weekdays && weekdays.length) {
  const sunday = weekdays.pop(); // Type is now `string`, not `string | undefined`
  weekdays.unshift(sunday);
}

This works because TypeScript knows that if both weekdays is truthy (not undefined/null) and weekdays.length is truthy (greater than 0), the array must have at least one element—so pop() can't return undefined.

2. Use a Custom Type Guard (For Reusable Checks) #

If you need to perform this non-empty array check multiple times across your codebase, a custom type guard makes your intent clear and helps TypeScript narrow the type reliably:

// Reusable type guard function
function isNonEmptyArray<T>(arr: T[] | undefined): arr is T[] {
  return !!arr && arr.length > 0;
}

// (weekdays 类型为 string[])
if (isNonEmptyArray(weekdays)) {
  const sunday = weekdays.pop(); // Type is `string`
  weekdays.unshift(sunday);
}

The arr is T[] assertion explicitly tells TypeScript that if the function returns true, the input is definitely a non-empty array of type T[].

3. Assign to a Const Variable (For Let-Declared Arrays) #

If weekdays is declared with let (meaning it could be reassigned later), assigning it to a const variable first helps TypeScript track its type more accurately:

let weekdays: string[] = ['mon', 'tue', 'wed', 'thu', 'fri', 'sat', 'sun'];

const fixedWeekdays = weekdays;
if (fixedWeekdays.length) {
  const sunday = fixedWeekdays.pop(); // Type is `string`
  fixedWeekdays.unshift(sunday);
}

Since fixedWeekdays is a const, TypeScript knows it can't be reassigned, so the length check guarantees the array is non-empty for the duration of the block.

内容的提问来源于stack exchange，提问作者Heloi Abreu