Node.js+MongoDB开发Bootcamp API时findOneAndUpdate参数错误排查

问题场景 #

使用Node.js + MongoDB开发Bootcamp API时，调用updateBootcamp方法出现以下错误：

"error": "Parameter "filter" to findOneAndUpdate() must be an object, got "5d713a66ec8f2b88b8f830b8" (type string)"

控制器代码 #

exports.updateBootcamp = asyncHandler(async (req, res, next) => {
        let bootcamp = await Bootcamp.findById(req.params.id);
      
        if (!bootcamp) {
          return next(
            new ErrorResponse(`Bootcamp not found with id of ${req.params.id}`, 404)
          );
        }
      
        // 验证用户是否为训练营所有者或管理员
        if (bootcamp.user.toString() !== req.user.id && req.user.role !== 'admin') {
          return next(
            new ErrorResponse(
              `User ${req.params.id} is not authorized to update this bootcamp`,
              401
            )
          );
        }
      
        bootcamp = await Bootcamp.findOneAndUpdate(req.params.id, req.body, {
          new: true,
          runValidators: true
        });
      
        res.status(200).json({ success: true, data: bootcamp });
      });

Bootcamp模型代码 #

const mongoose = require('mongoose');
const slugify = require('slugify');
const geocoder = require('../utils/geocoder');

const BootcampSchema = new mongoose.Schema({
    name: {
        type: String,
        required: [true, 'Please add a name'],
        unique: true,
        trim: true,
        maxLength: [50, 'Name cannot be more than 50 characters']
    },
    slug: String,
    description: {
        type: String,
        required: [true, 'Please add a description'],
        maxLength: [500, 'Description cannot be more than 500 characters']
        
    },
    website: {
        type: String,
        match: [
            /https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&\/\/=]*)/,
            'Please use a valid URL with HTTP or HTTPS'
        ]
    },
    phone: {
        type: String,
        maxLength: [20, 'Phone number cannot be longer than 20 characters']
    },
    email: {
        type: String,
        match: [
            /^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})$/,
            'Please add a valid email'
        ]
    },
    address: {
        type: String,
        required: [true, 'Please add an address']
    },
    location: {
        type: {
            //GeoJSON Point
            type: String,
            enum: ['Point']
        },
        coordinates: {
            type:  [Number],
            index: '2dsphere'
        },
        formattedAddress: String,
        street: String,
        city: String,
        state: String,
        zipcode: String,
        country: String
    },
    careers: {
        //Array of strings
        type: [String],
        required: true,
        enum: [
            'Web Development',
            'Mobile Development',
            'UI/UX',
            'Data Science',
            'Business',
            'Other'
        ]
    },
    averageRating: {
        type: Number,
        min: [1, 'Rating must be at least 1'],
        max: [10, 'Rating must can not be more than 10']
    },
    averageCost: Number,
    photo: {
        type: String,
        default: 'no-photo.jpg'
    },
    housing: {
        type: Boolean,
        default: false
    },
    jobAssistance: {
        type: Boolean,
        default: false
    },
    jobGuarantee: {
        type: Boolean,
        default: false
    },
    acceptGi: {
        type: Boolean,
        default: false
    },
    createdAt: {
        type: Date,
        default: Date.now
    },
    user: {
        type: mongoose.Schema.ObjectId,
        ref: 'User',
        required: true
      }
}, {
    toJSON: {virtuals: true}, 
    toObject: {virtuals: true}
});

错误原因 #

这是控制器代码的问题，和模型无关。

Mongoose的findOneAndUpdate()方法要求第一个参数必须是查询条件对象，而你直接传入了字符串类型的ID。虽然findById()可以直接接收ID字符串作为参数，但findOneAndUpdate()不支持这种写法，它需要明确的查询过滤条件（比如{ _id: 你的ID }）。

解决方案 #

有两种修复方式：

方式1：修改findOneAndUpdate的参数 #

把第一个参数改成包含_id的查询对象：

bootcamp = await Bootcamp.findOneAndUpdate({ _id: req.params.id }, req.body, {
  new: true,
  runValidators: true
});

方式2：改用findByIdAndUpdate（更推荐） #

既然已经通过findById()验证了Bootcamp存在，直接使用findByIdAndUpdate()更简洁，它支持直接传入ID字符串：

bootcamp = await Bootcamp.findByIdAndUpdate(req.params.id, req.body, {
  new: true,
  runValidators: true
});

两种方式都能解决参数类型错误的问题，方式2更贴合你的代码逻辑，因为已经做过一次ID查询验证，用findByIdAndUpdate()语义更明确。

内容的提问来源于stack exchange，提问作者tukitooo1998