MaterialAlertDialogBuilder二次调用showDialog崩溃问题求助

封装了一个EditProductNameDialog类，基于MaterialAlertDialog实现对话框功能。首次调用showDialog()方法时对话框能正常显示，但关闭后第二次调用该方法会直接崩溃，报错信息如下：

E  FATAL EXCEPTION: main
Process: com.x, PID: 22834
java.lang.IllegalStateException: 指定的子View已经有父容器。必须先在子View的父容器上调用removeView()。
at android.view.ViewGroup.addViewInner(ViewGroup.java:5330)
at android.view.ViewGroup.addView(ViewGroup.java:5153)
at android.view.ViewGroup.addView(ViewGroup.java:5122)
at androidx.appcompat.app.AlertController.setupCustomContent(AlertController.java:657)
at androidx.appcompat.app.AlertController.setupView(AlertController.java:475)
at androidx.appcompat.app.AlertController.installContent(AlertController.java:233)
at androidx.appcompat.app.AlertDialog.onCreate(AlertDialog.java:279)
at android.app.Dialog.dispatchOnCreate(Dialog.java:453)
at android.app.Dialog.show(Dialog.java:334)
at androidx.appcompat.app.AlertDialog$Builder.show(AlertDialog.java:1009)
at com.x.presentation.home.EditProductNameDialog.showDialog(EditProductNameDialog.kt:51)
at com.x.presentation.home.HomeFragment$onCreateView$2.onUpdateDeviceNameClicked(HomeFragment.kt:108)
at com.x.presentation.home.HomeAdapter$ViewHolder.bind$lambda$3(HomeAdapter.kt:117)
at com.x.presentation.home.HomeAdapter$ViewHolder.$r8$lambda$aTtDIYUkGHPBeMRj7HGd0tdAPJI(Unknown Source:0)
at com.x.presentation.home.HomeAdapter$ViewHolder$$ExternalSyntheticLambda3.onClick(Unknown Source:4)
at android.view.View.performClick(View.java:7751)
at android.view.View.performClickInternal(View.java:7724)
at android.view.View.access$3700(View.java:858)
at android.view.View$PerformClick.run(View.java:29334)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:210)
at android.os.Looper.loop(Looper.java:299)
at android.app.ActivityThread.main(ActivityThread.java:8280)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:576)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1073)

相关代码如下：

Dialog封装类代码 #

class EditProductNameDialog(
    activity: Activity
) {

    private var isShowing = false
    private var dialog: Dialog? = null
    private var materialAlertDialogBuilder: MaterialAlertDialogBuilder
    private var buttonOk: TextView
    private var buttonCancel: Button

    init {
        materialAlertDialogBuilder = MaterialAlertDialogBuilder(activity)
        val customAlertDialogView = LayoutInflater.from(activity)
            .inflate(R.layout.fragment_home_edit_product_name_dialog, null, false)

        buttonOk = customAlertDialogView.findViewById(R.id.buttonOK)
        buttonCancel = customAlertDialogView.findViewById(R.id.buttonCancel)

        materialAlertDialogBuilder.setCancelable(false)
        materialAlertDialogBuilder.setView(customAlertDialogView)
    }

    @Synchronized
    fun showDialog(
        productName: String,
        onCancelClicked: (() -> Unit),
        onOKClicked: (() -> Unit)
    ) {
        if (!isShowing) {
            isShowing = true
            buttonCancel.setOnClickListener {
                onCancelClicked()
                dismissDialog()
            }
            buttonOk.setOnClickListener {
                //onOKClicked()
                dismissDialog()
            }
            dialog = materialAlertDialogBuilder.show()
        }
    }

    @Synchronized
    fun dismissDialog() {
        if (isShowing) {
            isShowing = false
            dialog?.dismiss()
        }
    }
}

对话框布局XML #

<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content">

    <Button
        android:id="@+id/buttonCancel"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Cancel"/>

    <Button
        android:id="@+id/buttonOK"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="OK"/>

</androidx.constraintlayout.widget.ConstraintLayout>

崩溃的核心原因是自定义对话框的View被重复添加到父容器：
在init块中，你一次性创建了自定义View并绑定到MaterialAlertDialogBuilder；第一次调用show()时，这个View会被添加到Dialog的内部容器中；当Dialog被dismiss()后，该View并没有从原父容器中移除，第二次调用show()时，Builder尝试再次将同一个View添加到新的Dialog容器，就会触发"指定的子View已经有父容器"的异常。

提供两种可行的修复方式：

方案1：每次显示对话框时重新创建View和Builder #

把创建自定义View和Builder的逻辑移到showDialog()方法内，确保每次显示都使用全新的View实例：

class EditProductNameDialog(
    private val activity: Activity
) {

    private var isShowing = false
    private var dialog: Dialog? = null

    @Synchronized
    fun showDialog(
        productName: String,
        onCancelClicked: (() -> Unit),
        onOKClicked: (() -> Unit)
    ) {
        if (!isShowing) {
            isShowing = true
            // 每次show都重新创建Builder和自定义View
            val materialAlertDialogBuilder = MaterialAlertDialogBuilder(activity)
            val customAlertDialogView = LayoutInflater.from(activity)
                .inflate(R.layout.fragment_home_edit_product_name_dialog, null, false)
            val buttonOk = customAlertDialogView.findViewById<Button>(R.id.buttonOK)
            val buttonCancel = customAlertDialogView.findViewById<Button>(R.id.buttonCancel)

            materialAlertDialogBuilder.setCancelable(false)
            materialAlertDialogBuilder.setView(customAlertDialogView)

            buttonCancel.setOnClickListener {
                onCancelClicked()
                dismissDialog()
            }
            buttonOk.setOnClickListener {
                onOKClicked()
                dismissDialog()
            }
            dialog = materialAlertDialogBuilder.show()
        }
    }

    @Synchronized
    fun dismissDialog() {
        if (isShowing) {
            isShowing = false
            dialog?.dismiss()
            dialog = null // 释放引用，避免内存泄漏
        }
    }
}

方案2：关闭对话框时从父容器移除自定义View #

如果想复用View实例，可以在dismissDialog()时将自定义View从父容器中移除，这样下次显示时可以重新添加：

class EditProductNameDialog(
    activity: Activity
) {

    private var isShowing = false
    private var dialog: Dialog? = null
    private var materialAlertDialogBuilder: MaterialAlertDialogBuilder
    private var buttonOk: Button
    private var buttonCancel: Button
    private var customAlertDialogView: View // 保存自定义View引用

    init {
        materialAlertDialogBuilder = MaterialAlertDialogBuilder(activity)
        customAlertDialogView = LayoutInflater.from(activity)
            .inflate(R.layout.fragment_home_edit_product_name_dialog, null, false)

        buttonOk = customAlertDialogView.findViewById(R.id.buttonOK)
        buttonCancel = customAlertDialogView.findViewById(R.id.buttonCancel)

        materialAlertDialogBuilder.setCancelable(false)
    }

    @Synchronized
    fun showDialog(
        productName: String,
        onCancelClicked: (() -> Unit),
        onOKClicked: (() -> Unit)
    ) {
        if (!isShowing) {
            isShowing = true
            // 重新设置View到Builder（因为之前可能被移除了）
            materialAlertDialogBuilder.setView(customAlertDialogView)
            
            buttonCancel.setOnClickListener {
                onCancelClicked()
                dismissDialog()
            }
            buttonOk.setOnClickListener {
                onOKClicked()
                dismissDialog()
            }
            dialog = materialAlertDialogBuilder.show()
        }
    }

    @Synchronized
    fun dismissDialog() {
        if (isShowing) {
            isShowing = false
            dialog?.dismiss()
            dialog = null
            // 从父容器移除自定义View
            (customAlertDialogView.parent as? ViewGroup)?.removeView(customAlertDialogView)
        }
    }
}

• 修正buttonOk的类型：原代码中定义为TextView，但XML里是Button，统一类型可避免潜在的强转问题；
• 每次dismiss()后将dialog置为null，避免持有过期引用导致内存泄漏；
• 如果没有多线程调用showDialog的场景，可以移除@Synchronized注解，减少性能开销。

内容的提问来源于stack exchange，提问作者Metropol_Tilkisi